💬 achow101 commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#issuecomment-1867889571)
> This is not actually true. Thinking about this more, I wonder if a more natural way of representing standalone keys in the wallet is just to treat them as a new [descriptor type](https://github.com/bitcoin/bitcoin/blob/master/doc/descriptors.md#reference), like `void(KEY)`, where the void descriptor would hold the key, but instead of [expanding](https://github.com/bitcoin/bitcoin/blob/4b1196a9855dcd188a24f393aa2fa21e2d61f061/src/script/descriptor.h#L98) to a scriptPubKey or set of scriptPubKey
...

🤔 murchandamus reviewed a pull request: "wallet: Add CoinGrinder coin selection algorithm"
(https://github.com/bitcoin/bitcoin/pull/27877#pullrequestreview-1794686545)
Rebased and addressed comments by @kashifs. Thanks for the thorough read, @kashifs.

💬 murchandamus commented on pull request "wallet: Add CoinGrinder coin selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1435191286)
Thanks, I’ll fix that

💬 murchandamus commented on pull request "wallet: Add CoinGrinder coin selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1435192987)
Thanks, I’ve amended the documentation

💬 murchandamus commented on pull request "wallet: Add CoinGrinder coin selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1435191774)
Fixed, thanks

📝 TomBriar opened a pull request: "Compressed Bitcoin Transactions"
(https://github.com/bitcoin/bitcoin/pull/29134)
This is a draft PR and reference implementation for a Compressed Bitcoin Transaction, As stated in the doc the main application for this is steganography, satellite/radio broadcast, and other low bandwidth channels with a high CPU availability on decompression.

doc: Added Compressed Transaction Schema Documentation
util: Added a variable length bitstream encoder
script: Added the rest of the IsPayTo Script functions, And Split ExtractDestination into two functions for ease of use
node: Add
...

💬 murchandamus commented on issue "Flaky `wallet_transactiontime_rescan.py --legacy-wallet` functional test":
(https://github.com/bitcoin/bitcoin/issues/28221#issuecomment-1867929889)
Well, if it’s just me that is affected that might be resolved by getting a faster computer.

💬 mzumsande commented on pull request "net: Make AddrFetch connections to fixed seeds":
(https://github.com/bitcoin/bitcoin/pull/26114#discussion_r1435262125)
I don't quite follow: The fixed seeds will eventually be added to addrman as a fallback unconditionally, both in the case where we got sufficient addresses from addrfetch peers and in the case where that didn't work for some reason.

💬 hebasto commented on issue "Unnecessary symbols being exported in `libbitcoinconsensus.so`":
(https://github.com/bitcoin/bitcoin/issues/26698#issuecomment-1867962234)
> Thanks, I'll pile on some more. I've alluded to this in other threads (#24994), but still haven't seen a summary of:
>
> * What currently happens with `lld` + `libstdc++`?
>
> * What currently happens with `lld` + `libc++`?
>
> * Maybe even, what happens with [`mold`](https://github.com/rui314/mold) and either standard library?
>
> * What happens under LTO, in any combination of the above?

I've done some tests on Ubuntu 22.04 using a simple model code, compiling
...

⚠️ badergithub opened an issue: "Only"
(https://github.com/bitcoin/bitcoin/issues/29135)

✅ hebasto closed an issue: "Only"
(https://github.com/bitcoin/bitcoin/issues/29135)

:lock: hebasto locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/29135)

💬 murchandamus commented on pull request "Add Gutter Guard Selector":
(https://github.com/bitcoin/bitcoin/pull/28977#discussion_r1435289402)
I combined the two loops

🤔 murchandamus reviewed a pull request: "Add Gutter Guard Selector"
(https://github.com/bitcoin/bitcoin/pull/28977#pullrequestreview-1794849255)
Addressed comments by @achow101

💬 murchandamus commented on issue "fuzz, coinselection: Assertion 'result_bnb->GetChange(coin_params.m_cost_of_change, CAmount{0}) == 0' failed":
(https://github.com/bitcoin/bitcoin/issues/28918#issuecomment-1868003060)
I think that this should be fixed with the merge of #28372

✅ dergoegge closed an issue: "fuzz, coinselection: Assertion 'result_bnb->GetChange(coin_params.m_cost_of_change, CAmount{0}) == 0' failed"
(https://github.com/bitcoin/bitcoin/issues/28918)

💬 TheCharlatan commented on pull request "indexes: Stop using node internal types and locking cs_main, improve sync logic":
(https://github.com/bitcoin/bitcoin/pull/24230#issuecomment-1868061457)
Concept ACK

💬 conduition commented on pull request "datacarriersize: Match more datacarrying":
(https://github.com/bitcoin/bitcoin/pull/28408#issuecomment-1868073814)
> I heard from a guy who runs various inscription businesses that he even tried to do it offchain, but users were not interested in saving money on the offchain tx fee by sacrificing the benefits of onchain; users were only interested when he did it onchain.

@eragmus Woah. That speaks volumes about the users who are paying these exorbitant fees. Thanks for that account.

👍 alfonsoromanz approved a pull request: "Fix: Ensure 'Transaction View' remains disabled if no wallet is selected"
(https://github.com/bitcoin-core/gui/pull/780#pullrequestreview-1795194240)
Tested ACK https://github.com/bitcoin-core/gui/pull/780/commits/b2e531e70a88f5c9e1c055ae7341520a3128e15d


👍 alfonsoromanz approved a pull request: "Update Node window title with the chain type"
(https://github.com/bitcoin-core/gui/pull/758#pullrequestreview-1795257848)
Tested ACK https://github.com/bitcoin-core/gui/pull/758/commits/9d37886a3b6ce24f4a4a05193eb0d071655a8457

<img width="1044" alt="Screenshot 2023-12-22 at 18 59 27" src="https://github.com/bitcoin-core/gui/assets/19962151/a3a591a9-35e2-4298-a07b-014364c0f430">