📝 Laughter79 opened a pull request: "hi there"
(https://github.com/bitcoin/bitcoin/pull/29131)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ achow101 closed a pull request: "hi there"
(https://github.com/bitcoin/bitcoin/pull/29131)

📝 achow101 locked a pull request: "."
(https://github.com/bitcoin/bitcoin/pull/29131)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

🤔 BrandonOdiwuor reviewed a pull request: "wallet, rpc: add BIP44 `account` in `createwallet`"
(https://github.com/bitcoin/bitcoin/pull/29129#pullrequestreview-1793977794)
Concept ACK

⚠️ YezikTech opened an issue: "Operation Sweep"
(https://github.com/bitcoin/bitcoin/issues/29132)
### Please describe the feature you'd like to see added.

an L1 upgrade proposition

### Is your feature related to a problem, if so please describe it.

The Bitcoin blockchain is designed primarily for storing transaction data, though it has also accommodated other types of data, including non-transaction elements like images (JPGs) and malicious uploads. While these elements may not directly impact the functionality of the blockchain, they pose security risks and clutter the network.

### Desc
...

💬 stratospher commented on pull request "test: create deterministic addrman in the functional tests":
(https://github.com/bitcoin/bitcoin/pull/29007#issuecomment-1867294505)
Updated the PR to remove `-addrmantest` ([git diff](https://github.com/bitcoin/bitcoin/compare/1b49149b3ed7366141f0090692256e82032cb9af..291a1a325db74ca5cd8ae1ca1e488ec62f99bc93)) in 5d27993.

💬 alpeshvas commented on pull request "datacarriersize: Match more datacarrying":
(https://github.com/bitcoin/bitcoin/pull/28408#issuecomment-1867310301)
> > > Just wanted to add my 2 cents here as a layman using and holding bitcoin. If the transaction fee rates remain this high for someone using bitcoin to transfer money from wallet A to wallet B then I don't see a future for bitcoin.
> > > The original goal of bitcoin is to make it a currency and a valued asset, if you sacrifice doing this in order to have secondary features then you will fail at both.
> > > If this PR will fix the fee rates back to normal I am on board.
> >
> >
> > Fee
...

✅ maflcko closed an issue: "Operation Sweep"
(https://github.com/bitcoin/bitcoin/issues/29132)

💬 maflcko commented on issue "Operation Sweep":
(https://github.com/bitcoin/bitcoin/issues/29132#issuecomment-1867410103)
Usually the issue tracker is used to track technical issues related to the Bitcoin Core code base.

General bitcoin questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com) or the `#bitcoin` IRC channel on Libera Chat, or one of the Bitcoin subreddits, or any other place that you feel is well suited.

Network-wide consensus and/or P2P changes first need to be discussed with the greater community, for example the `bitcoin-dev` maili
...

✅ maflcko closed a pull request: "test: autogenerate bash completion"
(https://github.com/bitcoin/bitcoin/pull/25243)

💬 naumenkogs commented on pull request "net, cli: use v2transport for manual/addrfetch connections, add to -netinfo":
(https://github.com/bitcoin/bitcoin/pull/29058#discussion_r1434855153)
Okay, so for this PR i'd just suggest clarifying the *newly added* comments like
``` // Attempt v2 connection if we support v2 - if our peer doesn't support it, we'll reconnect with v1.```
Right now they are not accurate, as if the banning thing (or some other disconnection reason) don't exist.

If you feel like it, might as well touch the existing comments as well (say around `ShouldReconnectV1`) :)

In future, we might communicate the disconnection reason (Ban, v1, eviction,
...

👋 maflcko's pull request is ready for review: "util: Faster std::byte (pre)vector (un)serialize"
(https://github.com/bitcoin/bitcoin/pull/29114)

💬 maflcko commented on pull request "util: Faster std::byte (pre)vector (un)serialize":
(https://github.com/bitcoin/bitcoin/pull/29114#issuecomment-1867422517)
Rebased and taken out of draft after the dependency https://github.com/bitcoin/bitcoin/pull/29056 was merged

💬 maflcko commented on issue "failure in wallet_basic.py --descriptors":
(https://github.com/bitcoin/bitcoin/issues/27249#issuecomment-1867447005)
Reproduced locally: https://drahtbot.space/temp_scratch/wallet_basic_coins_2.tar.xz

💬 maflcko commented on issue "Assertion failed: (data.size() > node.nSendOffset), function SocketSendData, file net.cpp, line 837":
(https://github.com/bitcoin/bitcoin/issues/27963#issuecomment-1867457231)
It may be good to check the upstream source code inside macOS for recently introduced issues.

💬 naumenkogs commented on pull request "test: adds outbound eviction functional tests, updates comment in ConsiderEviction":
(https://github.com/bitcoin/bitcoin/pull/29122#discussion_r1434889375)
I've spent a ridiculous amount of time understanding what's going on here, and I'm still far from being 100% sure. Perhaps if you touch this comment, you can expand it even further? E.g., connecting to each of the conditions in `else if`

💬 naumenkogs commented on pull request "net: Make AddrFetch connections to fixed seeds":
(https://github.com/bitcoin/bitcoin/pull/26114#discussion_r1434899330)
8d8e0b796dabba601742a9585237be5892c5f05a

maybe expand `for every reachable network`

💬 naumenkogs commented on pull request "net: Make AddrFetch connections to fixed seeds":
(https://github.com/bitcoin/bitcoin/pull/26114#discussion_r1434903032)
dfd635bcc9b3f3615cabe115af302df33efba6a1

nit: The first sentence talks about `might`, while the second makes a reader think this is unconditionally a fallback (which is not true). I'd suggest aligning the two

💬 Sjors commented on pull request "rpc: add path to gethdkey":
(https://github.com/bitcoin/bitcoin/pull/22341#issuecomment-1867496111)
I plan to re-work this on top of #29130 with a similar interface to `createwalletdescriptor`. That is, if you have a regular wallet with normal descriptors, it will Just Work(tm). Otherwise you need to specify which master key to use.

Initially I'll make a separate PR. If #26728 is closed in favor of the new approach in #29130 then this PR can be closed too.

💬 maflcko commented on pull request "util: Faster std::byte (pre)vector (un)serialize":
(https://github.com/bitcoin/bitcoin/pull/29114#issuecomment-1867496666)
cc @martinus