💬 Sjors commented on pull request "validation: log which peer sent us a header":
(https://github.com/bitcoin/bitcoin/pull/27826#discussion_r1413916982)
I solved the second issue by setting `/*via_unsolicited_block=*/!is_block_requested` (renamed `forceProcessing`). I'll push that in a bit.

I'm still debugging the first issue. E.g an example log during IBD, with `-debug=net -debug=validation -loglevel=validation:debug`:

```
2023-12-04T13:47:10Z Synchronizing blockheaders, height: 819750 (~100.00%)
2023-12-04T13:47:10Z [validation:debug] Saw new header hash=00000000000000000002d311ad8da2e7551130798984e20c87b8156c3d27d261 height=819750 pee
...

💬 Sjors commented on pull request "validation: log which peer sent us a header":
(https://github.com/bitcoin/bitcoin/pull/27826#discussion_r1413928471)
Ah, but that documentation is wrong. `ProcessBlock` only tells us if the _block_ is new, not if the header is new. The latter _is_ checked by `AcceptBlockHeader`, but not returned.

💬 murchandamus commented on issue "fuzz, coinselection: Assertion 'result_bnb->GetChange(coin_params.m_cost_of_change, CAmount{0}) == 0' failed":
(https://github.com/bitcoin/bitcoin/issues/28918#issuecomment-1838723096)
Sure, go ahead!

💬 Sjors commented on pull request "validation: log which peer sent us a header":
(https://github.com/bitcoin/bitcoin/pull/27826#issuecomment-1838743265)
Only keeping the first commit.

I don't want to make this PR more complicated. If anyone wants to try detecting new headers that arrive via an unsolicited block, see the following dropped commits: 386febd59bd894ad9c5216eacafe0308ed314980 and 708600f3b7df4cf166a2fcdfd3c0dc70b70812f0.

💬 Sjors commented on pull request "build: use macOS 14 SDK (Xcode 15.0)":
(https://github.com/bitcoin/bitcoin/pull/28622#issuecomment-1838752940)
Running into a build error with 78859dc3338f5dfd4f80452722e0c39ec6f68656:

```
compiling tools/qmap.cpp
In file included from global/qoperatingsystemversion.cpp:46:
In file included from ../../include/QtCore/5.15.11/QtCore/private/qcore_mac_p.h:1:
../../include/QtCore/5.15.11/QtCore/private/../../../../../src/corelib/kernel/qcore_mac_p.h:68:10: fatal error: 'CoreFoundation/CoreFoundation.h' file not found
#include <CoreFoundation/CoreFoundation.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...

✅ gianlucamazza closed an issue: "bitcoin core crashes and restarts syncing from beginning "
(https://github.com/bitcoin/bitcoin/issues/28795)

💬 fanquake commented on pull request "build: use macOS 14 SDK (Xcode 15.0)":
(https://github.com/bitcoin/bitcoin/pull/28622#issuecomment-1838758831)
Should be fixed now. Forgot that, we neeed to revert to including basically the entire SDK here, to accomodate Qt.

⚠️ hebasto opened an issue: "`capnp` fails when cross-compiling"
(https://github.com/bitcoin/bitcoin/issues/28993)
On the master branch @ 160d23677ad799cf9b493eaa923b2ac080c3fb8e, the `native/bin/capnp` fails when cross-compiling with `MULTIPROCESS=1`:
```
GEN /home/hebasto/git/bitcoin/depends/x86_64-pc-linux-gnu/include/mp/proxy.capnp.h
/home/hebasto/git/bitcoin/depends/x86_64-pc-linux-gnu/include/mp/proxy.capnp: File is not in the current directory and does not match any prefix defined with --src-prefix. Please pass an appropriate --src-prefix so I can figure out where to write the output for thi
...

💬 hebasto commented on issue "`capnp` fails when cross-compiling":
(https://github.com/bitcoin/bitcoin/issues/28993#issuecomment-1838761432)
cc @ryanofsky

👋 hebasto's pull request is ready for review: "depends: Build the `native_capnp` and `capnp` packages with CMake"
(https://github.com/bitcoin/bitcoin/pull/28856)

💬 hebasto commented on pull request "depends: Build the `native_capnp` and `capnp` packages with CMake":
(https://github.com/bitcoin/bitcoin/pull/28856#discussion_r1414020173)
While this change is an improvement, I've dropped it in the recent push as it does not related to this PR changes.

💬 hebasto commented on pull request "depends: Build the `native_capnp` and `capnp` packages with CMake":
(https://github.com/bitcoin/bitcoin/pull/28856#issuecomment-1838817927)
Rebased to include recent changes in the depends build system.

The PR description has been updated to mention one more fixed bug.

💬 adjmx commented on issue "macos: dmg not working on macOS Sonoma (14.x)":
(https://github.com/bitcoin/bitcoin/issues/28767#issuecomment-1838834600)
I just did manual install of `v26.0rc1` on M1 [Sonama 14.1.2]
The following commands produced the Bitcoin-QT.app file no problems.
I forgot the command for deploying .dmg

install dependencies
./autogen.sh
make -j 4
make deploy

💬 fanquake commented on pull request "build: use macOS 14 SDK (Xcode 15.0)":
(https://github.com/bitcoin/bitcoin/pull/28622#issuecomment-1838837355)
`4daaed2ef2253c9661779fa40bfff50655dc7ec45801aba5a39653e7bcdde48e Xcode_15.xip`.
`c0c2e7bb92c1fee0c4e9f3a485e4530786732d6c6dd9e9f418c282aa6892f55d Xcode-15.0-15A240d-extracted-SDK-with-libcxx-headers.tar.gz`.

✅ hebasto closed an issue: "macos: dmg not working on macOS Sonoma (14.x)"
(https://github.com/bitcoin/bitcoin/issues/28767)

💬 hebasto commented on issue "macos: dmg not working on macOS Sonoma (14.x)":
(https://github.com/bitcoin/bitcoin/issues/28767#issuecomment-1838840548)
Closing for now. Feel free to reopen if relevant.

💬 instagibbs commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#issuecomment-1838855510)
> I don’t know about automatically flushing out <= 0 fees even when the local mempool is empty. One could add significant computing payload on its mining competitors by throwing buffy packages with 0 fees parent and then replace the high-fee child (in a cycle).

The replacements are paying for those CPU cycles and bandwidth via "incremental feerate", it's equivalent to an entire package simply being RBF'd like normal. Keeping 0-fee parents hanging around in mempool would also allow new entrie
...

🤔 sr-gi reviewed a pull request: "p2p: Fill reconciliation sets (Erlay)"
(https://github.com/bitcoin/bitcoin/pull/28765#pullrequestreview-1762709866)
ACK [f895ae4](https://github.com/bitcoin/bitcoin/pull/28765/commits/f895ae4b7aa7263acba1adb3886c47a36f40b024)

💬 sr-gi commented on pull request "p2p: Fill reconciliation sets (Erlay)":
(https://github.com/bitcoin/bitcoin/pull/28765#discussion_r1414062310)
nit: if you have created a refactor commit to deal with removing the TODOs, it may be worth moving that change there.

Not sure if you're planning to squash it or not. Feel free to disregard.

💬 hebasto commented on pull request "depends: Include `config.guess` and `config.sub` into `meta_depends`":
(https://github.com/bitcoin/bitcoin/pull/28870#issuecomment-1838878294)
cc @fanquake