💬 maflcko commented on issue "bitcoin 25.1 regression test failure against sqlite 3.44.1":
(https://github.com/bitcoin/bitcoin/issues/28941#issuecomment-1834324033)
Closing for now. If there is more information, or steps to reproduce, or something else, it can be reopened.

💬 maflcko commented on issue "Building a wallet with legacy support fails on OpenBSD 7.4":
(https://github.com/bitcoin/bitcoin/issues/28963#issuecomment-1834327807)
I don't have OpenBSD, so I can't help here. However, it may be possible to undo the commit that removed `install_db4.sh`, or otherwise restore the script and use it (at your own risk). Longer term, it is recommend to move toward sqlite descriptor wallets.

💬 maflcko commented on issue "bitcoin core crashes and restarts syncing from beginning ":
(https://github.com/bitcoin/bitcoin/issues/28795#issuecomment-1834335007)
Anything left to do here? I see a thumb-up emoji reaction was done by the issue creator on the last reply.

💬 maflcko commented on issue "sendrawtransaction takes too long":
(https://github.com/bitcoin/bitcoin/issues/28745#issuecomment-1834341673)
Not sure what the status here is, and what is left to be done. Can this be closed?

💬 chenrui333 commented on issue "bitcoin 25.1 regression test failure against sqlite 3.44.1":
(https://github.com/bitcoin/bitcoin/issues/28941#issuecomment-1834366356)
> So this is homebrew on Linux?

yeah, linuxbrew got merged into homebrew, so right now homebrew-core CI runs on both linux and macos

> Please add exact steps to reproduce, otherwise little can be done here.

the reason why this does not happen for macos (I think) is due to the fact that we use system sqlite (uses_from_macos "sqlite"), which is using the old sqlite for macos builds.

I can run some local testing later and report it back.

💬 achow101 commented on pull request "bugfix: Make `CCheckQueue` RAII-styled (attempt 2)":
(https://github.com/bitcoin/bitcoin/pull/26762#issuecomment-1834404190)
ACK 5b3ea5fa2e7f6dc1c9161ed8b74c9be4bd1e92dd

💬 romanz commented on pull request "rpc: keep `.cookie` file if it was not generated":
(https://github.com/bitcoin/bitcoin/pull/28784#discussion_r1411168164)
Sounds good, reverted to use a boolean flag.

✅ achow101 closed an issue: "~CCheckQueue assertion failure during unclean exits"
(https://github.com/bitcoin/bitcoin/issues/25448)

🚀 achow101 merged a pull request: "bugfix: Make `CCheckQueue` RAII-styled (attempt 2)"
(https://github.com/bitcoin/bitcoin/pull/26762)

💬 maflcko commented on pull request "rpc: keep `.cookie` file if it was not generated":
(https://github.com/bitcoin/bitcoin/pull/28784#issuecomment-1834426399)
Note: If you revert to 7cb9367157eb42ee06bc6fa024522cc14a80138d instead (which is the same), the previous reviews will be valid again

💬 sipa commented on pull request "Nuke adjusted time (attempt 2)":
(https://github.com/bitcoin/bitcoin/pull/28956#discussion_r1411184510)
Shouldn't this use `min(N, m_index)` instead of `N`?

💬 romanz commented on pull request "rpc: keep `.cookie` file if it was not generated":
(https://github.com/bitcoin/bitcoin/pull/28784#issuecomment-1834442267)
> Note: If you revert to [7cb9367](https://github.com/bitcoin/bitcoin/commit/7cb9367157eb42ee06bc6fa024522cc14a80138d) instead (which is the same), the previous reviews will be valid again

Thanks - reverted to https://github.com/bitcoin/bitcoin/commit/7cb9367157eb42ee06bc6fa024522cc14a80138d.

💬 TheCharlatan commented on pull request "build: Introduce internal kernel library":
(https://github.com/bitcoin/bitcoin/pull/28690#issuecomment-1834461610)
Rebased 511e3fc74cdd03c36764eaf3bb637e7bbe98b335 -> 0af5d4d2d6c4201c7c6f1ba8b497cce23dc9f3ad ([kernelInternalLib_8](https://github.com/TheCharlatan/bitcoin/tree/kernelInternalLib_8) -> [kernelInternalLib_9](https://github.com/TheCharlatan/bitcoin/tree/kernelInternalLib_9), [compare](https://github.com/TheCharlatan/bitcoin/compare/kernelInternalLib_8..kernelInternalLib_9))

* Fixed conflict with https://github.com/bitcoin/bitcoin/pull/28451

💬 MarnixCroes commented on pull request "doc: explain what the wallet password does":
(https://github.com/bitcoin/bitcoin/pull/28974#discussion_r1411204053)
What do you mean with seed phrase/recovery phrase? I think you're confused with BIP39, which is not in Bitcoin Core

💬 jonatack commented on pull request "wallet: Add CoinGrinder coin selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/27877#issuecomment-1834473406)
Concept ACK based on today's IRC discussion https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2023-11-30#986727.

💬 achow101 commented on pull request "wallet: Cleanup accidental encryption keys in watchonly wallets":
(https://github.com/bitcoin/bitcoin/pull/28724#discussion_r1411216955)
Will add a comment if I re-touch

💬 achow101 commented on pull request "wallet: Cleanup accidental encryption keys in watchonly wallets":
(https://github.com/bitcoin/bitcoin/pull/28724#discussion_r1411217384)
I don't think it would be useful to log them.

💬 achow101 commented on pull request "wallet: Cleanup accidental encryption keys in watchonly wallets":
(https://github.com/bitcoin/bitcoin/pull/28724#discussion_r1411218639)
I think this is fine as is. It can be updated in the future if it becomes outdated.

💬 jonatack commented on pull request "net: additional disconnect logging":
(https://github.com/bitcoin/bitcoin/pull/28521#issuecomment-1834503005)
Concept ACK. I'd find it helpful to also log the addrport if `fLogIPs` is true, along with the network (for instance, because IPv6 addresses look the same as CJDNS ones), e.g. something like `net=..., peeraddr=...,`

👍 kristapsk approved a pull request: "rpc: keep `.cookie` file if it was not generated"
(https://github.com/bitcoin/bitcoin/pull/28784#pullrequestreview-1758419193)
re-ACK 7cb9367157eb42ee06bc6fa024522cc14a80138d