💬 TheCharlatan commented on pull request "build: Introduce internal kernel library":
(https://github.com/bitcoin/bitcoin/pull/28690#discussion_r1410832373)
Mmh, looking at the history, similar things are said in the commit message introducing the headers in `libbitcoin_crypto`: https://github.com/bitcoin/bitcoin/commit/4791b99e2dea0593775a8c75f62c8406d340191e. Maybe a regression was introduced at some point?

📝 fanquake opened a pull request: "ci: remove `libz-dev` from macOS build deps"
(https://github.com/bitcoin/bitcoin/pull/28973)
Remove no-longer used libz-dev (from DMG compression).
Followup to #28432.
Missed this in #28932.

💬 maflcko commented on pull request "build: Introduce internal kernel library":
(https://github.com/bitcoin/bitcoin/pull/28690#discussion_r1410836410)
Or it is a typo? "headers"/"modules"? cc @theuni

💬 ajtowns commented on pull request "p2p: Increase tx relay rate":
(https://github.com/bitcoin/bitcoin/pull/28592#issuecomment-1834012897)
> <instagibbs> _aj_ might be helpful to know what the potential downsides are to the PR
> (I have not thought about this stuff deeply)
> <_aj_> instagibbs: ie, why there's a limit at all?

The code comment explanation of this is:

```c++
/** Maximum rate of inventory items to send per second.
* Limits the impact of low-fee transaction floods. */
static constexpr unsigned int INVENTORY_BROADCAST_PER_SECOND = 7;
```

My understanding of this limit is that our
...

💬 ajtowns commented on pull request "p2p: Increase tx relay rate":
(https://github.com/bitcoin/bitcoin/pull/28592#issuecomment-1834020972)
> @ajtowns it did not crash my node. That's about the extend of monitoring I did on it, not sure what to measure.

I have a couple of patches at https://github.com/ajtowns/bitcoin/tree/202305-reportnetdata which can be used to track if the `inv_to_send` queues grow large and how quickly they empty out. With those patches, this script can be interesting:

```
bitcoin-cli getmempoolinfo | jq -j '"loaded:", .loaded, " ", .size, " txs ", (.bytes/1000000|floor), "MvB ", (.usage/.maxmempool*1000|
...

💬 hebasto commented on issue "RFC: Replacing Boost Process":
(https://github.com/bitcoin/bitcoin/issues/24907#issuecomment-1834065979)
> FWIW, I started working on replacing boost::process with cpp-subprocess on the following branch: [theStack/bitcoin@`nuke_boost_process`](https://github.com/theStack/bitcoin/tree/nuke_boost_process?rgh-link-date=2023-03-13T12%3A51%3A33Z)

I've picked up that branch. It appears that the upstream project requires a few patches to meet all our needs. The first one is https://github.com/arun11299/cpp-subprocess/pull/94.

🚀 ryanofsky merged a pull request: "refactor: Remove unused SER_DISK, SER_NETWORK, CDataStream"
(https://github.com/bitcoin/bitcoin/pull/28451)

📝 BrandonOdiwuor opened a pull request: "doc: explain what the wallet password does"
(https://github.com/bitcoin/bitcoin/pull/28974)
Fixes https://github.com/bitcoin/bitcoin/issues/18085

👍 TheCharlatan approved a pull request: "index: block filters sync, reduce disk read operations by caching last header"
(https://github.com/bitcoin/bitcoin/pull/28955#pullrequestreview-1757956519)
Re-ACK b19585e00a52c0b571e70ddb8f7c996d598c3435

💬 TheCharlatan commented on pull request "build: disable external-signer for Windows":
(https://github.com/bitcoin/bitcoin/pull/28967#issuecomment-1834191561)
Concept ACK

💬 mzumsande commented on issue "Increase # of block-relay-only connections ":
(https://github.com/bitcoin/bitcoin/issues/28462#issuecomment-1834199623)
> (feel free to double-check the [methodology](https://21.ninja/unique-reachable-nodes/methodology/))

I think that this methodology (using networks in getaddr responses) will likely overestimate the number of reachable peers on multiple networks, because accepting addrs from a network does not mean you are reachable on it. It doesn't even mean that you can connect to others over it:
For example, I think it's quite typical that some node operators would enable an onion service if they aren't
...

💬 theuni commented on pull request "refactor: Remove unused SER_DISK, SER_NETWORK, CDataStream":
(https://github.com/bitcoin/bitcoin/pull/28451#issuecomment-1834202682)
> rebased and added a commit to rename version.h to node/protocol_version.h

Nice, thanks, I was going to PR the same thing :)

👍 TheCharlatan approved a pull request: "ci: remove `libz-dev` from macOS build deps"
(https://github.com/bitcoin/bitcoin/pull/28973#pullrequestreview-1758075091)
ACK 97d53e90badc01224139a4a4356b934f338568d4

✅ maflcko closed an issue: "bitcoin 25.1 regression test failure against sqlite 3.44.1"
(https://github.com/bitcoin/bitcoin/issues/28941)

💬 maflcko commented on issue "bitcoin 25.1 regression test failure against sqlite 3.44.1":
(https://github.com/bitcoin/bitcoin/issues/28941#issuecomment-1834324033)
Closing for now. If there is more information, or steps to reproduce, or something else, it can be reopened.

💬 maflcko commented on issue "Building a wallet with legacy support fails on OpenBSD 7.4":
(https://github.com/bitcoin/bitcoin/issues/28963#issuecomment-1834327807)
I don't have OpenBSD, so I can't help here. However, it may be possible to undo the commit that removed `install_db4.sh`, or otherwise restore the script and use it (at your own risk). Longer term, it is recommend to move toward sqlite descriptor wallets.

💬 maflcko commented on issue "bitcoin core crashes and restarts syncing from beginning ":
(https://github.com/bitcoin/bitcoin/issues/28795#issuecomment-1834335007)
Anything left to do here? I see a thumb-up emoji reaction was done by the issue creator on the last reply.

💬 maflcko commented on issue "sendrawtransaction takes too long":
(https://github.com/bitcoin/bitcoin/issues/28745#issuecomment-1834341673)
Not sure what the status here is, and what is left to be done. Can this be closed?

💬 chenrui333 commented on issue "bitcoin 25.1 regression test failure against sqlite 3.44.1":
(https://github.com/bitcoin/bitcoin/issues/28941#issuecomment-1834366356)
> So this is homebrew on Linux?

yeah, linuxbrew got merged into homebrew, so right now homebrew-core CI runs on both linux and macos

> Please add exact steps to reproduce, otherwise little can be done here.

the reason why this does not happen for macos (I think) is due to the fact that we use system sqlite (uses_from_macos "sqlite"), which is using the old sqlite for macos builds.

I can run some local testing later and report it back.

💬 achow101 commented on pull request "bugfix: Make `CCheckQueue` RAII-styled (attempt 2)":
(https://github.com/bitcoin/bitcoin/pull/26762#issuecomment-1834404190)
ACK 5b3ea5fa2e7f6dc1c9161ed8b74c9be4bd1e92dd