💬 brunoerg commented on pull request "test: add coverage for bech32m in `wallet_keypool_topup`":
(https://github.com/bitcoin/bitcoin/pull/28928#issuecomment-1833739551)
> This can be tested by loading and unloading wallets instead of restarting nodes (this was a restriction from the past, prev to introducing multi-wallets support). No extra nodes nor restart is needed.

Just addressed it here

💬 kashifs commented on pull request "rpc,rest,zmq: faster getblock, NotifyBlock and rest_block by reading raw block":
(https://github.com/bitcoin/bitcoin/pull/26415#issuecomment-1833744139)
@andrewtoth, okay thanks. I did as you suggested and was able to get similar speed improvements when testing the `rest` command. 10.260ms on branch `master` and 1.014ms on branch `bitcoin-read-raw-block`. I only see improvements when running the `rest` testing command more than once though. Is this the expected behavior? I hope it's not due to some caching or other improvements unrelated to your code updates. Also, I was not able to appreciate any improvements when running the `RPC` command. Cou
...

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1410643071)
> What's the issue with using the transaction's vsize

My reasons were:
- I wanted to specify a value of sigops that wouldn't depend on the node's `-bytespersigop` setting, and similarly didn't want it to be bypassable locally this way
- People expressed confusion at what sigops-adjusted vsize was, so I wanted to make it clearer

Happy to change though, if it's preferred?

💬 brunoerg commented on issue "fuzz: Fix timeouts":
(https://github.com/bitcoin/bitcoin/issues/28812#issuecomment-1833748317)
> Another one: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=64593 cc @brunoerg

I don't have access to see it in depth 🙁.

I suppose it might be related to the descriptor parse. I think we can use `ImportDescriptors` from `wallet_notifications` in `scriptpubkeyman`.

💬 maflcko commented on issue "fuzz: Fix timeouts":
(https://github.com/bitcoin/bitcoin/issues/28812#issuecomment-1833752858)
> I don't have access to see it in depth 🙁.

The "Reproducer Testcase" should be public.

> I suppose it might be related to the descriptor parse.

Ah, good point. This was done intentionally. :sweat_smile:

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1410653204)
> Instead, I'd suggest that we not bother enforcing the v3 rules on a reorg.

I'm a fan of this approach. I want to spend a little bit of time thinking about what the possibilities are - I guess we can have some incorrect assumptions about transactions (resulting in e.g. incorect MinerScores) but it wouldn't be problematic if a reorg is the only way to get there, as you say.

💬 sipa commented on pull request "refactor: Remove unused SER_DISK, SER_NETWORK, CDataStream":
(https://github.com/bitcoin/bitcoin/pull/28451#issuecomment-1833766618)
utACK fa98a097a30bc39f2424c0efd28a7979155faae6

💬 brunoerg commented on issue "fuzz: Fix timeouts":
(https://github.com/bitcoin/bitcoin/issues/28812#issuecomment-1833771857)
> The "Reproducer Testcase" should be public.

"Access denied" when I try to access it.

🤔 furszy reviewed a pull request: "test: add coverage for bech32m in `wallet_keypool_topup`"
(https://github.com/bitcoin/bitcoin/pull/28928#pullrequestreview-1757470863)
how much faster the test got? Some numbers would encourage more reviewers to come here.

📝 maflcko opened a pull request: "test: Add and use option for tx-version in MiniWallet methods"
(https://github.com/bitcoin/bitcoin/pull/28972)
Fixes https://github.com/bitcoin/bitcoin/pull/26657#discussion_r1071362636 by adding a `version` keyword-argument to `create_self_transfer_multi`, and by passing it via `kwargs` from all other methods.

💬 maflcko commented on issue "fuzz: Fix timeouts":
(https://github.com/bitcoin/bitcoin/issues/28812#issuecomment-1833845779)
Ok, I see. I guess google requires login now, starting at some point in the past.

💬 instagibbs commented on pull request "bugfix, Change up submitpackage results to return results for all transactions":
(https://github.com/bitcoin/bitcoin/pull/28848#issuecomment-1833887261)
ping @Sjors @darosior @glozow should be ready for re-acks

💬 ajtowns commented on pull request "refactor: Remove unused SER_DISK, SER_NETWORK, CDataStream":
(https://github.com/bitcoin/bitcoin/pull/28451#issuecomment-1833929465)
ACK fa98a097a30bc39f2424c0efd28a7979155faae6

💬 Sjors commented on pull request "[WIP] add a stratum v2 template provider":
(https://github.com/bitcoin/bitcoin/pull/27854#issuecomment-1833934826)
I have a rebased and reorganised branch in progress that I'll link to here in a bit.

@ccdle12 are you still working on this? If not, I could take over and open a new PR. Otherwise, you could check if my branch is useful and use it here.

💬 instagibbs commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1410793961)
good news: this issue was discovered in less than a minute on a single core with the package fuzzer

🚀 fanquake merged a pull request: "guix: switch from `guix environment` to `guix shell`"
(https://github.com/bitcoin/bitcoin/pull/26077)

🚀 fanquake merged a pull request: "ci: Reduce use of bash -c"
(https://github.com/bitcoin/bitcoin/pull/28954)

🚀 fanquake merged a pull request: "fuzz: BIP324: damage ciphertext/aad in full byte range"
(https://github.com/bitcoin/bitcoin/pull/28951)

👍 fanquake approved a pull request: "msvc: Update vcpkg manifest"
(https://github.com/bitcoin/bitcoin/pull/28938#pullrequestreview-1757694045)
ACK 6d05c4fd138b80168d14a8cf1dbcca43782851af

🚀 fanquake merged a pull request: "msvc: Update vcpkg manifest"
(https://github.com/bitcoin/bitcoin/pull/28938)