✅ TaiseiLuette closed a pull request: "Create staging tree"
(https://github.com/bitcoin/bitcoin/pull/28914)

💬 maflcko commented on pull request "refactor: P2P transport without serialize version and type":
(https://github.com/bitcoin/bitcoin/pull/28892#discussion_r1398744244)
Correct, but I wasn't sure if reviewers preferred the slightly more verbose way to clarify that serialization is involved on every call.

💬 martinus commented on pull request "improve MallocUsage() accuracy":
(https://github.com/bitcoin/bitcoin/pull/28531#issuecomment-1818440265)
I can reproduce the same results with glibc 2.31 and 2.38, in 32bit and 64bit. I don't think it needs to be perfect on all platforms, I think your new calculation is fine.

I played a bit with a reproducer, here is mine: https://godbolt.org/z/zqhzxoobx I refactored your `MallocUsage` formula a bit, but it's basically the same

💬 maflcko commented on pull request "lint: Report all lint errors instead of early exit":
(https://github.com/bitcoin/bitcoin/pull/28862#discussion_r1398875960)
Are you sure? `all()` short circuits (https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.all), but the goal of this pull is to report all lint errors, not only the first one.

💬 maflcko commented on pull request "lint: Report all lint errors instead of early exit":
(https://github.com/bitcoin/bitcoin/pull/28862#discussion_r1398877832)
Also, style-wise, some people prefer `for` over functional programming when the predicate has side effects. Happy to push what you prefer, but I wanted to mention that this was written on purpose in this way.

💬 maflcko commented on pull request "lint: Report all lint errors instead of early exit":
(https://github.com/bitcoin/bitcoin/pull/28862#discussion_r1398881891)
I think this is already printed. For me:

```
...
^---- Failure generated from subtree check!
...

👍 hebasto approved a pull request: "coins: make sure PoolAllocator uses the correct alignment"
(https://github.com/bitcoin/bitcoin/pull/28913#pullrequestreview-1739334189)
ACK 486c2916a18b56d6011117077d906c1f8a81623f, tested on ARM 32-bit (ODROID-HC1 + Armbian 23.8.3 jammy) both native and Guix binaries.

The first commit should not introduce any behaviour change in any other [release](https://bitcoincore.org/en/download/) platforms as they are 64-bit and it is holds that `alignof(T) == alignof(void*) == 8` for all of them.

I agree with the second commit diff. It indeed handles the case where "int64_t is aligned to 8 bytes but void* is aligned to 4 bytes". Bu
...

💬 TheCharlatan commented on pull request "lint: Report all lint errors instead of early exit":
(https://github.com/bitcoin/bitcoin/pull/28862#discussion_r1398896203)
Yeah, you're right. This is good as is.

💬 Retropex commented on pull request "util: Replace std::filesystem with util/fs.h":
(https://github.com/bitcoin/bitcoin/pull/28076#issuecomment-1818736154)
The integration of Rust into Core, further increases the technical debt. Each person's ability to run tests locally is essential, and relying on CIs to manage Rust code is not a viable solution. In addition, introducing Rust can encourage the addition of other languages, risking fragmenting and further complicating the code base.

📝 hethm999 opened a pull request: "Update SECURITY.md"
(https://github.com/bitcoin/bitcoin/pull/28915)
ايلون ماسك رموزات مميزة بملايين البيتكوين ولم تتجاوب معي

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
signif
...

✅ fanquake closed a pull request: "Update SECURITY.md"
(https://github.com/bitcoin/bitcoin/pull/28915)

📝 fanquake locked a pull request: "Update SECURITY.md"
(https://github.com/bitcoin/bitcoin/pull/28915)
ايلون ماسك رموزات مميزة بملايين البيتكوين ولم تتجاوب معي

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
signif
...

⚠️ hethm999 opened an issue: "<!--e57a25ab6845829454e8d69fc972939a-->"
(https://github.com/bitcoin/bitcoin/issues/28916)
<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--006a51241073e994b41acfe9ec718e94-->
### Code Coverage
For detailed information about the code coverage, see the [test coverage report](https://corecheck.dev/bitcoin/bitcoin/pulls/28915).
<!--021abf342d371248e50ceaed478a90ca-->
### Reviews
See [the guideline](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#co
...

💬 hethm999 commented on issue "RAM usage regression in 26.x and master on ARM 32-bit":
(https://github.com/bitcoin/bitcoin/issues/28906#issuecomment-1818764628)
> ### هل هناك مشكلة موجودة لهذا؟
> * [x] لقد بحثت في القضايا الموجودة
>
> ### السلوك الحالي
> فشل الأمر `bitcoind -dbcache=100 -par=4 -disablewallet -reindex-chainstate`مع OOM. ورد لأول مرة في [رقم 28718 (تعليق)](https://github.com/bitcoin/bitcoin/issues/28718#issuecomment-1807197107) .
>
> ### سلوك متوقع
> استخدام ذاكرة الوصول العشوائي لا يتجاوز 0.9 جيجابايت.
>
> ### خطوات التكاثر
> إمكانية تكرار نتائج بنسبة 100% باستخدام الثنائيات المجمعة من Guix.
>
> ### إخراج السجل ذي الصلة

...

✅ fanquake closed an issue: "<!--e57a25ab6845829454e8d69fc972939a-->"
(https://github.com/bitcoin/bitcoin/issues/28916)

:lock: fanquake locked an issue: "<!--e57a25ab6845829454e8d69fc972939a-->"
(https://github.com/bitcoin/bitcoin/issues/28916)

💬 martinus commented on pull request "coins: make sure PoolAllocator uses the correct alignment":
(https://github.com/bitcoin/bitcoin/pull/28913#issuecomment-1818769524)
@pinheadmz I don't think there's a need to test any any RPC calls, if sync doesn't go OOM it means it is now working :)

💬 TheCharlatan commented on pull request "lint: Report all lint errors instead of early exit":
(https://github.com/bitcoin/bitcoin/pull/28862#discussion_r1398979031)
It's a bit jarring to see `Err("")`, but I guess there is little point in adding a parser for the script output, or duplicating the failure reporting, so this can just be improved if/when the lint checks are converted to Rust.

💬 maflcko commented on pull request "util: Replace std::filesystem with util/fs.h":
(https://github.com/bitcoin/bitcoin/pull/28076#issuecomment-1818774328)
> relying on CIs

This pull request does not change how much CI is relied upon. Previously, CI was running on all patches, and it is still after this pull request. Previously, it was possible to run any CI task locally, and it is still possible, in the same way. I am running the CI locally regularly and it obviously helps if others do the same. If you have issues running anything locally, it would be good to open an issue, so that it can be fixed. When filing an issue, adding context which doc
...

👍 TheCharlatan approved a pull request: "lint: Report all lint errors instead of early exit"
(https://github.com/bitcoin/bitcoin/pull/28862#pullrequestreview-1739454098)
lgtm ACK fa01f884d3ac128f09bfa57ac2648a19a19d854e

I checked that the CI can now correctly report multiple lint failures.