💬 TheCharlatan commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1128733941)
Thanks, updated. [Diff](https://github.com/TheCharlatan/bitcoin/compare/tc/2022-09-libbitcoinkernel-chainparams-args_1..tc/2022-09-libbitcoinkernel-chainparams-args_2)

💬 TheCharlatan commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1128734106)
This is no longer relevant.

👋 furszy's pull request is ready for review: "wallet: return error msg for "too-long-mempool-chain""
(https://github.com/bitcoin/bitcoin/pull/24845)

💬 achow101 commented on pull request "assumeutxo: background validation completion":
(https://github.com/bitcoin/bitcoin/pull/25740#issuecomment-1459034880)
ACK 2b373fe49d64f04ceab2309d3f40da7bac6b37d6

🚀 achow101 merged a pull request: "assumeutxo: background validation completion"
(https://github.com/bitcoin/bitcoin/pull/25740)

💬 Ayms commented on issue "Allow several OP_RETURN in one tx and no limited size":
(https://github.com/bitcoin/bitcoin/issues/27043#issuecomment-1459082149)
@junderw thanks for the tip, I know C/C++ in fact, but I don't consider to be an expert, probably you can yourself fix the wasm stuff for Tor Rust

@ChristopherA the change is trivial as you know, would take 5mn for an expert if I were to do it in my area, and for free, good to see that there is some founding proposal, but, really, in a worldwide important project like bitcoin, nobody can do this without adding founding to founding?

💬 ChristopherA commented on issue "Allow several OP_RETURN in one tx and no limited size":
(https://github.com/bitcoin/bitcoin/issues/27043#issuecomment-1459142342)
@Ayms The change to the C++ code core is fairly trivial, but for the PR to be acceptable, it must have the test frameworks changed for it, which is less so as they are in Python. I've not touched that for years, and I don't have a current build environment.

It should, however, be a relatively easy first contribution for someone who wants to learn how to do bitcoin core contributions.

💬 johnny9 commented on pull request "Update chainparams for 25.x":
(https://github.com/bitcoin/bitcoin/pull/27223#issuecomment-1459160020)
Closing for now, will reopen closer to branch off

✅ johnny9 closed a pull request: "Update chainparams for 25.x"
(https://github.com/bitcoin/bitcoin/pull/27223)

💬 TheCharlatan commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#issuecomment-1459660428)
Updated 067b727a9741ddabf44f6efd5125a9c8fbea0702 -> f9e3c91f4d482b0c74ef899056d5a2c63e67e1fb ([tc/2022-09-libbitcoinkernel-chainparams-args_2](https://github.com/TheCharlatan/bitcoin/commits/tc/2022-09-libbitcoinkernel-chainparams-args_2) -> [tc/2022-09-libbitcoinkernel-chainparams-args_3](https://github.com/TheCharlatan/bitcoin/commits/tc/2022-09-libbitcoinkernel-chainparams-args_3), [compare](https://github.com/TheCharlatan/bitcoin/compare/tc/2022-09-libbitcoinkernel-chainparams-args_2..tc/202
...

💬 S3RK commented on pull request "doc: DummySignInput mention external signer":
(https://github.com/bitcoin/bitcoin/pull/27180#issuecomment-1459663212)
ACK 6fc5f4fdb661eb9d42842227501106afcf7111e7

The comment is correct, CI failure is unrelated

💬 S3RK commented on pull request "wallet: return error msg for "too-long-mempool-chain"":
(https://github.com/bitcoin/bitcoin/pull/24845#discussion_r1129067658)
Just because these UTXOs are available it doesn't mean that including them would cover required amount.

For example let's imaging you have two coins in a wallet:
- 48 BTC with 6 confirmation
- 1 BTC with long unconfirmed ancestry

If you try to send 50 BTC you should get "insufficient funds" error, but IIUC after this PR you'll get "Unconfirmed UTXOs are available..." which is unrelated.

🚀 fanquake merged a pull request: "util: Use steady clock in SeedStrengthen, FindBestImplementation, FlushStateToDisk"
(https://github.com/bitcoin/bitcoin/pull/27189)

🚀 fanquake merged a pull request: "doc: DummySignInput mention external signer"
(https://github.com/bitcoin/bitcoin/pull/27180)

💬 fanquake commented on issue "Issue in `p2p_ibd_stalling.py` under Valgrind":
(https://github.com/bitcoin/bitcoin/issues/27208#issuecomment-1459681907)
Log after running with #27221:
```bash
............................................................................................... 162/256 - p2p_ibd_stalling.py failed, Duration: 126 s

stdout:
2023-03-08T04:33:24.745000Z TestFramework (INFO): PRNG seed is: 3703385557670057473
2023-03-08T04:33:24.745000Z TestFramework (INFO): Initializing test directory /home/ubuntu/ci_scratch/ci/s
...

💬 fanquake commented on pull request "test: Default timeout factor to 4 under --valgrind":
(https://github.com/bitcoin/bitcoin/pull/27221#issuecomment-1459683010)
I'm still seeing #27208 with this change (fa27cf4cc7c24aa00a66dffabab849d4b3cb1c41). See [here for the full combined log](https://github.com/bitcoin/bitcoin/issues/27208#issuecomment-1459681907):
```bash
...............................................................................................
162/256 - p2p_ibd_stalling.py failed, Duration: 126 s

stdout:
2023-03-08T04:33:24.745000Z TestFramework (INFO): PRNG seed is: 3703385557670057473
2023-03-08T04:33:24.745000Z TestFramework (INF
...

🚀 fanquake merged a pull request: "doc: Fixup remove 'omitted...' doc for rpc getrawtransaction when verbose is 2"
(https://github.com/bitcoin/bitcoin/pull/26968)

👍 fanquake approved a pull request: "doc: Show how less noisy clang-tidy output can be achieved"
(https://github.com/bitcoin/bitcoin/pull/27205)
ACK 6a29f34ac0afce501af45097916256a9bffe8d19 - seems fine.

💬 fanquake commented on pull request "doc: update broken str util reference links on developer-notes":
(https://github.com/bitcoin/bitcoin/pull/27220#discussion_r1129081443)
You could put this on a new line, rather than making this one ridiculously long.

💬 MarcoFalke commented on pull request "doc: update broken str util reference links on developer-notes":
(https://github.com/bitcoin/bitcoin/pull/27220#discussion_r1129089643)
ParseInt* is for legacy code only, as well