👍 stickies-v approved a pull request: "doc: Fixup remove 'omitted...' doc for rpc getrawtransaction when verbose is 2"
(https://github.com/bitcoin/bitcoin/pull/26968)
ACK 3e947d7117c97a3cc34cfa7e1f5515fa0192fbe7
---
_Note: I'm glad that this is now in good shape, but for full transparency: to me this was a very frustrating review process and even though I hold no personal grudges over it, this will likely affect my enthusiasm towards reviewing your future work and for that reason I want to be transparent and share my feedback with you. I spent a lot of time writing out my thoughts and reasoning with links etc across multiple reviews, and yet every addit
...
(https://github.com/bitcoin/bitcoin/pull/26968)
ACK 3e947d7117c97a3cc34cfa7e1f5515fa0192fbe7
---
_Note: I'm glad that this is now in good shape, but for full transparency: to me this was a very frustrating review process and even though I hold no personal grudges over it, this will likely affect my enthusiasm towards reviewing your future work and for that reason I want to be transparent and share my feedback with you. I spent a lot of time writing out my thoughts and reasoning with links etc across multiple reviews, and yet every addit
...
💬 willcl-ark commented on issue "Call interfaces::Wallet::getWalletTxs asynchronous":
(https://github.com/bitcoin/bitcoin/issues/20241#issuecomment-1458947123)
@hebasto is it worth moving this issue to the GUI repo?
(https://github.com/bitcoin/bitcoin/issues/20241#issuecomment-1458947123)
@hebasto is it worth moving this issue to the GUI repo?
💬 ChristopherA commented on issue "Allow several OP_RETURN in one tx and no limited size":
(https://github.com/bitcoin/bitcoin/issues/27043#issuecomment-1458955465)
Blockchain Commons would be glad to contribute US$1K (paid in BTC) towards a joint bounty with others to see this as a PR with the core changes and a testing harness. Who else will contribute to the pot?
(https://github.com/bitcoin/bitcoin/issues/27043#issuecomment-1458955465)
Blockchain Commons would be glad to contribute US$1K (paid in BTC) towards a joint bounty with others to see this as a PR with the core changes and a testing harness. Who else will contribute to the pot?
💬 amitiuttarwar commented on pull request "addrman: Enable selecting addresses by network":
(https://github.com/bitcoin/bitcoin/pull/27214#discussion_r1128704427)
ah, it looks like those changes would remove the need for this helper?
(https://github.com/bitcoin/bitcoin/pull/27214#discussion_r1128704427)
ah, it looks like those changes would remove the need for this helper?
💬 amitiuttarwar commented on pull request "addrman: Enable selecting addresses by network":
(https://github.com/bitcoin/bitcoin/pull/27214#discussion_r1128705089)
good catch, updated. also realized there were stale comments in the addrman unit test, so updated those too.
(https://github.com/bitcoin/bitcoin/pull/27214#discussion_r1128705089)
good catch, updated. also realized there were stale comments in the addrman unit test, so updated those too.
💬 ishaanam commented on pull request "doc: DummySignInput mention external signer":
(https://github.com/bitcoin/bitcoin/pull/27180#issuecomment-1459001154)
ACK 6fc5f4fdb661eb9d42842227501106afcf7111e7
(https://github.com/bitcoin/bitcoin/pull/27180#issuecomment-1459001154)
ACK 6fc5f4fdb661eb9d42842227501106afcf7111e7
💬 TheCharlatan commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#issuecomment-1459021969)
> The last 3 commits seem more half-baked to me, and might be better to split off.
Ok, I kept the 5th commit, "split non/kernel chainparamsbase", but limited the best to just moving the declaration of the `CBaseChainParams` class to the kernel. I also dropped the 7th commit "wrap kernel chainparamsbase functions in kernel namespace".
Updated 65d026b47270c2fb9d2dab7f3d448b4abc37b93a -> 067b727a9741ddabf44f6efd5125a9c8fbea0702 ([tc/2022-09-libbitcoinkernel-chainparams-args_1](https://githu
...
(https://github.com/bitcoin/bitcoin/pull/26177#issuecomment-1459021969)
> The last 3 commits seem more half-baked to me, and might be better to split off.
Ok, I kept the 5th commit, "split non/kernel chainparamsbase", but limited the best to just moving the declaration of the `CBaseChainParams` class to the kernel. I also dropped the 7th commit "wrap kernel chainparamsbase functions in kernel namespace".
Updated 65d026b47270c2fb9d2dab7f3d448b4abc37b93a -> 067b727a9741ddabf44f6efd5125a9c8fbea0702 ([tc/2022-09-libbitcoinkernel-chainparams-args_1](https://githu
...
💬 TheCharlatan commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1128733941)
Thanks, updated. [Diff](https://github.com/TheCharlatan/bitcoin/compare/tc/2022-09-libbitcoinkernel-chainparams-args_1..tc/2022-09-libbitcoinkernel-chainparams-args_2)
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1128733941)
Thanks, updated. [Diff](https://github.com/TheCharlatan/bitcoin/compare/tc/2022-09-libbitcoinkernel-chainparams-args_1..tc/2022-09-libbitcoinkernel-chainparams-args_2)
💬 TheCharlatan commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1128734106)
This is no longer relevant.
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1128734106)
This is no longer relevant.
👋 furszy's pull request is ready for review: "wallet: return error msg for "too-long-mempool-chain""
(https://github.com/bitcoin/bitcoin/pull/24845)
(https://github.com/bitcoin/bitcoin/pull/24845)
💬 achow101 commented on pull request "assumeutxo: background validation completion":
(https://github.com/bitcoin/bitcoin/pull/25740#issuecomment-1459034880)
ACK 2b373fe49d64f04ceab2309d3f40da7bac6b37d6
(https://github.com/bitcoin/bitcoin/pull/25740#issuecomment-1459034880)
ACK 2b373fe49d64f04ceab2309d3f40da7bac6b37d6
🚀 achow101 merged a pull request: "assumeutxo: background validation completion"
(https://github.com/bitcoin/bitcoin/pull/25740)
(https://github.com/bitcoin/bitcoin/pull/25740)
💬 Ayms commented on issue "Allow several OP_RETURN in one tx and no limited size":
(https://github.com/bitcoin/bitcoin/issues/27043#issuecomment-1459082149)
@junderw thanks for the tip, I know C/C++ in fact, but I don't consider to be an expert, probably you can yourself fix the wasm stuff for Tor Rust
@ChristopherA the change is trivial as you know, would take 5mn for an expert if I were to do it in my area, and for free, good to see that there is some founding proposal, but, really, in a worldwide important project like bitcoin, nobody can do this without adding founding to founding?
(https://github.com/bitcoin/bitcoin/issues/27043#issuecomment-1459082149)
@junderw thanks for the tip, I know C/C++ in fact, but I don't consider to be an expert, probably you can yourself fix the wasm stuff for Tor Rust
@ChristopherA the change is trivial as you know, would take 5mn for an expert if I were to do it in my area, and for free, good to see that there is some founding proposal, but, really, in a worldwide important project like bitcoin, nobody can do this without adding founding to founding?
💬 ChristopherA commented on issue "Allow several OP_RETURN in one tx and no limited size":
(https://github.com/bitcoin/bitcoin/issues/27043#issuecomment-1459142342)
@Ayms The change to the C++ code core is fairly trivial, but for the PR to be acceptable, it must have the test frameworks changed for it, which is less so as they are in Python. I've not touched that for years, and I don't have a current build environment.
It should, however, be a relatively easy first contribution for someone who wants to learn how to do bitcoin core contributions.
(https://github.com/bitcoin/bitcoin/issues/27043#issuecomment-1459142342)
@Ayms The change to the C++ code core is fairly trivial, but for the PR to be acceptable, it must have the test frameworks changed for it, which is less so as they are in Python. I've not touched that for years, and I don't have a current build environment.
It should, however, be a relatively easy first contribution for someone who wants to learn how to do bitcoin core contributions.
💬 johnny9 commented on pull request "Update chainparams for 25.x":
(https://github.com/bitcoin/bitcoin/pull/27223#issuecomment-1459160020)
Closing for now, will reopen closer to branch off
(https://github.com/bitcoin/bitcoin/pull/27223#issuecomment-1459160020)
Closing for now, will reopen closer to branch off
✅ johnny9 closed a pull request: "Update chainparams for 25.x"
(https://github.com/bitcoin/bitcoin/pull/27223)
(https://github.com/bitcoin/bitcoin/pull/27223)
💬 TheCharlatan commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#issuecomment-1459660428)
Updated 067b727a9741ddabf44f6efd5125a9c8fbea0702 -> f9e3c91f4d482b0c74ef899056d5a2c63e67e1fb ([tc/2022-09-libbitcoinkernel-chainparams-args_2](https://github.com/TheCharlatan/bitcoin/commits/tc/2022-09-libbitcoinkernel-chainparams-args_2) -> [tc/2022-09-libbitcoinkernel-chainparams-args_3](https://github.com/TheCharlatan/bitcoin/commits/tc/2022-09-libbitcoinkernel-chainparams-args_3), [compare](https://github.com/TheCharlatan/bitcoin/compare/tc/2022-09-libbitcoinkernel-chainparams-args_2..tc/202
...
(https://github.com/bitcoin/bitcoin/pull/26177#issuecomment-1459660428)
Updated 067b727a9741ddabf44f6efd5125a9c8fbea0702 -> f9e3c91f4d482b0c74ef899056d5a2c63e67e1fb ([tc/2022-09-libbitcoinkernel-chainparams-args_2](https://github.com/TheCharlatan/bitcoin/commits/tc/2022-09-libbitcoinkernel-chainparams-args_2) -> [tc/2022-09-libbitcoinkernel-chainparams-args_3](https://github.com/TheCharlatan/bitcoin/commits/tc/2022-09-libbitcoinkernel-chainparams-args_3), [compare](https://github.com/TheCharlatan/bitcoin/compare/tc/2022-09-libbitcoinkernel-chainparams-args_2..tc/202
...
💬 S3RK commented on pull request "doc: DummySignInput mention external signer":
(https://github.com/bitcoin/bitcoin/pull/27180#issuecomment-1459663212)
ACK 6fc5f4fdb661eb9d42842227501106afcf7111e7
The comment is correct, CI failure is unrelated
(https://github.com/bitcoin/bitcoin/pull/27180#issuecomment-1459663212)
ACK 6fc5f4fdb661eb9d42842227501106afcf7111e7
The comment is correct, CI failure is unrelated
💬 S3RK commented on pull request "wallet: return error msg for "too-long-mempool-chain"":
(https://github.com/bitcoin/bitcoin/pull/24845#discussion_r1129067658)
Just because these UTXOs are available it doesn't mean that including them would cover required amount.
For example let's imaging you have two coins in a wallet:
- 48 BTC with 6 confirmation
- 1 BTC with long unconfirmed ancestry
If you try to send 50 BTC you should get "insufficient funds" error, but IIUC after this PR you'll get "Unconfirmed UTXOs are available..." which is unrelated.
(https://github.com/bitcoin/bitcoin/pull/24845#discussion_r1129067658)
Just because these UTXOs are available it doesn't mean that including them would cover required amount.
For example let's imaging you have two coins in a wallet:
- 48 BTC with 6 confirmation
- 1 BTC with long unconfirmed ancestry
If you try to send 50 BTC you should get "insufficient funds" error, but IIUC after this PR you'll get "Unconfirmed UTXOs are available..." which is unrelated.
🚀 fanquake merged a pull request: "util: Use steady clock in SeedStrengthen, FindBestImplementation, FlushStateToDisk"
(https://github.com/bitcoin/bitcoin/pull/27189)
(https://github.com/bitcoin/bitcoin/pull/27189)