💬 achow101 commented on issue "`combinepsbt` RPC does not work with P2TR inputs":
(https://github.com/bitcoin/bitcoin/issues/27219#issuecomment-1458453570)
Yes, it is a bug in signing, not in combining.

💬 MarcoFalke commented on pull request "test: Log when LongpollThread is ending":
(https://github.com/bitcoin/bitcoin/pull/26996#issuecomment-1458464523)
Sorry, this slipped the inbox. I'll reply to the feedback

💬 MarcoFalke commented on pull request "test: Log when LongpollThread is ending":
(https://github.com/bitcoin/bitcoin/pull/26996#issuecomment-1458467484)
> Is there an example where logging the end of a thread in such a way could offer an advantage during debugging?

Good point. It probably doesn't. It should already be clear from the assertion being hit (or not being hit) whether the thread exited or not.

⚠️ MarcoFalke opened an issue: "test: use-of-uninitialized-value in sqlite3Strlen30"
(https://github.com/bitcoin/bitcoin/issues/27222)
https://cirrus-ci.com/task/5021971277152256?logs=ci#L3656

```
wallet/test/feebumper_tests.cpp(18): Entering test suite "feebumper_tests"
wallet/test/feebumper_tests.cpp(42): Entering test case "external_max_weight_test"
2023-01-30T17:19:34Z Seed: Setting random seed for current tests to RANDOM_CTX_SEED=231d587d0169ecab6befbed75f49c95aa84567b2750479dca13bd7471f2627e2
2023-01-30T17:19:34.255341Z [test] [init/common.cpp:149] [LogPackageVersion] Bitcoin Core version v24.99.0-a55717c914f8 (rel
...

💬 MarcoFalke commented on issue "test: use-of-uninitialized-value in sqlite3Strlen30":
(https://github.com/bitcoin/bitcoin/issues/27222#issuecomment-1458484442)
For reference, the path seems to be `""` (empty string), but that shouldn't be an issue?

💬 MarcoFalke commented on issue "IBD slowed down by failing to deal with a bad checksum block message":
(https://github.com/bitcoin/bitcoin/issues/18755#issuecomment-1458493054)
Can be re-opened if this is confirmed to be happening on a recent vanilla release of Bitcoin Core. Bonus points will be assigned for steps to reproduce.

✅ MarcoFalke closed an issue: "IBD slowed down by failing to deal with a bad checksum block message"
(https://github.com/bitcoin/bitcoin/issues/18755)

💬 pinheadmz commented on issue "Potential data race on fHavePruned flag":
(https://github.com/bitcoin/bitcoin/issues/21627#issuecomment-1458495557)
I think this issue can be closed, `fHavePruned` seems to have been replaced with `chainman().m_blockman.m_have_pruned` (etc) and looks to me like all the setters (e.g. `FlushStateToDisk()`) have appropriate locks

💬 MarcoFalke commented on pull request "test: Flatten miniwallet array and remove random fee in longpoll":
(https://github.com/bitcoin/bitcoin/pull/26996#discussion_r1128202695)
Thanks, dropped the commit

💬 MarcoFalke commented on pull request "test: Flatten miniwallet array and remove random fee in longpoll":
(https://github.com/bitcoin/bitcoin/pull/26996#discussion_r1128202898)
Thanks, dropped the commit

👋 Sjors's pull request is ready for review: "wallet: 26032 followups"
(https://github.com/bitcoin/bitcoin/pull/27180)

💬 Sjors commented on pull request "wallet: 26032 followups":
(https://github.com/bitcoin/bitcoin/pull/27180#issuecomment-1458502104)
Not really I guess...

💬 MarcoFalke commented on issue "Potential data race on fHavePruned flag":
(https://github.com/bitcoin/bitcoin/issues/21627#issuecomment-1458503844)
The variable was only renamed, so the issue may still exist.

💬 pinheadmz commented on issue "invalidateblock when processing blocks on disk":
(https://github.com/bitcoin/bitcoin/issues/18978#issuecomment-1458530587)
@mrbianchi is this still an issue for you? I'm curious why you would want to cancel reindex? What can you do with your node in that state?

💬 MarcoFalke commented on issue "invalidateblock when processing blocks on disk":
(https://github.com/bitcoin/bitcoin/issues/18978#issuecomment-1458545863)
Closing for now

✅ MarcoFalke closed an issue: "invalidateblock when processing blocks on disk"
(https://github.com/bitcoin/bitcoin/issues/18978)

💬 jonatack commented on pull request "bench: update logging benchmarks":
(https://github.com/bitcoin/bitcoin/pull/26957#discussion_r1128257451)
Done, thank you @MarcoFalke and @LarryRuane.

💬 jonatack commented on pull request "bench: update logging benchmarks":
(https://github.com/bitcoin/bitcoin/pull/26957#discussion_r1128257756)
Done, thank you @fanquake, the diffs are much smaller now.

(Also dropped the category change, as it didn't make sense with an unordered map.)

💬 brunoerg commented on pull request "addrman: Enable selecting addresses by network":
(https://github.com/bitcoin/bitcoin/pull/27214#discussion_r1128258413)
Interesting, perhaps #26261 would be a good fit :)

💬 ryanofsky commented on pull request "wallet: Turn `destdata` entries into `CAddressBookData` fields":
(https://github.com/bitcoin/bitcoin/pull/27215#discussion_r1128178482)
In commit "wallet: Store "receive requests" as its own member" (2e7751def15fe430daf6c8bea7fca31ff49f71d9)

Does this work? It seems possibly broken because it will only erase keys that are literally the string "rr", not receive requests that begin with `"rr"` and are followed by a request id

In 7a05b1dee2fa68b32bfb19e273fb55a5b3836a3e from #18608 I had to deal with this problem by creating an `ErasePrefix` function, and I also added unit tests to verify the code worked.