💬 hebasto commented on pull request "build: Patch Qt to handle minimum macOS version properly":
(https://github.com/bitcoin/bitcoin/pull/28775#issuecomment-1792023227)
> In that case, maybe it would be easier to set something like `-DOS_ACTIVITY_OBJECT_API=1` for the Qt build, and not have to patch any source?

I think it will hit
```
#error Please change your minimum OS requirements because OS_ACTIVITY_OBJECT_API is not available
```

> Native builds (using the latest Xcode) are not broken in this way, and the minimum version handling shouldn't differ between the two?

I've verified the native build on macOS 14.1 without depends. Both macros are defi
...

💬 maflcko commented on pull request "Avoid returning references to mutex guarded members":
(https://github.com/bitcoin/bitcoin/pull/28774#issuecomment-1792035522)
No write will happen to the datadir cache after the first write, and no reader will have the reference before the first write, no? I am trying to say that the current code is fine. Otherwise, it would be good to add steps to reproduce UB.

No objection to changing the code, but if this is worth it to change, it should be done for all places in the whole codebase, not just some places.

📝 hebasto converted_to_draft a pull request: "build: Patch Qt to handle minimum macOS version properly"
(https://github.com/bitcoin/bitcoin/pull/28775)
This PR is:
- required to [switch](https://github.com/bitcoin/bitcoin/pull/28622) to macOS 14 SDK (Xcode 15).
- an alternative to https://github.com/bitcoin/bitcoin/pull/28732.

📝 BrandonOdiwuor opened a pull request: "gui: add used balance to overview page"
(https://github.com/bitcoin-core/gui/pull/775)
**Second part** of solving https://github.com/bitcoin-core/gui/issues/769

Add used balance to the overview page for wallets with the avoid_reuse flag enabled

### Prerequsite:

- **Part one**: https://github.com/bitcoin/bitcoin/pull/28776

overview page when avoid_reuse is enabled

overview page when avoid_reuse is not enabled
![Screenshot from 2023-11-03
...

💬 BrandonOdiwuor commented on issue "`used` balance should be shown on overview page":
(https://github.com/bitcoin-core/gui/issues/769#issuecomment-1792061121)
Created two PRs on this issue:

- Part one: https://github.com/bitcoin/bitcoin/pull/28776
- Part two: https://github.com/bitcoin-core/gui/pull/775

💬 glozow commented on pull request "refactors for subpackage evaluation":
(https://github.com/bitcoin/bitcoin/pull/28758#discussion_r1381323292)
I don't think it's that helpful to list more things this function *doesn't* check.

👋 hebasto's pull request is ready for review: "build: Patch Qt to handle minimum macOS version properly"
(https://github.com/bitcoin/bitcoin/pull/28775)

💬 maflcko commented on pull request "refactor: Remove unused SER_DISK, SER_NETWORK, SER_GETHASH":
(https://github.com/bitcoin/bitcoin/pull/28451#issuecomment-1792178673)
Please review https://github.com/bitcoin/bitcoin/pull/28438 (Use serialization parameters for CTransaction by ajtowns) first.

💬 hebasto commented on pull request "build: use macOS 14 SDK (Xcode 15.0)":
(https://github.com/bitcoin/bitcoin/pull/28622#issuecomment-1792179529)
> > The following patch fixes the Qt build for me:
>
> We wont be taking that patch, but if the problem is that qt fails to respect `-mmacosx-version-min` for some reason, I would assume that should make it fairly obvious where the problem is.

Apparently, direct tests show that `env -u C_INCLUDE_PATH -u CPLUS_INCLUDE_PATH -u OBJC_INCLUDE_PATH -u OBJCPLUS_INCLUDE_PATH -u CPATH -u LIBRARY_PATH /home/hebasto/git/bitcoin/depends/x86_64-apple-darwin/native/bin/clang++ --target=x86_64-apple-darw
...

💬 glozow commented on pull request "MiniMiner changes for package linearization":
(https://github.com/bitcoin/bitcoin/pull/28762#discussion_r1381447100)
added a refactor commit to pull fee amounts into constants

💬 glozow commented on pull request "MiniMiner changes for package linearization":
(https://github.com/bitcoin/bitcoin/pull/28762#discussion_r1381447239)
done

💬 glozow commented on pull request "MiniMiner changes for package linearization":
(https://github.com/bitcoin/bitcoin/pull/28762#discussion_r1381447982)
Done, and updated the expected boost includes for the linter. Unsure if it's preferred to omit those...?

💬 glozow commented on pull request "MiniMiner changes for package linearization":
(https://github.com/bitcoin/bitcoin/pull/28762#discussion_r1381448280)
leaving it as is :sweat_smile:

💬 TheCharlatan commented on pull request "refactor: Simplify CTxMempool/BlockAssembler fields, remove some external mapTx access":
(https://github.com/bitcoin/bitcoin/pull/28391#issuecomment-1792187238)
Updated 105a0f4db4ffdc25d3ad30300c949d46d5d8e647 -> 65839d6267af1f5e0e04aded72cbfa23b56a1237 ([simplifyMemPoolInteractions_4](https://github.com/TheCharlatan/bitcoin/tree/simplifyMemPoolInteractions_4) -> [simplifyMemPoolInteractions_5](https://github.com/TheCharlatan/bitcoin/tree/simplifyMemPoolInteractions_5), [compare](https://github.com/TheCharlatan/bitcoin/compare/simplifyMemPoolInteractions_4..simplifyMemPoolInteractions_5))

* Addressed @ismaelsadeeq's [comment](https://github.com/bitc
...

💬 hebasto commented on pull request "build: use macOS 14 SDK (Xcode 15.0)":
(https://github.com/bitcoin/bitcoin/pull/28622#discussion_r1381461570)
According to https://developer.apple.com/support/xcode/, additionally, `OSX_MIN_VERSION=13.5` should be adjusted as well.

💬 stratospher commented on pull request "test/BIP324: functional tests for v2 P2P encryption":
(https://github.com/bitcoin/bitcoin/pull/24748#issuecomment-1792201473)
Rebased on master.

💬 Sun0fABeach commented on pull request "datacarriersize: Match more datacarrying":
(https://github.com/bitcoin/bitcoin/pull/28408#issuecomment-1792205732)
Concept ACK

Node runners need a builtin option to ignore all modern forms of datacarrying so they don't have to resort to manually patching their nodes.

... and the 'censorship' framing is getting old by now and has been rebutted often enough. If you really hold these principles, then please remove all your email spam filters. Otherwise you're engaging in censorship of a permissionless protocol and thereby impairing an important source of revenue for network users.

👍 dergoegge approved a pull request: "refactors for subpackage evaluation"
(https://github.com/bitcoin/bitcoin/pull/28758#pullrequestreview-1712337150)
Code review ACK b5a60abe8783852f5b31bc1e63b5836530410e65

nit: the commit message in da9aceba217bbded6909f06144eaa1e1a4ebcb69 still has the old names

👍 dergoegge approved a pull request: "Fuzz: Check individual and package transaction invariants"
(https://github.com/bitcoin/bitcoin/pull/28764#pullrequestreview-1712356208)
ACK fcb3069fa307942cf7f3edabcda1be96d615c91f

📝 fanquake opened a pull request: "depends: latest config.guess & config.sub"
(https://github.com/bitcoin/bitcoin/pull/28781)
Before we make any local modifications (i.e #28733) pull the latest files from upstream.