💬 pinheadmz commented on pull request "Add wallet method to detect if a key is "fresh"":
(https://github.com/bitcoin/bitcoin/pull/27216#discussion_r1128006272)
oooh thanks, didn't realize those comments were parsed by anything!

👍 willcl-ark approved a pull request: "util: Use steady clock in SeedStrengthen, FindBestImplementation, FlushStateToDisk"
(https://github.com/bitcoin/bitcoin/pull/27189)
ACK fa1b4e5c3

💬 TheCharlatan commented on pull request "refactor: Split util/system into exception, shell, and fs-specific files":
(https://github.com/bitcoin/bitcoin/pull/25152#issuecomment-1458326647)
I redid this work (fixing more of the includes and splitting out a few more functions) and have a branch over here: https://github.com/TheCharlatan/bitcoin/pull/10

@Empact I'm still keen on moving this work forward. If you don't have the time right now, I'll attribute the commits to you and try to get my branch merged instead.

💬 pinheadmz commented on issue "bumpfee RPC not working as expected since 0.19.0.1":
(https://github.com/bitcoin/bitcoin/issues/18240#issuecomment-1458349062)
@yurayakimenko is this still a problem for you?

💬 sipa commented on pull request "util: Use steady clock in SeedStrengthen, FindBestImplementation, FlushStateToDisk":
(https://github.com/bitcoin/bitcoin/pull/27189#issuecomment-1458356777)
Concept ACK

👍 christ79ma approved a pull request: "refactor: Split util/system into exception, shell, and fs-specific files"
(https://github.com/bitcoin/bitcoin/pull/25152)

💬 pinheadmz commented on issue "Assertion failed! rpcwallet.cpp Line 3838":
(https://github.com/bitcoin/bitcoin/issues/18944#issuecomment-1458360103)
I think this issue can be closed. In addition to #18974 the assertion has been replaced with a much safer check:

https://github.com/bitcoin/bitcoin/blob/d4ebdceaef130e4b68e5d5db67eecfefd24b4239/src/wallet/rpc/addresses.cpp#L668-L674

💬 MarcoFalke commented on issue "Assertion failed! rpcwallet.cpp Line 3838":
(https://github.com/bitcoin/bitcoin/issues/18944#issuecomment-1458386274)
yeah, `CHECK_NONFATAL` doesn't crash the program, but it also aborts the current RPC

💬 MarcoFalke commented on issue "Assertion failed! rpcwallet.cpp Line 3838":
(https://github.com/bitcoin/bitcoin/issues/18944#issuecomment-1458387054)
It would be good to know if this is still an issue with a recent version of Bitcoin Core?

💬 yurayakimenko commented on issue "bumpfee RPC not working as expected since 0.19.0.1":
(https://github.com/bitcoin/bitcoin/issues/18240#issuecomment-1458387690)
@pinheadmz No, this problem was resolved. Thanks a lot!

✅ MarcoFalke closed an issue: "bumpfee RPC not working as expected since 0.19.0.1"
(https://github.com/bitcoin/bitcoin/issues/18240)

💬 achow101 commented on pull request "wallet: Turn `destdata` entries into `CAddressBookData` fields":
(https://github.com/bitcoin/bitcoin/pull/27215#discussion_r1128100527)
Made it a reference

💬 achow101 commented on pull request "wallet: Replace use of purpose strings with an enum":
(https://github.com/bitcoin/bitcoin/pull/27217#discussion_r1128102630)
Fixed

💬 achow101 commented on pull request "wallet: Replace use of purpose strings with an enum":
(https://github.com/bitcoin/bitcoin/pull/27217#discussion_r1128102852)
Done

💬 achow101 commented on pull request "wallet: Replace use of purpose strings with an enum":
(https://github.com/bitcoin/bitcoin/pull/27217#discussion_r1128103018)
Done

💬 achow101 commented on issue "`combinepsbt` RPC does not work with P2TR inputs":
(https://github.com/bitcoin/bitcoin/issues/27219#issuecomment-1458416545)
The combined PSBT is correctly combined, there are just no signatures in any of the PSBTs. There's nothing to finalize, so it cannot be finalized.

💬 pinheadmz commented on issue "ThreadDNSAddressSeed hangs on sk_wait_data and doesn't stop on exit":
(https://github.com/bitcoin/bitcoin/issues/16778#issuecomment-1458423187)
@Nikolay-Po is this still an issue on the latest release of bitcoin core?

📝 MarcoFalke opened a pull request: "test: Default timeout factor to 4 under --valgrind"
(https://github.com/bitcoin/bitcoin/pull/27221)
valgrind will incur a slowdown of at least 2, so increase the default timeout factor.

This should reduce the number of reported issues. See also https://github.com/bitcoin/bitcoin/issues/27112#issuecomment-1455762739

💬 pinheadmz commented on issue "IBD slowed down by failing to deal with a bad checksum block message":
(https://github.com/bitcoin/bitcoin/issues/18755#issuecomment-1458442569)
I think this was closed by https://github.com/bitcoin/bitcoin/pull/19107. @rebroad are you able to still reproduce this issue with the latest release of Bitcoin Core?

💬 1440000bytes commented on issue "`combinepsbt` RPC does not work with P2TR inputs":
(https://github.com/bitcoin/bitcoin/issues/27219#issuecomment-1458450836)
> The combined PSBT is correctly combined, there are just no signatures in any of the PSBTs. There's nothing to finalize, so it cannot be finalized.

This wasn't don't manually, all PSBTs passed through `walletprocesspsbt`, I used the same code for segwit inputs and it worked. I will re-test everything although fractalcrypt told me this can be fixed with an open PR: https://twitter.com/FractalEncrypt/status/1633073353580859396