💬 fanquake commented on pull request "guix: Zip needs to include all files and set time to SOURCE_DATE_EPOCH":
(https://github.com/bitcoin/bitcoin/pull/28757#issuecomment-1787599465)
Added to #28754.

💬 hebasto commented on issue "macOS: Guix codesigning step broken":
(https://github.com/bitcoin/bitcoin/issues/28756#issuecomment-1787599758)
Close as https://github.com/bitcoin/bitcoin/pull/28757 has just been merged?

✅ fanquake closed an issue: "macOS: Guix codesigning step broken"
(https://github.com/bitcoin/bitcoin/issues/28756)

💬 maflcko commented on issue "Undefined behavior in AutoFile::write (gcc only)":
(https://github.com/bitcoin/bitcoin/issues/28761#issuecomment-1787603064)
I think this is a "bug" in gcc that should be fixed upstream. See also the related discussion in https://reviews.llvm.org/D86993

📝 hebasto opened a pull request: "[26.x] qt: 26.0rc2 translations update"
(https://github.com/bitcoin/bitcoin/pull/28763)
This PR pulls the recent translations from the [Transifex.com](https://www.transifex.com/bitcoin/bitcoin) using the [`bitcoin-maintainer-tools/update-translations.py`](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/main/update-translations.py) tool.

According to our [Release Process docs](https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#before-every-release-candidate), it is supposed to be merged before `v26.0rc2` tagging.

💬 maflcko commented on pull request "build: Require C++20 compiler":
(https://github.com/bitcoin/bitcoin/pull/28349#issuecomment-1787614684)
In any case, it is waiting on guix (see above failure) and the macOS compile failure (Xcode?), so I can't really take it out of draft anyway.

👍 stickies-v approved a pull request: "[26.x] qt: 26.0rc2 translations update"
(https://github.com/bitcoin/bitcoin/pull/28763#pullrequestreview-1706824988)
ACK 1695c4801ccf63d26b6aa802c39019facff04639

Got a zero diff after running [bitcoin-maintainer-tools/update-translations.py](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/main/update-translations.py) - did not do anything else.

💬 achow101 commented on pull request "guix: update signapple to latest master":
(https://github.com/bitcoin/bitcoin/pull/28759#issuecomment-1787623062)
ACK 79539fbfbf4d09a8b4861ddcba5b194297bc1b65

🚀 fanquake merged a pull request: "[26.x] qt: 26.0rc2 translations update"
(https://github.com/bitcoin/bitcoin/pull/28763)

💬 theuni commented on pull request "build: remove duplicate `-lminiupnpc` linking":
(https://github.com/bitcoin/bitcoin/pull/28755#discussion_r1377913811)
I think this is one of those cases where you need the funky xsyntax.

`$have_natpmp` is either "no" or empty. IIRC empty can screw up `test` on some shells.

This is usually avoided by either initializing to something or doing: `if test "x$have_natpmp" != "xno"; then`.

💬 fanquake commented on pull request "build: remove duplicate `-lminiupnpc` linking":
(https://github.com/bitcoin/bitcoin/pull/28755#discussion_r1377915248)
> IIRC empty can screw up test on some shells.

I think bash fixed that in 1996, and we have since removed all the x-prefix usage from our build system. It'd be good to not have to reintroduce it.

💬 theuni commented on pull request "build: remove duplicate `-lminiupnpc` linking":
(https://github.com/bitcoin/bitcoin/pull/28755#discussion_r1377916012)
Same xsyntax thing here, but clearly it's not been an issue. Maybe the quotes are enough.

💬 glozow commented on pull request "MiniMiner changes for package linearization":
(https://github.com/bitcoin/bitcoin/pull/28762#issuecomment-1787632152)
last push changed new instances of uint256 to Txid

💬 theuni commented on pull request "build: remove duplicate `-lminiupnpc` linking":
(https://github.com/bitcoin/bitcoin/pull/28755#discussion_r1377917232)
Lol, you trying to tell me something? :)

👍 theuni approved a pull request: "build: remove duplicate `-lminiupnpc` linking"
(https://github.com/bitcoin/bitcoin/pull/28755#pullrequestreview-1706842520)
ACK b74e449ffa9965f18037f0322ea178e2fe1dbc18

✅ fanquake closed an issue: "guix: prune Rust toolchain boostrap from Darwin HOSTS"
(https://github.com/bitcoin/bitcoin/issues/28449)

🚀 fanquake merged a pull request: "guix: update signapple to latest master"
(https://github.com/bitcoin/bitcoin/pull/28759)

💬 fanquake commented on pull request "guix: update signapple to latest master":
(https://github.com/bitcoin/bitcoin/pull/28759#issuecomment-1787637550)
Added to #28754 for backporting to 26.x.

👋 fanquake's pull request is ready for review: "[26.x] Backports for rc2"
(https://github.com/bitcoin/bitcoin/pull/28754)

💬 fanquake commented on pull request "[26.x] Backports for rc2":
(https://github.com/bitcoin/bitcoin/pull/28754#issuecomment-1787645890)
Added final backports, and bumped version + manpages. We also just merged a translation update, which I rebased this branch on top of.