💬 glozow commented on pull request "validate package transactions with their in-package ancestor sets":
(https://github.com/bitcoin/bitcoin/pull/26711#discussion_r1377711137)
Changed in #28762 to `{fee,vsize}_{self,ancestor}`. Just trying to make them compact-ish

🤔 furszy reviewed a pull request: "p2p: adaptive connections services flags"
(https://github.com/bitcoin/bitcoin/pull/28170#pullrequestreview-1706509820)
Updated per feedback. Thanks again.

* Added coverage for the introduced PeerManager's adaptive connections service flags.
* Renamed StatelessServiceFlags function to SeedsServiceFlags.
* Re-introduced the "initial sync completed" flag update on `UpdatedBlockTip`.
This is to not depend solely on the stale check inside `CheckForStaleTipAndEvictPeers` which is executed every 10 minutes (`STALE_CHECK_INTERVAL`). See code comments for more information.

💬 glozow commented on pull request "validate package transactions with their in-package ancestor sets":
(https://github.com/bitcoin/bitcoin/pull/26711#discussion_r1377713661)
Fees can be negative since we use modified fees, so 0 is not the same thing as turning it off. I've added a comment + test for this in #28762.

💬 glozow commented on pull request "validate package transactions with their in-package ancestor sets":
(https://github.com/bitcoin/bitcoin/pull/26711#issuecomment-1787375144)
> Shouldn't this PR be split up at this point?

Makes sense

> *refactors + test additions that don't change functionality changes (first 3 commits plus CleanupTemporaryCoins?)


^I've split this off into #28758

> [edit: miniminer patch could probably be its own PR too, which would probably be easier to review for people familiar with that particular code but not everything else]

^I've split this off into #28762. I also expanded it into smaller commits, added more tests, and add
...

💬 sr-gi commented on pull request "net: improves addnode / m_added_nodes logic":
(https://github.com/bitcoin/bitcoin/pull/28155#discussion_r1377718949)
That works for me. @jonatack if you add rebase it I'll cherry-pick it again.

💬 toolsopen commented on issue "sendrawtransaction takes too long":
(https://github.com/bitcoin/bitcoin/issues/28745#issuecomment-1787422963)
@maflcko Will wallet.dat 9.3G affect performance? Is there any way to clear the used transactions in it?

👋 fanquake's pull request is ready for review: "guix: update signapple to latest master"
(https://github.com/bitcoin/bitcoin/pull/28759)

💬 fanquake commented on pull request "guix: update signapple to latest master":
(https://github.com/bitcoin/bitcoin/pull/28759#issuecomment-1787429202)
The difference in bootstrapping is significant enough, that I'd also like to backport this to the 26.x branch. cc @theuni @darosior.

💬 willcl-ark commented on issue "sendrawtransaction takes too long":
(https://github.com/bitcoin/bitcoin/issues/28745#issuecomment-1787440296)
Hi @toolsopen

Bitcoin Core v22 is outside of maintenance window now, you should probably consider upgrading (to at least 24.2, or better still 25.1)

A few questions:

1) what do these config values do?

```
stake=0
staking=0
gen=0
```

2) How are you creating the sqlite wallet?


I can create a (new) sqlite descriptor wallet and import a wpkh pubkey on v25.1, after compiling with sqlite like this:

```sh
will@ubuntu in ~/src/bitcoin on master [$?⇡] : C v16.0.
...

💬 andrewtoth commented on pull request "p2p: adaptive connections services flags":
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1377784027)
Can we first check that we don't go back to ibd if we are stale but at the threshold, then we do go back to ibd once we step over the threshold?

💬 achow101 commented on issue "sendrawtransaction takes too long":
(https://github.com/bitcoin/bitcoin/issues/28745#issuecomment-1787466576)
> Will wallet.dat 9.3G affect performance?

Yes, significantly.

> Is there any way to clear the used transactions in it?

Not automatically. However you can use `removeprunedfunds` and delete old transactions manually.

💬 achow101 commented on pull request "guix: Zip needs to include all files and set time to SOURCE_DATE_EPOCH":
(https://github.com/bitcoin/bitcoin/pull/28757#issuecomment-1787469468)
> Yea, we should nuke the `dist/` here, otherwise, this looks good to me.

Should be done, testing now (need to rebuild, so could be a little bit).

💬 andrewtoth commented on pull request "p2p: adaptive connections services flags":
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1377793447)
The 3 lines below are the same as lines 38-40, except for the +11min. It's unclear to me from this comment what the 11min is doing and why this is different from what we are doing before. Can this maybe be explained better?

💬 hebasto commented on pull request "guix: Zip needs to include all files and set time to SOURCE_DATE_EPOCH":
(https://github.com/bitcoin/bitcoin/pull/28757#issuecomment-1787478654)
My hashes for f6f18eeaa88784e487e9bca8c5ace6c66bd721cc:
```
adc40abe61a6731b4d481d27b883731d282b61995b3ca401dea49385c89ff8ef guix-build-26.0rc1/output/arm64-apple-darwin-codesigned/bitcoin-26.0rc1-arm64-apple-darwin.zip
11ee5b21d4d0d411117a7e237d73d698170f0b18dd78ab1299499ae65abc3a1b guix-build-26.0rc1/output/x86_64-apple-darwin-codesigned/bitcoin-26.0rc1-x86_64-apple-darwin.zip
```

👍 hebasto approved a pull request: "guix: Zip needs to include all files and set time to SOURCE_DATE_EPOCH"
(https://github.com/bitcoin/bitcoin/pull/28757#pullrequestreview-1706677199)
ACK f6f18eeaa88784e487e9bca8c5ace6c66bd721cc, if hashes are the same.

💬 darosior commented on pull request "guix: update signapple to latest master":
(https://github.com/bitcoin/bitcoin/pull/28759#issuecomment-1787523074)
Concept ACK.

💬 fanquake commented on pull request "guix: update signapple to latest master":
(https://github.com/bitcoin/bitcoin/pull/28759#issuecomment-1787547324)
Guix Build (aarch64):
```bash
66c24a02462fa98aa772a7347bfa5edd64f79979e256b463cdc82808a74dc38e guix-build-79539fbfbf4d/output/aarch64-linux-gnu/SHA256SUMS.part
bf0e04a6dfc8d580428c8e33eedb57f2ec311eff054387dac985abc1e2c50a3a guix-build-79539fbfbf4d/output/aarch64-linux-gnu/bitcoin-79539fbfbf4d-aarch64-linux-gnu-debug.tar.gz
4e9d47a41bfd12f3aa5bb553b162a348359b289a4d1eeb0ce83029852bf66036 guix-build-79539fbfbf4d/output/aarch64-linux-gnu/bitcoin-79539fbfbf4d-aarch64-linux-gnu.tar.gz
e912a6
...

👍 TheCharlatan approved a pull request: "guix: Zip needs to include all files and set time to SOURCE_DATE_EPOCH"
(https://github.com/bitcoin/bitcoin/pull/28757#pullrequestreview-1706792598)
ACK f6f18eeaa88784e487e9bca8c5ace6c66bd721cc

I get the same hashes as @hebasto and have checked that it still installs fine.

🚀 fanquake merged a pull request: "guix: Zip needs to include all files and set time to SOURCE_DATE_EPOCH"
(https://github.com/bitcoin/bitcoin/pull/28757)

💬 fanquake commented on pull request "guix: Zip needs to include all files and set time to SOURCE_DATE_EPOCH":
(https://github.com/bitcoin/bitcoin/pull/28757#issuecomment-1787599465)
Added to #28754.