💬 MarcoFalke commented on pull request "ci: Cache more stuff in the ci images: msan, iwyu, pip, sdks":
(https://github.com/bitcoin/bitcoin/pull/27028#issuecomment-1456213291)
Rebased. For review I suggest `--color-moved=dimmed-zebra`.

💬 MarcoFalke commented on pull request "Handle invalid hex encoding in ParseHex":
(https://github.com/bitcoin/bitcoin/pull/25227#issuecomment-1456215491)
Yeah, the same happens on Lunar (gcc 12.2). Steps to reproduce on a fresh install:


```
export HOST=powerpc64le-linux-gnu && export MAKEJOBS="$(nproc)" && apt update && apt install git vim htop -y && git clone https://github.com/bitcoin/bitcoin.git --depth=1 ./bitcoin-core && cd bitcoin-core && apt install -y bzip2 make automake cmake curl g++-multilib libtool binutils bsdmainutils pkg-config python3 patch bison && apt install -y g++-arm-linux-gnueabihf binutils-arm-linux-gnueabihf
...

💬 Ayms commented on issue "Allow several OP_RETURN in one tx and no limited size":
(https://github.com/bitcoin/bitcoin/issues/27043#issuecomment-1456245569)
@petertodd then could someone please do it? (you?)

I am good with js/nodejs/browsers but can't pretend to be a C/C++ expert, even if the change is simple it would be a waste of time/not serious I believe that I issue a PR for this, and approximation can't work with Bitcoin code

@ChristopherA did open the debate, which did intersect some discussions that I started, that's why I opened this issue myself, you proposed a solution but at the end it just must be done

💬 MarcoFalke commented on pull request "Handle invalid hex encoding in ParseHex":
(https://github.com/bitcoin/bitcoin/pull/25227#issuecomment-1456248391)
It works on gcc-10 (debian buster), same steps to reproduce as above.

👍 instagibbs approved a pull request: "test: psbt: check non-witness UTXO removal for segwit v1 input"
(https://github.com/bitcoin/bitcoin/pull/27200)
ACK 3dd2f6461b4bb28b2b212c691a3df28ac793ad91

Documenting the expected behavior is good. I wonder if some signers could have trouble if they haven't implemented taproot support, and thus will expect non witness utxos?

Apparently this hasn't caused a problem yet, so maybe not.

💬 instagibbs commented on pull request "test: psbt: check non-witness UTXO removal for segwit v1 input":
(https://github.com/bitcoin/bitcoin/pull/27200#discussion_r1126520060)
feel like there should be a subroutine to do this for any given test

💬 instagibbs commented on pull request "test: psbt: check non-witness UTXO removal for segwit v1 input":
(https://github.com/bitcoin/bitcoin/pull/27200#discussion_r1126525040)
also above: "#TODO: Remove address type restrictions once taproot has psbt extensions" can this be dropped now?

💬 gruve-p commented on pull request "Handle invalid hex encoding in ParseHex":
(https://github.com/bitcoin/bitcoin/pull/25227#issuecomment-1456297791)
Same issue on Ubuntu Jammy (22.04) when crosscompiling with depends for these hosts:
```
i686-pc-linux-gnu
arm-linux-gnueabihf
powerpc64-linux-gnu
powerpc64le-linux-gnu
riscv64-linux-gnu
s390x-linux-gnu
```
gcc-11

💬 vasild commented on pull request "gui: use the stored CSubNet entry when unbanning":
(https://github.com/bitcoin-core/gui/pull/717#issuecomment-1456310972)
@furszy, done, thanks!

💬 achow101 commented on pull request "doc: Expand scantxoutset help text to cover tr() and miniscript":
(https://github.com/bitcoin/bitcoin/pull/27155#issuecomment-1456362357)
ACK ca605f015dc8fbabbc6c0640d87429d6bf8f553f

💬 achow101 commented on pull request "doc: Expand scantxoutset help text to cover tr() and miniscript":
(https://github.com/bitcoin/bitcoin/pull/27155#discussion_r1126621907)
@instagibbs Are you planning on changing this?

💬 achow101 commented on pull request "doc: Expand scantxoutset help text to cover tr() and miniscript":
(https://github.com/bitcoin/bitcoin/pull/27155#issuecomment-1456366006)
> Should we version the `doc/descriptors.md` file? By that I mean literally add details in the doc saying when specific formats were added.

Probably.

💬 achow101 commented on pull request "wallet: use Mutex for g_sqlite_mutex instead of GlobalMutex":
(https://github.com/bitcoin/bitcoin/pull/25491#issuecomment-1456371580)
ACK 4163093d6374e865dc57e33dbea0e7e359062e0a

💬 instagibbs commented on pull request "doc: Expand scantxoutset help text to cover tr() and miniscript":
(https://github.com/bitcoin/bitcoin/pull/27155#discussion_r1126643531)
added a version of it, thanks

💬 instagibbs commented on pull request "doc: Expand scantxoutset help text to cover tr() and miniscript":
(https://github.com/bitcoin/bitcoin/pull/27155#discussion_r1126643785)
yeah, pushed the change.

🚀 achow101 merged a pull request: "wallet: use Mutex for g_sqlite_mutex instead of GlobalMutex"
(https://github.com/bitcoin/bitcoin/pull/25491)

💬 ishaanam commented on pull request "test: fix race condition in encrypted wallet rescan tests":
(https://github.com/bitcoin/bitcoin/pull/27199#discussion_r1126645252)
>Any reason to use the cli, when the normal rpc can be used directly?

When I use the normal RPC directly, I get a `CannotSendRequest` error.
> Also, I wonder if this introduces another race where the actual rescan in t.start() is scheduled after this call.

Yes, it does. I have used `assert_debug_log` with a timeout of 5 to fix this.

💬 instagibbs commented on pull request "doc: Expand scantxoutset help text to cover tr() and miniscript":
(https://github.com/bitcoin/bitcoin/pull/27155#issuecomment-1456388168)
Ok, this is the last PR like this I'll do then; going forward we should version the doc itself with updates.

Pushed updates.

👍 darosior approved a pull request: "doc: Expand scantxoutset help text to cover tr() and miniscript"
(https://github.com/bitcoin/bitcoin/pull/27155)
webACK e4ede64fe87b1619f65da5753088d93e6f481b05

📝 MarcoFalke opened a pull request: "test: Make the unlikely race in p2p_invalid_messages impossible?"
(https://github.com/bitcoin/bitcoin/pull/27212)
After `add_p2p_connection` both sides have the verack processed.
However the pong from conn in reply to the ping from the node has not
been processed and recorded in totalbytesrecv.
Flush the pong from conn by sending a ping from conn.


This should make the unlikely race impossible.