💬 darosior commented on pull request "doc: Expand scantxoutset help text to cover tr() and miniscript":
(https://github.com/bitcoin/bitcoin/pull/27155#discussion_r1121613859)
nit: i don't think it's worth mentioning Miniscript here, and especially not as something external to descriptors.

💬 Sjors commented on pull request "doc: Expand scantxoutset help text to cover tr() and miniscript":
(https://github.com/bitcoin/bitcoin/pull/27155#issuecomment-1450040369)
Concept ACK. Note that the help already refers to `doc/descriptors.md` so it doesn't have to be super thorough.

💬 dergoegge commented on pull request "net, refactor: net_processing, add `ProcessCompactBlockTxns`":
(https://github.com/bitcoin/bitcoin/pull/26969#discussion_r1121638358)
```suggestion
void ProcessBlockTxns(CNode& pfrom, const Peer& peer, const BlockTransactions& block_transactions)
```

Just create a new CNetMsgMaker, no need to pass it.

💬 TheCharlatan commented on pull request "build: Include qt sources for parsing with extract_strings.py":
(https://github.com/bitcoin/bitcoin/pull/22764#issuecomment-1450067557)
Concept ACK

💬 theStack commented on issue "make check errors on big endian OpenBSD 7.2":
(https://github.com/bitcoin/bitcoin/issues/26492#issuecomment-1450097418)
> @theStack @grubles can you confirm if this is still an issue, i.e with master or not, and on which systems/OS? Note that you can also use `--enable-suppress-external-warnings` to avoid the Boost build spam.

I was never able to reproduce this issue. On the emulated SPARC64 machine (see https://github.com/bitcoin/bitcoin/issues/26492#issuecomment-1314149488) also all tests passed.

💬 Sjors commented on pull request "guix: switch to some `minimal` versions of packages in our manifest":
(https://github.com/bitcoin/bitcoin/pull/27172#issuecomment-1450156518)
tACK 2c9eb4afe1f583aafa552b2711b149f17ef8320f

I get the same Guix hashes. Lightly tested on macOS.

🚀 fanquake merged a pull request: "Update translations for 25.0 soft translation string freeze"
(https://github.com/bitcoin/bitcoin/pull/27169)

👍 hebasto approved a pull request: "http: Track active requests and wait for last to finish - 2nd attempt"
(https://github.com/bitcoin/bitcoin/pull/26742)
ACK 60978c8080ec13ff4571c8a89e742517b2aca692

💬 hebasto commented on pull request "http: Track active requests and wait for last to finish - 2nd attempt":
(https://github.com/bitcoin/bitcoin/pull/26742#discussion_r1121744890)
nit: IWYU suggests to s/`#include <event2/http_struct.h>`/`#include <event2/event.h>`/.

💬 Sjors commented on pull request "Deduplicate bitcoind and bitcoin-qt init code":
(https://github.com/bitcoin/bitcoin/pull/27150#issuecomment-1450219330)
Light review ACK 802cc1e

I'm not super familiar with the init code, but the changes look sane to me. I tested some of the error messages on macOS.

Regarding d172b5c, any hints on how to produce a fatal error?

💬 instagibbs commented on pull request "doc: Expand scantxoutset help text to cover tr() and miniscript":
(https://github.com/bitcoin/bitcoin/pull/27155#discussion_r1121805808)
hmm true, will remove

💬 instagibbs commented on pull request "doc: Expand scantxoutset help text to cover tr() and miniscript":
(https://github.com/bitcoin/bitcoin/pull/27155#issuecomment-1450236357)
Wondering if the help text should just give hints to what possible types there are, and point users to the doc in question to map those types to their required formats?

Should we version the `doc/descriptors.md` file?

💬 hebasto commented on issue "Release schedule for 25.0":
(https://github.com/bitcoin/bitcoin/issues/26549#issuecomment-1450249850)
> ## 2023-03-01 construction
>
> * Open Transifex translations for 25.0
>
> * Soft translation string freeze (no large or non-critical string changes until release)
>
> * Finalize and close translations for 23.0

Done. See an [announcement](https://www.transifex.com/bitcoin/communication/d:ef30e8c2-e635-4ad7-b899-b723c6394011/?q=project%3Abitcoin) on the Transifex website (one needs to log in Transifex to read it).

💬 Sjors commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#issuecomment-1450281652)
Checked the rebase to 3d50555ec6d47f7ebdd1b74739f00a0385be1fab. I still have to study a14a7554a6 and 6bb3bee37e more.

💬 ryanofsky commented on pull request "Deduplicate bitcoind and bitcoin-qt init code":
(https://github.com/bitcoin/bitcoin/pull/27150#issuecomment-1450288153)
@sjors

> Regarding [d172b5c](https://github.com/bitcoin/bitcoin/commit/d172b5c6718b69200c8ad211fe709860081bd692), any hints on how to produce a fatal error?

I don't know of a way to trigger the `AbortError` calls in that commit offhand but I think it should be straightforward to verify that replacing them with `InitError` has no effect, because the previous definition of `AbortError` was `constexpr auto AbortError = InitError;` (The commit dropped the AbortError alias because it seemed poi
...

👍 pinheadmz approved a pull request: "rpc, test: remove newline escape sequence from wallet warning fields"
(https://github.com/bitcoin/bitcoin/pull/27138)
ACK f0391cd3ea562d526db63996e7694ff4cd44b8b2

📝 hebasto opened a pull request: "doc: Update Transifex links and slug format in Release Process"
(https://github.com/bitcoin/bitcoin/pull/27183)
Reflected the recent changes in Transifex's [workflow](https://github.com/bitcoin/bitcoin/pull/26321) and on its website.

💬 ryanofsky commented on pull request "rpc, test: remove newline escape sequence from wallet warning fields":
(https://github.com/bitcoin/bitcoin/pull/27138#issuecomment-1450339501)
-0. Showing \n on the terminal seems like a client side problem not a server side problem, and this server-side change makes it harder for other clients besides bitcoin-cli to display the warnings clearly on separate lines.

IMO, the ideal fix for this would be for `bitcoin-cli` to colorize and pretty-print the json when it detects stdout is a tty.

💬 achow101 commented on pull request "guix: switch to some `minimal` versions of packages in our manifest":
(https://github.com/bitcoin/bitcoin/pull/27172#issuecomment-1450352576)
ACK 2c9eb4afe1f583aafa552b2711b149f17ef8320f

```
220003bd9c9cb840444494232b01b3d9e17ddda007abfd1b3a1001662b5f24c6 guix-build-2c9eb4afe1f5/output/aarch64-linux-gnu/SHA256SUMS.part
cc7f6e969a37d66164aad138635ea4ca1bb30eff2ed59a16c6b4af716824e4f1 guix-build-2c9eb4afe1f5/output/aarch64-linux-gnu/bitcoin-2c9eb4afe1f5-aarch64-linux-gnu-debug.tar.gz
6f1afad24db86220a29f8e3ee9170201b5ece045e00ce94d1000f0541a111a4d guix-build-2c9eb4afe1f5/output/aarch64-linux-gnu/bitcoin-2c9eb4afe1f5-aarch64-lin
...

💬 Sjors commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1121931215)
Some suggestions after our chat:

* let's move this into (a) helper function(s):
* `FindGlobalHDKeyAmongstDescriptors()`
* `SetGlobalHDKey()`
* document this function, e.g. explain that it's trying to find the pattern of 3 or 4 descriptor pairs that use the same master key. Note how some might no longer be active because the user imported another descriptor and made it active. There might also be more than one set matching this pattern due to toggling encryption, so we pick the most rec
...