💬 glozow commented on pull request "[ci] bump lint task to lunar for git v2.38":
(https://github.com/bitcoin/bitcoin/pull/27174#issuecomment-1448309112)
> lgtm ACK https://github.com/bitcoin/bitcoin/commit/257dfef897db0ece387511d0592076381aaeff2b

sorry, pushed again because commit message still said lunar

💬 darosior commented on pull request "Make miniscript_{stable,smart} fuzzers avoid too large scripts":
(https://github.com/bitcoin/bitcoin/pull/27165#issuecomment-1448313061)
re-ACK 56e37e71a2

💬 MarcoFalke commented on pull request "ci: bump lint task to bookworm for git v2.38":
(https://github.com/bitcoin/bitcoin/pull/27174#discussion_r1120184805)
Yes, the debian tag should be more stable than `lunar`, because it should be around for ~3 years, as opposed to ~1 year for lunar, looking at how long docker hub kept them historically.

(Can be marked as resolved)

💬 MarcoFalke commented on pull request "test: fix intermittent issue in `feature_bip68_sequence`":
(https://github.com/bitcoin/bitcoin/pull/27177#discussion_r1120193686)
Instead of overwriting and discarding the previous filter, it might be better to just set it once. This can be done by nesting the new `if` under a new `elif`.

Another alternative would be to always apply the filter.

🚀 achow101 merged a pull request: "prune: scan and unlink already pruned block files on startup"
(https://github.com/bitcoin/bitcoin/pull/26533)

💬 MarcoFalke commented on pull request "guix: switch to some `minimal` versions of packages in our manifest":
(https://github.com/bitcoin/bitcoin/pull/27172#issuecomment-1448325539)
Is there an intuition on how much space this will save? Also, it might be good to check the binaries are identical before and after?

💬 andrewtoth commented on pull request "net: don't lock cs_main while reading blocks in net processing":
(https://github.com/bitcoin/bitcoin/pull/26326#discussion_r1120198609)
See https://github.com/bitcoin/bitcoin/pull/26326#discussion_r1043171470. Blocks below `MAX_BLOCKTXN_DEPTH` can't be pruned, so we should retain the current behavior if this read fails.

💬 achow101 commented on pull request "ci: bump lint task to bookworm for git v2.38":
(https://github.com/bitcoin/bitcoin/pull/27174#issuecomment-1448344724)
ACK a984beeca10e3ae1ceb3ea53e4dea778160e7079

👍 hebasto approved a pull request: "ci: bump lint task to bookworm for git v2.38"
(https://github.com/bitcoin/bitcoin/pull/27174)
re-ACK a984beeca10e3ae1ceb3ea53e4dea778160e7079

💬 TheCharlatan commented on pull request "guix: switch to some `minimal` versions of packages in our manifest":
(https://github.com/bitcoin/bitcoin/pull/27172#issuecomment-1448349530)
ACK 2c9eb4afe1f5

Guix builds:

```
220003bd9c9cb840444494232b01b3d9e17ddda007abfd1b3a1001662b5f24c6 guix-build-2c9eb4afe1f5/output/aarch64-linux-gnu/SHA256SUMS.part
cc7f6e969a37d66164aad138635ea4ca1bb30eff2ed59a16c6b4af716824e4f1 guix-build-2c9eb4afe1f5/output/aarch64-linux-gnu/bitcoin-2c9eb4afe1f5-aarch64-linux-gnu-debug.tar.gz
6f1afad24db86220a29f8e3ee9170201b5ece045e00ce94d1000f0541a111a4d guix-build-2c9eb4afe1f5/output/aarch64-linux-gnu/bitcoin-2c9eb4afe1f5-aarch64-linux-gnu.tar.g
...

💬 fanquake commented on pull request "guix: switch to some `minimal` versions of packages in our manifest":
(https://github.com/bitcoin/bitcoin/pull/27172#issuecomment-1448349712)
> Is there an intuition on how much space this will save?

Maybe 10's of megabytes (will get you a number). Saving any space is a nice side-effect, but isn't the primary goal here. The goal is to remove things that are not required in the release build environment, from the release build envionronment. Using available `*-minimal` packages also better communicates the intent of creating a minimal build env.

I would also assume this makes any bootstrapping paths less complicated, as any tools
...

👍 willcl-ark approved a pull request: "docs: GetDataDirNet and GetDataDirBase don't create datadir"
(https://github.com/bitcoin/bitcoin/pull/27176)
ACK fb0dbe942

Thanks for updating these.

💬 brunoerg commented on pull request "test: fix intermittent issue in `feature_bip68_sequence`":
(https://github.com/bitcoin/bitcoin/pull/27177#discussion_r1120264452)
I didn't notice it was descarding the previous one, perhaps we could do:
```py
self._utxos = sorted(self._utxos, key=lambda k: (k['value'], -k['height'])) # Put the largest utxo last
if txid:
utxo_filter = filter(lambda utxo: txid == utxo['txid'], self._utxos)
else:
utxo_filter = reversed(self._utxos) # By default the largest utxo
if not include_immature_coinbase:
utxo_filter = filter(lambda utxo: not utxo['coinbase']
...

🚀 fanquake merged a pull request: "docs: GetDataDirNet and GetDataDirBase don't create datadir"
(https://github.com/bitcoin/bitcoin/pull/27176)

👍 MarcoFalke approved a pull request: "ci: bump lint task to bookworm for git v2.38"
(https://github.com/bitcoin/bitcoin/pull/27174)

💬 achow101 commented on pull request "refactor: Move calculation logic out from `CheckSequenceLocksAtTip()`":
(https://github.com/bitcoin/bitcoin/pull/23897#issuecomment-1448395425)
ACK 75db62ba4cae048e742ca02dc6a52b3b3d6727de

🚀 fanquake merged a pull request: "ci: bump lint task to bookworm for git v2.38"
(https://github.com/bitcoin/bitcoin/pull/27174)

💬 achow101 commented on pull request "refactor: Stop using gArgs global in system.cpp":
(https://github.com/bitcoin/bitcoin/pull/27170#issuecomment-1448418416)
ACK 9a9d5da11fa6033f82dcf8e2298aee29587f5396

💬 fanquake commented on issue "make check errors on big endian OpenBSD 7.2":
(https://github.com/bitcoin/bitcoin/issues/26492#issuecomment-1448424566)
@theStack @grubles can you confirm if this is still an issue, i.e with master or not, and on which systems/OS? Note that you can also use `--enable-suppress-external-warnings` to avoid the Boost build spam.

💬 MarcoFalke commented on pull request "bench: update logging benchmarks":
(https://github.com/bitcoin/bitcoin/pull/26957#discussion_r1120305388)
Is it not possible to call the existing `EnableCategory` and disable functions?