📝 fanquake converted_to_draft a pull request: "RPC/Wallet: Convert walletprocesspsbt to use options parameter"
(https://github.com/bitcoin/bitcoin/pull/24963)
null

💬 fanquake commented on pull request "RPC/Wallet: Convert walletprocesspsbt to use options parameter":
(https://github.com/bitcoin/bitcoin/pull/24963#issuecomment-1447931166)
Drafted for now. Needs a PR description and rebasing to fix the merge conflict:
```bash
wallet/rpc/spend.cpp:1541:75: error: no member named 'OMITTED_NAMED_ARG' in 'RPCArg::Optional'
{"options|sign", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED_NAMED_ARG, "",
~~~~~~~~~~~~~~~~~~^
wallet/rpc/spend.cpp:1600:9: error: use of undeclared identifier 'RPCTypeCheckArgument'
RPCTypeCheckArgument(options, UniValue::VO
...

💬 hebasto commented on pull request "guix: switch to some `minimal` versions of packages in our manifest":
(https://github.com/bitcoin/bitcoin/pull/27172#issuecomment-1447934046)
Concept ACK.

🚀 fanquake merged a pull request: "depends: harden libevent"
(https://github.com/bitcoin/bitcoin/pull/27118)

💬 fanquake commented on pull request "security-check: test for `_FORTIFY_SOURCE` usage in release binaries":
(https://github.com/bitcoin/bitcoin/pull/27038#issuecomment-1447937422)
Rebased post #27118.

💬 TheCharlatan commented on pull request "guix: switch to some `minimal` versions of packages in our manifest":
(https://github.com/bitcoin/bitcoin/pull/27172#issuecomment-1447942274)
Concept ACK

📝 fanquake converted_to_draft a pull request: "RPC/Wallet: Add "use_txids" to output of getaddressinfo"
(https://github.com/bitcoin/bitcoin/pull/22693)
(Non-GUI part of #15987, but without the bloom stuff)

💬 fanquake commented on pull request "RPC/Wallet: Add "use_txids" to output of getaddressinfo":
(https://github.com/bitcoin/bitcoin/pull/22693#issuecomment-1447943334)
Drafted for now. Feedback/comments needs addressing, needs rebase, PR description needs updating to mention the new related PR (#15987 is closed).

💬 fanquake commented on pull request "util: improve FindByte() performance":
(https://github.com/bitcoin/bitcoin/pull/19690#issuecomment-1447948999)
What are the next steps here? Anyone want to look into why this is apparently a performance degredation for ARM macOS? Maybe @john-moffett?

🚀 fanquake merged a pull request: "init: Return ChainstateLoadStatus::INTERRUPTED when verification was interrupted."
(https://github.com/bitcoin/bitcoin/pull/27157)

📝 fanquake opened a pull request: "valgrind: remove libsecp256k1 suppression"
(https://github.com/bitcoin/bitcoin/pull/27173)
I am no-longer been able to recreate this issue, atleast after the most recent libsecp256k1 changes. Can someone else confirm?

👍 willcl-ark approved a pull request: "refactor: Stop using gArgs global in system.cpp"
(https://github.com/bitcoin/bitcoin/pull/27170)
tACK 9a9d5da11

Tidy changes to remove the last references to global `gArgs` from util/system.cpp (besides the global declaration).

📝 glozow opened a pull request: "[ci] bump lint task to lunar for git v2.38"
(https://github.com/bitcoin/bitcoin/pull/27174)
Since 5497c14, verify-commits.py uses `git merge-tree` which requires git v2.38 or later. Fix the lint jobs on master (e.g. https://cirrus-ci.com/task/4971007513985024).

🤔 furszy requested changes to a pull request: "Mask values on Transactions View"
(https://github.com/bitcoin-core/gui/pull/708)
Need to adapt `BitcoinUnits::formatWithPrivacy` function to accept negative amounts. Otherwise, when the wallet make a send, the assertion crashes the software.

💬 fanquake commented on pull request "build: Pointer Authentication and Branch Target Identification for aarch64 Linux (Guix)":
(https://github.com/bitcoin/bitcoin/pull/24123#issuecomment-1448075642)
Rebased past #27118.

👍 stickies-v approved a pull request: "refactor: Stop using gArgs global in system.cpp"
(https://github.com/bitcoin/bitcoin/pull/27170)
ACK 9a9d5da11

💬 stickies-v commented on pull request "refactor: Stop using gArgs global in system.cpp":
(https://github.com/bitcoin/bitcoin/pull/27170#discussion_r1119971107)
nit: Looks like this shouldn't have been called on `gArgs` regardless of this PR, perhaps useful to split out in separate commit? In the 3 callsites of `ArgsManager::ReadConfigFiles` I see, it is only called on `gArgs` anyway, so I don't see any actual behaviour change/potential bug because of it.

👍 hebasto approved a pull request: "[ci] bump lint task to lunar for git v2.38"
(https://github.com/bitcoin/bitcoin/pull/27174)
ACK 836720e366f61f23c7a56775e11d58890b002d75

💬 fanquake commented on pull request "guix: switch to some `minimal` versions of packages in our manifest":
(https://github.com/bitcoin/bitcoin/pull/27172#issuecomment-1448088251)
Updated to also switch to `cmake-minimal` in the macOS builds.

💬 MarcoFalke commented on pull request "[ci] bump lint task to lunar for git v2.38":
(https://github.com/bitcoin/bitcoin/pull/27174#discussion_r1119990351)
This will reach EOL in less than a year and thus fail CI tasks when the tag is deleted. What about using https://packages.debian.org/bookworm/git ?