💬 fanquake commented on pull request "refactor: Stop using gArgs global in system.cpp":
(https://github.com/bitcoin/bitcoin/pull/27170#issuecomment-1447846541)
Concept ACK

💬 TheCharlatan commented on pull request "Deduplicate bitcoind and bitcoin-qt init code":
(https://github.com/bitcoin/bitcoin/pull/27150#discussion_r1119622390)
nit: s/to whether/whether to/

💬 TheCharlatan commented on pull request "Deduplicate bitcoind and bitcoin-qt init code":
(https://github.com/bitcoin/bitcoin/pull/27150#discussion_r1119655981)
More a comment in case anybody else stumbles over this than a change request, but I'm surprised this is done in `bitcoind` and not in `bitcoin-qt`. Indeed I can start bitcoin-qt with any number of positional arguments, e.g. `./qt/bitcoin-qt h j k`, but not so `bitcoind`. The historical [context](https://github.com/bitcoin/bitcoin/pull/10447) is that this is a leftover from when `bitcoind` was also used as a command line client.

👍 darosior approved a pull request: "Make miniscript_{stable,smart} fuzzers avoid too large scripts"
(https://github.com/bitcoin/bitcoin/pull/27165)
ACK b09b7a1f94885feed5d44a3858543536e3659287

Elegant fix and improvement. Just two non-blocking comments.

💬 darosior commented on pull request "Make miniscript_{stable,smart} fuzzers avoid too large scripts":
(https://github.com/bitcoin/bitcoin/pull/27165#discussion_r1119807797)
Maybe worth pointing to the explanatory comment in `Parse()`? I think the "borrowing" logic could be a little unclear to a reader with less context.

💬 darosior commented on pull request "Make miniscript_{stable,smart} fuzzers avoid too large scripts":
(https://github.com/bitcoin/bitcoin/pull/27165#discussion_r1119792156)
You can directly pass the number of sub fragments to `ComputeScriptLen` instead of passing `0` and then adding it.
```patch
diff --git a/src/test/fuzz/miniscript.cpp b/src/test/fuzz/miniscript.cpp
index 90d752b898..490fac18ce 100644
--- a/src/test/fuzz/miniscript.cpp
+++ b/src/test/fuzz/miniscript.cpp
@@ -781,7 +781,7 @@ NodeRef GenNode(F ConsumeNode, Type root_type, bool strict_valid = false) {
auto node_info = ConsumeNode(type_needed);
if (!node_info) return {
...

💬 hebasto commented on pull request "refactor: Stop using gArgs global in system.cpp":
(https://github.com/bitcoin/bitcoin/pull/27170#issuecomment-1447896322)
Concept ACK.

📝 fanquake opened a pull request: "guix: switch to some `minimal` versions of packages in our manifest"
(https://github.com/bitcoin/bitcoin/pull/27172)
Minimal versions of the same packages, that should still be sufficient for our use:

> (define-public bash-minimal
;; A stripped-down Bash for non-interactive use.

> (define-public coreutils-minimal
;; Coreutils without its optional dependencies.

📝 fanquake converted_to_draft a pull request: "RPC/Wallet: Convert walletprocesspsbt to use options parameter"
(https://github.com/bitcoin/bitcoin/pull/24963)
null

💬 fanquake commented on pull request "RPC/Wallet: Convert walletprocesspsbt to use options parameter":
(https://github.com/bitcoin/bitcoin/pull/24963#issuecomment-1447931166)
Drafted for now. Needs a PR description and rebasing to fix the merge conflict:
```bash
wallet/rpc/spend.cpp:1541:75: error: no member named 'OMITTED_NAMED_ARG' in 'RPCArg::Optional'
{"options|sign", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED_NAMED_ARG, "",
~~~~~~~~~~~~~~~~~~^
wallet/rpc/spend.cpp:1600:9: error: use of undeclared identifier 'RPCTypeCheckArgument'
RPCTypeCheckArgument(options, UniValue::VO
...

💬 hebasto commented on pull request "guix: switch to some `minimal` versions of packages in our manifest":
(https://github.com/bitcoin/bitcoin/pull/27172#issuecomment-1447934046)
Concept ACK.

🚀 fanquake merged a pull request: "depends: harden libevent"
(https://github.com/bitcoin/bitcoin/pull/27118)

💬 fanquake commented on pull request "security-check: test for `_FORTIFY_SOURCE` usage in release binaries":
(https://github.com/bitcoin/bitcoin/pull/27038#issuecomment-1447937422)
Rebased post #27118.

💬 TheCharlatan commented on pull request "guix: switch to some `minimal` versions of packages in our manifest":
(https://github.com/bitcoin/bitcoin/pull/27172#issuecomment-1447942274)
Concept ACK

📝 fanquake converted_to_draft a pull request: "RPC/Wallet: Add "use_txids" to output of getaddressinfo"
(https://github.com/bitcoin/bitcoin/pull/22693)
(Non-GUI part of #15987, but without the bloom stuff)

💬 fanquake commented on pull request "RPC/Wallet: Add "use_txids" to output of getaddressinfo":
(https://github.com/bitcoin/bitcoin/pull/22693#issuecomment-1447943334)
Drafted for now. Feedback/comments needs addressing, needs rebase, PR description needs updating to mention the new related PR (#15987 is closed).

💬 fanquake commented on pull request "util: improve FindByte() performance":
(https://github.com/bitcoin/bitcoin/pull/19690#issuecomment-1447948999)
What are the next steps here? Anyone want to look into why this is apparently a performance degredation for ARM macOS? Maybe @john-moffett?

🚀 fanquake merged a pull request: "init: Return ChainstateLoadStatus::INTERRUPTED when verification was interrupted."
(https://github.com/bitcoin/bitcoin/pull/27157)

📝 fanquake opened a pull request: "valgrind: remove libsecp256k1 suppression"
(https://github.com/bitcoin/bitcoin/pull/27173)
I am no-longer been able to recreate this issue, atleast after the most recent libsecp256k1 changes. Can someone else confirm?

👍 willcl-ark approved a pull request: "refactor: Stop using gArgs global in system.cpp"
(https://github.com/bitcoin/bitcoin/pull/27170)
tACK 9a9d5da11

Tidy changes to remove the last references to global `gArgs` from util/system.cpp (besides the global declaration).