✅ MarcoFalke closed an issue: "test: p2p_message_capture.py fails with undefined sanitizer"
(https://github.com/bitcoin/bitcoin/issues/27149)

💬 fanquake commented on issue "[POC] [RFC] build: Separate GUI application build system":
(https://github.com/bitcoin/bitcoin/issues/24911#issuecomment-1443520838)
Closing for now, as I don't think there is anything actionable here. We aren't going to add new dependencies any time soon, if ever, and we aren't going to shuffle code/directories around (the linked branch) in this repository to facilitate easier rebasing in an experimental gui-fork.

✅ fanquake closed an issue: "[POC] [RFC] build: Separate GUI application build system"
(https://github.com/bitcoin/bitcoin/issues/24911)

💬 fanquake commented on issue "Add support for all networks in `deserialize_v2` in test_framework":
(https://github.com/bitcoin/bitcoin/issues/27140#issuecomment-1443528191)
Can probably just be done when some code is added that would actually use the functionality? Going to close this for now.

✅ fanquake closed an issue: "Add support for all networks in `deserialize_v2` in test_framework"
(https://github.com/bitcoin/bitcoin/issues/27140)

💬 fanquake commented on issue "Bitcoin Core very slow sync":
(https://github.com/bitcoin/bitcoin/issues/27134#issuecomment-1443531666)
> My computer is about 6 years old.

What sort of harddrive do you have?

Going to close for now in any case. It's not possible for us to debug this, or provide any suggestions until you provide further information. Can be reopened if that happens.

✅ fanquake closed an issue: "Bitcoin Core very slow sync"
(https://github.com/bitcoin/bitcoin/issues/27134)

💬 fanquake commented on issue "Network Drive (NAS) Support":
(https://github.com/bitcoin/bitcoin/issues/26939#issuecomment-1443533895)
@byjlw What's the status of this / result of your testing?

💬 fanquake commented on issue "build: xproto fails to install on aarch64-unknown-linux-musl":
(https://github.com/bitcoin/bitcoin/issues/26881#issuecomment-1443538309)
Closing for now. Not concerned whether this is fixed or not.

✅ fanquake closed an issue: "build: xproto fails to install on aarch64-unknown-linux-musl"
(https://github.com/bitcoin/bitcoin/issues/26881)

💬 brunoerg commented on issue "Add support for all networks in `deserialize_v2` in test_framework":
(https://github.com/bitcoin/bitcoin/issues/27140#issuecomment-1443550025)
> Can probably just be done when some code is added that would actually use the functionality? Going to close this for now.

Sorry for not specifying but 'message-capture-parser' is not able to deserialize some addrv2 messages because of it. So, could we leave this issue opened?

⚠️ fanquake reopened an issue: "Add support for all networks in `deserialize_v2` in test_framework"
(https://github.com/bitcoin/bitcoin/issues/27140)
`deserialize_v2` function (`test_framework`) should be able to deseriablize all networks presented in BIP155 (e.g. onion, ipv6, etc), however, it only works for ipv4 and i2p. I noticed that when I was using `message-capture-parser` and realized that most `addrv2` messages weren't able to be deserialized.

📝 fanquake opened a pull request: "doc: mention sanitizer suppressions in developer docs"
(https://github.com/bitcoin/bitcoin/pull/27154)
Should be enough to close #17834.

💬 MarcoFalke commented on pull request "doc: mention sanitizer suppressions in developer docs":
(https://github.com/bitcoin/bitcoin/pull/27154#issuecomment-1443621407)
Nice

lgtm ACK 84ca5b349ecc2ad083bb39352e5d5ae731fb1622

💬 byjlw commented on issue "Network Drive (NAS) Support":
(https://github.com/bitcoin/bitcoin/issues/26939#issuecomment-1443631657)
Came up with a different solution. Will close this issue.

✅ byjlw closed an issue: "Network Drive (NAS) Support"
(https://github.com/bitcoin/bitcoin/issues/26939)

💬 Sjors commented on pull request "doc: mention sanitizer suppressions in developer docs":
(https://github.com/bitcoin/bitcoin/pull/27154#issuecomment-1443637180)
Sounds good, I'm currently trying that.

💬 Sjors commented on issue " Document how to run bitcoin unittests + functional tests with sanitizers":
(https://github.com/bitcoin/bitcoin/issues/17834#issuecomment-1443639638)
#27154 adds documentation about suppressions, which is useful.

Running the functional tests with valgrind - and otherwise normal compilation, though `with--enable-debug`, causes a bunch of failures for me. Compiling without legacy wallet helps, so we could document that. For the other failures I still need to check if they're deterministic.

👍 furszy approved a pull request: "wallet: skip R-value signature grinding for external signers"
(https://github.com/bitcoin/bitcoin/pull/26032)
ACK 807de2ce

💬 MarcoFalke commented on issue " Document how to run bitcoin unittests + functional tests with sanitizers":
(https://github.com/bitcoin/bitcoin/issues/17834#issuecomment-1443658356)
You'll also need to increase the timeout factor.

`./test/functional/test_runner.py --help | grep timeout-factor`