💬 jarolrod commented on pull request "Deduplicate bitcoind and bitcoin-qt init code":
(https://github.com/bitcoin/bitcoin/pull/27150#issuecomment-1442770016)
concept ack

💬 davidgumberg commented on pull request "util: Remove duplicate include":
(https://github.com/bitcoin/bitcoin/pull/27151#issuecomment-1442845959)
ACK https://github.com/bitcoin/bitcoin/pull/27151/commits/e8462690a9ff0b4155c31981fd97be16663ebb35

💬 fanquake commented on pull request "Deduplicate bitcoind and bitcoin-qt init code":
(https://github.com/bitcoin/bitcoin/pull/27150#issuecomment-1443202476)
Concept ACK - #27073 has now been merged.

🚀 fanquake merged a pull request: "util: Remove duplicate include"
(https://github.com/bitcoin/bitcoin/pull/27151)

💬 hebasto commented on pull request "Deduplicate bitcoind and bitcoin-qt init code":
(https://github.com/bitcoin/bitcoin/pull/27150#issuecomment-1443297209)
Concept ACK.

⚠️ fanquake opened an issue: "interpreter: split PrecomputedTransactionData::Init() or rename `force`"
(https://github.com/bitcoin/bitcoin/issues/27152)
Potential followup from https://github.com/bitcoin/bitcoin/pull/27122#pullrequestreview-1307630323:

> I do wonder if it makes sense to rename force to something like signing_context or even more drastically split Init up into two obvious types ConsensusInit/SigningInit to make things clearer to future readers.

Seems like there might also be scope to make some of the `Init()` inline commentary clearer, given other review comments in #27122.

cc @instagibbs @ajtowns @roconnor-blockstream.
...

📝 fanquake opened a pull request: "guix: pass `--enable-initfini-array` to release GCC"
(https://github.com/bitcoin/bitcoin/pull/27153)
This returns us to pre-Guix behaviour, where the compilers we were using to build releases, were configured with this option.

🚀 glozow merged a pull request: "Remove MarcoFalke fingerprint, update trusted-git-root"
(https://github.com/bitcoin/bitcoin/pull/27135)

💬 MarcoFalke commented on issue "test: p2p_message_capture.py fails with undefined sanitizer":
(https://github.com/bitcoin/bitcoin/issues/27149#issuecomment-1443500021)
Closing for now. Let us know if this is still an issue with the suppressions file.

The doc questions should be handled in 17834

✅ MarcoFalke closed an issue: "test: p2p_message_capture.py fails with undefined sanitizer"
(https://github.com/bitcoin/bitcoin/issues/27149)

💬 fanquake commented on issue "[POC] [RFC] build: Separate GUI application build system":
(https://github.com/bitcoin/bitcoin/issues/24911#issuecomment-1443520838)
Closing for now, as I don't think there is anything actionable here. We aren't going to add new dependencies any time soon, if ever, and we aren't going to shuffle code/directories around (the linked branch) in this repository to facilitate easier rebasing in an experimental gui-fork.

✅ fanquake closed an issue: "[POC] [RFC] build: Separate GUI application build system"
(https://github.com/bitcoin/bitcoin/issues/24911)

💬 fanquake commented on issue "Add support for all networks in `deserialize_v2` in test_framework":
(https://github.com/bitcoin/bitcoin/issues/27140#issuecomment-1443528191)
Can probably just be done when some code is added that would actually use the functionality? Going to close this for now.

✅ fanquake closed an issue: "Add support for all networks in `deserialize_v2` in test_framework"
(https://github.com/bitcoin/bitcoin/issues/27140)

💬 fanquake commented on issue "Bitcoin Core very slow sync":
(https://github.com/bitcoin/bitcoin/issues/27134#issuecomment-1443531666)
> My computer is about 6 years old.

What sort of harddrive do you have?

Going to close for now in any case. It's not possible for us to debug this, or provide any suggestions until you provide further information. Can be reopened if that happens.

✅ fanquake closed an issue: "Bitcoin Core very slow sync"
(https://github.com/bitcoin/bitcoin/issues/27134)

💬 fanquake commented on issue "Network Drive (NAS) Support":
(https://github.com/bitcoin/bitcoin/issues/26939#issuecomment-1443533895)
@byjlw What's the status of this / result of your testing?

💬 fanquake commented on issue "build: xproto fails to install on aarch64-unknown-linux-musl":
(https://github.com/bitcoin/bitcoin/issues/26881#issuecomment-1443538309)
Closing for now. Not concerned whether this is fixed or not.

✅ fanquake closed an issue: "build: xproto fails to install on aarch64-unknown-linux-musl"
(https://github.com/bitcoin/bitcoin/issues/26881)

💬 brunoerg commented on issue "Add support for all networks in `deserialize_v2` in test_framework":
(https://github.com/bitcoin/bitcoin/issues/27140#issuecomment-1443550025)
> Can probably just be done when some code is added that would actually use the functionality? Going to close this for now.

Sorry for not specifying but 'message-capture-parser' is not able to deserialize some addrv2 messages because of it. So, could we leave this issue opened?