Bitcoin Core Github
44 subscribers
121K links
Download Telegram
💬 TheCharlatan commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#issuecomment-1442521535)
Rebased.
📝 achow101 opened a pull request: "util: Remove duplicate include"
(https://github.com/bitcoin/bitcoin/pull/27151)
Duplicate `#include <utility>` is upsetting the linter.
👍 theStack approved a pull request: "util: Remove duplicate include"
(https://github.com/bitcoin/bitcoin/pull/27151)
ACK e8462690a9ff0b4155c31981fd97be16663ebb35
👍 john-moffett approved a pull request: "util: Remove duplicate include"
(https://github.com/bitcoin/bitcoin/pull/27151)
ACK e8462690a9ff0b4155c31981fd97be16663ebb35
⚠️ orenyomtov opened an issue: "Add support for sighash flags in PSBT (like SINGLE|ANYONECANPAY)"
(https://github.com/bitcoin-core/gui/issues/712)
**Is your feature request related to a problem? Please describe.**
When using Bitcoin Core's GUI to sign a PSBT that has a UTXO with `sighash=SINGLE|ANYONECANPAY`, it throws following error:
```
Specified sighash value does not match value stored in PSBT
```

**Describe the solution you'd like**
I'd like it to successfully sign PSBTs containing `sighash=SINGLE|ANYONECANPAY`

**Describe alternatives you've considered**
The current non-idea workaround is to use the console window as desc
...
💬 jarolrod commented on pull request "Deduplicate bitcoind and bitcoin-qt init code":
(https://github.com/bitcoin/bitcoin/pull/27150#issuecomment-1442770016)
concept ack
💬 fanquake commented on pull request "Deduplicate bitcoind and bitcoin-qt init code":
(https://github.com/bitcoin/bitcoin/pull/27150#issuecomment-1443202476)
Concept ACK - #27073 has now been merged.
🚀 fanquake merged a pull request: "util: Remove duplicate include"
(https://github.com/bitcoin/bitcoin/pull/27151)
💬 hebasto commented on pull request "Deduplicate bitcoind and bitcoin-qt init code":
(https://github.com/bitcoin/bitcoin/pull/27150#issuecomment-1443297209)
Concept ACK.
⚠️ fanquake opened an issue: "interpreter: split PrecomputedTransactionData::Init() or rename `force`"
(https://github.com/bitcoin/bitcoin/issues/27152)
Potential followup from https://github.com/bitcoin/bitcoin/pull/27122#pullrequestreview-1307630323:

> I do wonder if it makes sense to rename force to something like signing_context or even more drastically split Init up into two obvious types ConsensusInit/SigningInit to make things clearer to future readers.

Seems like there might also be scope to make some of the `Init()` inline commentary clearer, given other review comments in #27122.

cc @instagibbs @ajtowns @roconnor-blockstream.
...
📝 fanquake opened a pull request: "guix: pass `--enable-initfini-array` to release GCC"
(https://github.com/bitcoin/bitcoin/pull/27153)
This returns us to pre-Guix behaviour, where the compilers we were using to build releases, were configured with this option.
🚀 glozow merged a pull request: "Remove MarcoFalke fingerprint, update trusted-git-root"
(https://github.com/bitcoin/bitcoin/pull/27135)
💬 MarcoFalke commented on issue "test: p2p_message_capture.py fails with undefined sanitizer":
(https://github.com/bitcoin/bitcoin/issues/27149#issuecomment-1443500021)
Closing for now. Let us know if this is still an issue with the suppressions file.

The doc questions should be handled in 17834
MarcoFalke closed an issue: "test: p2p_message_capture.py fails with undefined sanitizer"
(https://github.com/bitcoin/bitcoin/issues/27149)
💬 fanquake commented on issue "[POC] [RFC] build: Separate GUI application build system":
(https://github.com/bitcoin/bitcoin/issues/24911#issuecomment-1443520838)
Closing for now, as I don't think there is anything actionable here. We aren't going to add new dependencies any time soon, if ever, and we aren't going to shuffle code/directories around (the linked branch) in this repository to facilitate easier rebasing in an experimental gui-fork.
fanquake closed an issue: "[POC] [RFC] build: Separate GUI application build system"
(https://github.com/bitcoin/bitcoin/issues/24911)
💬 fanquake commented on issue "Add support for all networks in `deserialize_v2` in test_framework":
(https://github.com/bitcoin/bitcoin/issues/27140#issuecomment-1443528191)
Can probably just be done when some code is added that would actually use the functionality? Going to close this for now.
fanquake closed an issue: "Add support for all networks in `deserialize_v2` in test_framework"
(https://github.com/bitcoin/bitcoin/issues/27140)
💬 fanquake commented on issue "Bitcoin Core very slow sync":
(https://github.com/bitcoin/bitcoin/issues/27134#issuecomment-1443531666)
> My computer is about 6 years old.

What sort of harddrive do you have?

Going to close for now in any case. It's not possible for us to debug this, or provide any suggestions until you provide further information. Can be reopened if that happens.