💬 TheCharlatan commented on pull request "Fix various libbitcoinkernel DLL build problems":
(https://github.com/bitcoin/bitcoin/pull/27146#issuecomment-1442433720)
ACK 5da7c0b3e34626ca57d1f0773db61e7d8351d8c7

💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#issuecomment-1442450925)
> in the very unlikely scenario that everyone likes this connection and all bitcoin nodes on tor connect with clearnet only using this option - that wouldn't be good for the network right? (assuming an average tor user wouldn’t want their addresses/transactions relayed to their clearnet peers)

We'd need enough inbound capacity on clearnet to accomodate the additional manual connections to it, and also some users relaying transactions on both networks, otherwise txns submitted through tor woul
...

💬 achow101 commented on pull request "Implement Mini version of BlockAssembler to calculate mining scores":
(https://github.com/bitcoin/bitcoin/pull/27021#issuecomment-1442452427)
ACK ce882ef0cf338d390733dd85e339a1c0da73072c

📝 ryanofsky opened a pull request: "Deduplicate bitcoind and bitcoin-qt init code"
(https://github.com/bitcoin/bitcoin/pull/27150)
Add common `InitConfig` function to deduplicate `bitcoind` and `bitcoin-qt` code parsing the config file, creating the datadir, and selecting the network.

Noticed the duplicate code while reviewing #27073 and want to remove it because difference in bitcoin-qt and bitcoind behavior make it hard to evaluate changes like #27073

There is a slight change of behavior for `bitcoin-qt`: When there is a problem reading the configuration file, the error prefix is changed from "Error: Cannot parse co
...

💬 ryanofsky commented on pull request "Deduplicate bitcoind and bitcoin-qt init code":
(https://github.com/bitcoin/bitcoin/pull/27150#issuecomment-1442453898)
Leaving as draft because #27073 could be merged first, and if it is more duplicate code can be moved to the common function.

👍 furszy approved a pull request: "prune: scan and unlink already pruned block files on startup"
(https://github.com/bitcoin/bitcoin/pull/26533)
Code review ACK 3141eab9
Left a non-blocking nit. No need to do it.

💬 furszy commented on pull request "prune: scan and unlink already pruned block files on startup":
(https://github.com/bitcoin/bitcoin/pull/26533#discussion_r1116165449)
nit: could make use of the std::error_code:
e.g.
```c++
else {
LogPrint(BCLog::BLOCKSTORE, "Prune: failed to removed block/undo file, error %s", ec.message());
}
```

💬 achow101 commented on pull request "Convert ArgsManager::GetDataDir to a read-only function":
(https://github.com/bitcoin/bitcoin/pull/27073#issuecomment-1442456504)
ACK 64c105442ce8c10900ea6fbecdbcfebe42f2d387

👍 ryanofsky approved a pull request: "Convert ArgsManager::GetDataDir to a read-only function"
(https://github.com/bitcoin/bitcoin/pull/27073)
Code review ACK 64c105442ce8c10900ea6fbecdbcfebe42f2d387. Only comment changes since last review

✅ achow101 closed an issue: "bitcoin-cli needlessly creates empty ~/.bitcoin/wallets directory"
(https://github.com/bitcoin/bitcoin/issues/20070)

🚀 achow101 merged a pull request: "Convert ArgsManager::GetDataDir to a read-only function"
(https://github.com/bitcoin/bitcoin/pull/27073)

💬 TheCharlatan commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#issuecomment-1442521535)
Rebased.

📝 achow101 opened a pull request: "util: Remove duplicate include"
(https://github.com/bitcoin/bitcoin/pull/27151)
Duplicate `#include <utility>` is upsetting the linter.

👍 theStack approved a pull request: "util: Remove duplicate include"
(https://github.com/bitcoin/bitcoin/pull/27151)
ACK e8462690a9ff0b4155c31981fd97be16663ebb35

👍 john-moffett approved a pull request: "util: Remove duplicate include"
(https://github.com/bitcoin/bitcoin/pull/27151)
ACK e8462690a9ff0b4155c31981fd97be16663ebb35

⚠️ orenyomtov opened an issue: "Add support for sighash flags in PSBT (like SINGLE|ANYONECANPAY)"
(https://github.com/bitcoin-core/gui/issues/712)
**Is your feature request related to a problem? Please describe.**
When using Bitcoin Core's GUI to sign a PSBT that has a UTXO with `sighash=SINGLE|ANYONECANPAY`, it throws following error:
```
Specified sighash value does not match value stored in PSBT
```

**Describe the solution you'd like**
I'd like it to successfully sign PSBTs containing `sighash=SINGLE|ANYONECANPAY`

**Describe alternatives you've considered**
The current non-idea workaround is to use the console window as desc
...

💬 jarolrod commented on pull request "Deduplicate bitcoind and bitcoin-qt init code":
(https://github.com/bitcoin/bitcoin/pull/27150#issuecomment-1442770016)
concept ack

💬 davidgumberg commented on pull request "util: Remove duplicate include":
(https://github.com/bitcoin/bitcoin/pull/27151#issuecomment-1442845959)
ACK https://github.com/bitcoin/bitcoin/pull/27151/commits/e8462690a9ff0b4155c31981fd97be16663ebb35

💬 fanquake commented on pull request "Deduplicate bitcoind and bitcoin-qt init code":
(https://github.com/bitcoin/bitcoin/pull/27150#issuecomment-1443202476)
Concept ACK - #27073 has now been merged.

🚀 fanquake merged a pull request: "util: Remove duplicate include"
(https://github.com/bitcoin/bitcoin/pull/27151)