💬 MarcoFalke commented on pull request "rpc: Add Arg() default helper":
(https://github.com/bitcoin/bitcoin/pull/28230#discussion_r1297075358)
I don't like macros, so I'll leave as-is for now, because my version has less lines of code inside a macro

💬 MarcoFalke commented on pull request "rpc: Add Arg() default helper":
(https://github.com/bitcoin/bitcoin/pull/28230#discussion_r1297087713)
thx, fixed

💬 MarcoFalke commented on pull request "rpc: Add Arg() default helper":
(https://github.com/bitcoin/bitcoin/pull/28230#discussion_r1297088104)
thx, I changed the doc a bit.

💬 MarcoFalke commented on pull request "ci: Ensure that only a single workflow processes `github.ref` at a time":
(https://github.com/bitcoin/bitcoin/pull/28282#issuecomment-1682133874)
Could do the same in the secp repo?

💬 naumenkogs commented on pull request "Fix potential network stalling bug":
(https://github.com/bitcoin/bitcoin/pull/27981#issuecomment-1682148113)
ACK 3388e523a129ad9c7aef418c9f57491f8c2d9df8

🚀 fanquake merged a pull request: "Break up script/standard.{h/cpp}"
(https://github.com/bitcoin/bitcoin/pull/28244)

💬 MarcoFalke commented on pull request "ci: Run "macOS native x86_64" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28187#discussion_r1297114440)
Done in https://github.com/bitcoin/bitcoin/pull/28278

💬 naumenkogs commented on pull request "p2p: adaptive connections services flags":
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1297115636)
Was it just outdated already? I'm confused by what NODE_NONE meant here before this change.

💬 naumenkogs commented on pull request "p2p: adaptive connections services flags":
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1297117898)
does `peerServices` refer to the outdated code? Pehraps we should change it here?

💬 dergoegge commented on pull request "ci: Run "macOS 11.0 [gui, no tests] [jammy]" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28265#issuecomment-1682170413)
Any reason to not run this on a self-hosted worker through cirrus? I thought we only wanted to convert to GHA where nobody is willing to self host e.g. the native macOS jobs.

👍 dergoegge approved a pull request: "ci: Ensure that only a single workflow processes `github.ref` at a time"
(https://github.com/bitcoin/bitcoin/pull/28282#pullrequestreview-1582471767)
utACK 0080b5650e0bf125612e62b591f348076e9ad5d7

💬 dergoegge commented on pull request "ci: Add test-each-commit task":
(https://github.com/bitcoin/bitcoin/pull/28279#issuecomment-1682173028)
This would be a cirrus self-hosted worker though, right?

💬 naumenkogs commented on pull request "p2p: adaptive connections services flags":
(https://github.com/bitcoin/bitcoin/pull/28170#discussion_r1297132683)
What do you think they would help with?

💬 fanquake commented on pull request "Fix potential network stalling bug":
(https://github.com/bitcoin/bitcoin/pull/27981#issuecomment-1682180623)
We can follow up with the suggestions / changes:

> [If you want, feel free to include the commits from 202208_test_sendmsg - alternatively, if you'd prefer not to deal with test / rpc feedback here, I'd also be happy to open a separate PR that builds on this branch.](https://github.com/bitcoin/bitcoin/pull/27981#pullrequestreview-1579515115)

> [For your consideration: https://github.com/ajtowns/bitcoin/commit/87c509c6d6ee0d355d08e0d4bc60bc01d4a0ad60 . I expanded the WITH_LOCK out](https://
...

🚀 fanquake merged a pull request: "Fix potential network stalling bug"
(https://github.com/bitcoin/bitcoin/pull/27981)

💬 MarcoFalke commented on pull request "ci: Run "macOS 11.0 [gui, no tests] [jammy]" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28265#issuecomment-1682182628)
> Any reason to not run this on a self-hosted worker through cirrus?

Self-hosted workers have downsides. For example, they need to be set-up for every fork in a different org, before the CI can be run. But GHA also has downsides. For example, tasks can not be re-run by authors, unless they (force-)push.

And the qml repo needs GHA artefacts?

My suggestion for now would be to use Cirrus self-hosted workers. The qml repo can cherry-pick this pull request in the meantime, until the cache is
...

💬 dergoegge commented on pull request "ci: Run "macOS 11.0 [gui, no tests] [jammy]" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28265#issuecomment-1682184753)
> My suggestion for now would be to use Cirrus self-hosted workers. The qml repo can cherry-pick this pull request in the meantime, until the cache issue is fixed one way or another.

Sounds good to me. I don't think we should have a dependency on the experimental gui rewrite in this repo.

💬 fanquake commented on pull request "ci: Run "macOS 11.0 [gui, no tests] [jammy]" job on GitHub Actions":
(https://github.com/bitcoin/bitcoin/pull/28265#issuecomment-1682191325)
I agree. The requirements of a separate (experimental) repository are not really our concern when making CI infrastructure decisions.

✅ fanquake closed an issue: "Intermittent failure in mining_getblocktemplate_longpoll.py"
(https://github.com/bitcoin/bitcoin/issues/26962)

🚀 fanquake merged a pull request: "test: Fix intermittent issue in mining_getblocktemplate_longpoll.py"
(https://github.com/bitcoin/bitcoin/pull/27941)