💬 jamesob commented on pull request "assumeutxo: background validation completion":
(https://github.com/bitcoin/bitcoin/pull/25740#discussion_r1114710206)
Fixed.

💬 jamesob commented on pull request "assumeutxo: background validation completion":
(https://github.com/bitcoin/bitcoin/pull/25740#discussion_r1114710366)
Good for a follow-up.

💬 jamesob commented on pull request "assumeutxo: background validation completion":
(https://github.com/bitcoin/bitcoin/pull/25740#discussion_r1114711271)
Fixed.

🚀 fanquake merged a pull request: "test: Raise PRNG seed log to INFO"
(https://github.com/bitcoin/bitcoin/pull/27137)

💬 fanquake commented on pull request "I2P network optimizations":
(https://github.com/bitcoin/bitcoin/pull/26837#issuecomment-1440513934)
> In light of https://github.com/bitcoin/bitcoin/issues/26754#issuecomment-1435700510 it seems that backport may not be that urgent anymore.

Yea, that does seem the case (no urgency), however I think pulling these into `24.x` is still worthwhile. I'll add the changes here to #26878 shortly.

🚀 fanquake merged a pull request: "I2P network optimizations"
(https://github.com/bitcoin/bitcoin/pull/26837)

💬 fanquake commented on issue "I2P: Limit transient addresses":
(https://github.com/bitcoin/bitcoin/issues/26754#issuecomment-1440516470)
Closing this post #26837.

✅ fanquake closed an issue: "I2P: Limit transient addresses"
(https://github.com/bitcoin/bitcoin/issues/26754)

👍 fanquake approved a pull request: "kernel: add missing include"
(https://github.com/bitcoin/bitcoin/pull/27144)
ACK 49d01f32c9cc4de4fcd0d1f235e2c62e4acfc7a2

💬 jonatack commented on pull request "docs: add ramdisk guide for running tests on OSX":
(https://github.com/bitcoin/bitcoin/pull/27124#discussion_r1114729129)
Am I understanding this correctly?
```suggestion
Configure the RAM size, expressed as the number of blocks, at the end of the command
```

Also, if you retouch, s/ram/RAM/ in this line:

```markdown
Once finished with the tests and the disk, and to free the ram, simply unmount the disk:
```

🚀 fanquake merged a pull request: "kernel: add missing include"
(https://github.com/bitcoin/bitcoin/pull/27144)

✅ achow101 closed an issue: "Wallet passphrases silently ignore everything after a null character"
(https://github.com/bitcoin/bitcoin/issues/27067)

🚀 achow101 merged a pull request: "wallet: SecureString to allow null characters"
(https://github.com/bitcoin/bitcoin/pull/27068)

💬 pinheadmz commented on pull request "docs: add ramdisk guide for running tests on OSX":
(https://github.com/bitcoin/bitcoin/pull/27124#discussion_r1114734924)
great, both updated

🚀 fanquake merged a pull request: "test: Replace 0xC0 constant"
(https://github.com/bitcoin/bitcoin/pull/27143)

👍 ryanofsky approved a pull request: "Convert ArgsManager::GetDataDir to a read-only function"
(https://github.com/bitcoin/bitcoin/pull/27073)
Code review ACK 0af17e161d751b15f90615800411f36e11b3fcde. Nice change that makes initialization more straightforward and gets rid of strange behavior. Only change since last review is adding a comment. I left some small suggestions, but they are not important.

---

I think part of the PR description https://github.com/bitcoin/bitcoin/pull/27073#issue-1579684533 is inaccurate.

> As part of the refactoring it introduces a slight behaviour change to `GetConfigFilePath`, which now always ret
...

💬 ryanofsky commented on pull request "Convert ArgsManager::GetDataDir to a read-only function":
(https://github.com/bitcoin/bitcoin/pull/27073#discussion_r1114423128)
In commit "util: make GetDataDir read-only & create datadir.." (0af17e161d751b15f90615800411f36e11b3fcde)

Would be good to move this comment from the `EnsureDataDir` declaration to the `EnsureDataDir` implementation. The comment is trying to explain the confusing `create_directories("wallets")` calls there, so probably more helpful next to those calls.

It would be good to have API documentation for the two new functions though. I would move the function descriptions you wrong in the commit
...

💬 jonatack commented on pull request "I2P network optimizations":
(https://github.com/bitcoin/bitcoin/pull/26837#issuecomment-1440556067)
> I'm still seeing the issue I reported with i2pd version 2.45.1 (0.9.57).

No longer seeing the previously daily issue since a few days with i2pd version 2.46.0 and 2.46.1.

💬 achow101 commented on pull request "assumeutxo: background validation completion":
(https://github.com/bitcoin/bitcoin/pull/25740#issuecomment-1440601441)
re-ACK a00d0e78510d79bc9fc57ec622aec98a65efa8c0

👍 brunoerg approved a pull request: "docs: add ramdisk guide for running tests on OSX"
(https://github.com/bitcoin/bitcoin/pull/27124)
utACK 2f84ad7b9e62dd710940c2f265b65973b94864d7