👍 willcl-ark approved a pull request: "docs: add ramdisk guide for running tests on OSX"
(https://github.com/bitcoin/bitcoin/pull/27124)
ACK cb7be3a237c7e5a3d09f24259be015557dc72bca
Tested on my Macbook, worked as expected and speeded up the test suite noticeably.
(https://github.com/bitcoin/bitcoin/pull/27124)
ACK cb7be3a237c7e5a3d09f24259be015557dc72bca
Tested on my Macbook, worked as expected and speeded up the test suite noticeably.
💬 jamesob commented on pull request "assumeutxo: keep cache when flushing snapshot (#17487 followup)":
(https://github.com/bitcoin/bitcoin/pull/27008#discussion_r1114659889)
Sounds good, fixed.
(https://github.com/bitcoin/bitcoin/pull/27008#discussion_r1114659889)
Sounds good, fixed.
💬 jamesob commented on pull request "assumeutxo: keep cache when flushing snapshot (#17487 followup)":
(https://github.com/bitcoin/bitcoin/pull/27008#discussion_r1114653412)
Good point! Fixed.
(https://github.com/bitcoin/bitcoin/pull/27008#discussion_r1114653412)
Good point! Fixed.
💬 achow101 commented on pull request "prune, import: allow pruning to work during loadblock import":
(https://github.com/bitcoin/bitcoin/pull/24957#issuecomment-1440481217)
re-ACK c4981e7f63a3e0aeec1ef3dec040261e993dd724
(https://github.com/bitcoin/bitcoin/pull/24957#issuecomment-1440481217)
re-ACK c4981e7f63a3e0aeec1ef3dec040261e993dd724
💬 jamesob commented on pull request "assumeutxo: background validation completion":
(https://github.com/bitcoin/bitcoin/pull/25740#discussion_r1114701299)
For what it's worth, in future PRs I think this possibility is eliminated, since calls like `ActiveChainstate().ActivateBestChain()` in ProcessNewBlock are replaced with specific chainstate references.
(https://github.com/bitcoin/bitcoin/pull/25740#discussion_r1114701299)
For what it's worth, in future PRs I think this possibility is eliminated, since calls like `ActiveChainstate().ActivateBestChain()` in ProcessNewBlock are replaced with specific chainstate references.
✅ fanquake closed an issue: "migratewallet help is misleading about encrypted wallets"
(https://github.com/bitcoin/bitcoin/issues/27048)
(https://github.com/bitcoin/bitcoin/issues/27048)
🚀 fanquake merged a pull request: "wallet: be able to specify a wallet name and passphrase to migratewallet"
(https://github.com/bitcoin/bitcoin/pull/26595)
(https://github.com/bitcoin/bitcoin/pull/26595)
👍 theStack approved a pull request: "test: Replace 0xC0 constant"
(https://github.com/bitcoin/bitcoin/pull/27143)
ACK c3b4b5a142b204ceeca4e9b1ca1e2ff41ddd1308
(https://github.com/bitcoin/bitcoin/pull/27143)
ACK c3b4b5a142b204ceeca4e9b1ca1e2ff41ddd1308
💬 jamesob commented on pull request "assumeutxo: background validation completion":
(https://github.com/bitcoin/bitcoin/pull/25740#issuecomment-1440503591)
Rebased and reworded the commit message that @achow101 pointed out was out of date. Also fixed two minor items that @ariard noted.
In attempt to encourage re-ACKers, here is the diff (including rebase items):
```diff
diff <(git diff --no-color au.complete.10~9..au.complete.10) <(git diff --no-color au.complete.11~9..au.complete.11)
109c109
< index 60acb614b4..d36184fed7 100644
---
> index ba1024d22e..cd82d8743c 100644
138c138
< - if (nPruneTarget == std::numeric_limits<uint64_t>:
...
(https://github.com/bitcoin/bitcoin/pull/25740#issuecomment-1440503591)
Rebased and reworded the commit message that @achow101 pointed out was out of date. Also fixed two minor items that @ariard noted.
In attempt to encourage re-ACKers, here is the diff (including rebase items):
```diff
diff <(git diff --no-color au.complete.10~9..au.complete.10) <(git diff --no-color au.complete.11~9..au.complete.11)
109c109
< index 60acb614b4..d36184fed7 100644
---
> index ba1024d22e..cd82d8743c 100644
138c138
< - if (nPruneTarget == std::numeric_limits<uint64_t>:
...
💬 jamesob commented on pull request "assumeutxo: background validation completion":
(https://github.com/bitcoin/bitcoin/pull/25740#discussion_r1114711213)
Fixed.
(https://github.com/bitcoin/bitcoin/pull/25740#discussion_r1114711213)
Fixed.
💬 jamesob commented on pull request "assumeutxo: background validation completion":
(https://github.com/bitcoin/bitcoin/pull/25740#discussion_r1114710206)
Fixed.
(https://github.com/bitcoin/bitcoin/pull/25740#discussion_r1114710206)
Fixed.
💬 jamesob commented on pull request "assumeutxo: background validation completion":
(https://github.com/bitcoin/bitcoin/pull/25740#discussion_r1114710366)
Good for a follow-up.
(https://github.com/bitcoin/bitcoin/pull/25740#discussion_r1114710366)
Good for a follow-up.
💬 jamesob commented on pull request "assumeutxo: background validation completion":
(https://github.com/bitcoin/bitcoin/pull/25740#discussion_r1114711271)
Fixed.
(https://github.com/bitcoin/bitcoin/pull/25740#discussion_r1114711271)
Fixed.
🚀 fanquake merged a pull request: "test: Raise PRNG seed log to INFO"
(https://github.com/bitcoin/bitcoin/pull/27137)
(https://github.com/bitcoin/bitcoin/pull/27137)
💬 fanquake commented on pull request "I2P network optimizations":
(https://github.com/bitcoin/bitcoin/pull/26837#issuecomment-1440513934)
> In light of https://github.com/bitcoin/bitcoin/issues/26754#issuecomment-1435700510 it seems that backport may not be that urgent anymore.
Yea, that does seem the case (no urgency), however I think pulling these into `24.x` is still worthwhile. I'll add the changes here to #26878 shortly.
(https://github.com/bitcoin/bitcoin/pull/26837#issuecomment-1440513934)
> In light of https://github.com/bitcoin/bitcoin/issues/26754#issuecomment-1435700510 it seems that backport may not be that urgent anymore.
Yea, that does seem the case (no urgency), however I think pulling these into `24.x` is still worthwhile. I'll add the changes here to #26878 shortly.
🚀 fanquake merged a pull request: "I2P network optimizations"
(https://github.com/bitcoin/bitcoin/pull/26837)
(https://github.com/bitcoin/bitcoin/pull/26837)
💬 fanquake commented on issue "I2P: Limit transient addresses":
(https://github.com/bitcoin/bitcoin/issues/26754#issuecomment-1440516470)
Closing this post #26837.
(https://github.com/bitcoin/bitcoin/issues/26754#issuecomment-1440516470)
Closing this post #26837.
✅ fanquake closed an issue: "I2P: Limit transient addresses"
(https://github.com/bitcoin/bitcoin/issues/26754)
(https://github.com/bitcoin/bitcoin/issues/26754)
👍 fanquake approved a pull request: "kernel: add missing include"
(https://github.com/bitcoin/bitcoin/pull/27144)
ACK 49d01f32c9cc4de4fcd0d1f235e2c62e4acfc7a2
(https://github.com/bitcoin/bitcoin/pull/27144)
ACK 49d01f32c9cc4de4fcd0d1f235e2c62e4acfc7a2
💬 jonatack commented on pull request "docs: add ramdisk guide for running tests on OSX":
(https://github.com/bitcoin/bitcoin/pull/27124#discussion_r1114729129)
Am I understanding this correctly?
```suggestion
Configure the RAM size, expressed as the number of blocks, at the end of the command
```
Also, if you retouch, s/ram/RAM/ in this line:
```markdown
Once finished with the tests and the disk, and to free the ram, simply unmount the disk:
```
(https://github.com/bitcoin/bitcoin/pull/27124#discussion_r1114729129)
Am I understanding this correctly?
```suggestion
Configure the RAM size, expressed as the number of blocks, at the end of the command
```
Also, if you retouch, s/ram/RAM/ in this line:
```markdown
Once finished with the tests and the disk, and to free the ram, simply unmount the disk:
```