💬 stratospher commented on pull request "rpc: Add test-only RPC addrmaninfo for new/tried table address count":
(https://github.com/bitcoin/bitcoin/pull/26988#discussion_r1114100137)
true, i've updated the PR to call it `getaddrmaninfo`.

💬 mruddy commented on pull request "prune, import: allow pruning to work during loadblock import":
(https://github.com/bitcoin/bitcoin/pull/24957#issuecomment-1439781853)
@achow101 Thanks! I rebased and then resolved the silent merge conflict by changing `fPruneMode` to `m_blockman.IsPruneMode()`.

⚠️ vincenzopalazzo opened an issue: "core stops to run with `Failed to read block` error"
(https://github.com/bitcoin/bitcoin/issues/27142)
**Expected behavior**

While my node was running it get an internal failure that force it to stop the running

```
2023-02-21T23:29:22Z Syncing basic block filter index with block chain from height 624447
2023-02-21T23:29:34Z ERROR: SerializeFileDB: Rename-into-place failed
2023-02-21T23:29:52Z Syncing basic block filter index with block chain from height 624889
2023-02-21T23:30:22Z ERROR: ReadBlockFromDisk: Deserialize or I/O error - ReadCompactSize(): size too large: iostream error at
...

💬 Sjors commented on pull request "contrib: Improve verify-commits.py to work with maintainers leaving":
(https://github.com/bitcoin/bitcoin/pull/27058#issuecomment-1439845151)
ACK 14fac808bd6c12bce121011bbf50501960c7326f

💬 willcl-ark commented on issue "core stops to run with `Failed to read block` error":
(https://github.com/bitcoin/bitcoin/issues/27142#issuecomment-1439872146)
We do not currently propagate the exact error code raised by `fs::rename` so it might be difficult to diagnose precisely... The most usual cases are the filesystem being full or corrupt. Are you sure your filesystem has enough free space?

Seeing as it later hit the ReadCompactSize deserialize error afterwards, it does feel more likely to be a fs corruption issue...

👍 MarcoFalke approved a pull request: "validation: Improve error handling when VerifyDB dosn't finish successfully"
(https://github.com/bitcoin/bitcoin/pull/25574)
lgtm re-ACK 0af16e7134459e0820ab95d751093876c1ec4c6d 🎚

<details><summary>Show signature</summary>

Signature:

```
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

lgtm re-ACK 0af16e7134459e0820ab95d751093876c1ec4c6d 🎚
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUgCEAwAl2HOYuqTfTHatbl1G6IC16Itmtb0chf3GhxESu4SIE7uNvMXIXVK2WG1
k5Sz9TeW2POSCwZnJtxdAzhNKwzN6Q79yJ0KL+6SOMxX7j4CaWun5b1kJf1xOlQx
gHBqBN1zLW65Wfh1L3qa4nzKiWwKdJJ2iUAU
...

💬 MarcoFalke commented on pull request "validation: Improve error handling when VerifyDB dosn't finish successfully":
(https://github.com/bitcoin/bitcoin/pull/25574#discussion_r1114212689)
nit in d6f781f1cfcbc2c2ad5ee289a0642ed00386d013 (commit message), only if you retouch:

I think the rpc is called `verifychain` and not `-verifydb`?

💬 brunoerg commented on pull request "rpc: Add test-only RPC getaddrmaninfo for new/tried table address count":
(https://github.com/bitcoin/bitcoin/pull/26988#discussion_r1114224820)
You could cover this error in the functional test

💬 vincenzopalazzo commented on issue "core stops to run with `Failed to read block` error":
(https://github.com/bitcoin/bitcoin/issues/27142#issuecomment-1439927671)
>The most usual cases are the filesystem being full or corrupt. Are you sure your filesystem has enough free space?

Yes 100%

```
/dev/sdb1 4883759996 2603409780 2280350216 54% /media/Matrox
```

>Seeing as it later hit the ReadCompactSize deserialize error afterward, it does feel more likely to be an fs corruption issue...

The stage thing is that this is running for days, so I did not get any downside that can end up in something half written or just put the trash inside the .
...

✅ 1440000bytes closed a pull request: "[WIP] doc: add MAINTAINERS.md"
(https://github.com/bitcoin/bitcoin/pull/26868)

👍 stickies-v approved a pull request: "docs: add ramdisk guide for running tests on OSX"
(https://github.com/bitcoin/bitcoin/pull/27124)
ACK ab6f73a1f65bcfd59fea07f3067312a757dba2f8

I use this command on my M1 too.

💬 stickies-v commented on pull request "docs: add ramdisk guide for running tests on OSX":
(https://github.com/bitcoin/bitcoin/pull/27124#discussion_r1114256522)
nit: I think the formula can be expressed a bit more useable like this:
```suggestion
(`4096 MiB * 2048 blocks/MiB = 8388608 blocks` for 4GiB). To run the tests using the RAM disk:
```

💬 TheCharlatan commented on issue "`libbitcoinkernel`: Building `mingw-w64` dll's broken":
(https://github.com/bitcoin/bitcoin/issues/25008#issuecomment-1439953266)
> Mind testing https://github.com/theuni/bitcoin/commits/fix-dll-exports ? I'll PR if it works for you.

Mmh, I'm surprised that secp needs to be linked as well by the final binary and I'm not quite following why. What's different between the visibility of say linking leveldb and linking libsecp in libbitcoinkernel so these symbols end up undefined in the bitcoin-chainstate binary?

👍 TheCharlatan approved a pull request: "rpc, test: remove newline escape sequence from wallet warning fields"
(https://github.com/bitcoin/bitcoin/pull/27138)
ACK f0391cd3ea562d526db63996e7694ff4cd44b8b2

Was a bit hesitant about adding the messages to the functional tests, but I think testing the correct concatenation kind of makes sense.

💬 Sjors commented on pull request "wallet: skip R-value signature grinding for external signers":
(https://github.com/bitcoin/bitcoin/pull/26032#issuecomment-1439968821)
I considered switching to @S3RK's approach of adding extra argument to `DummySignInput` rather than expanding `CCoinControl`. The result is here: https://github.com/Sjors/bitcoin/tree/2023/02/external-signer-feerate-leave-ccoincontrol-alone

The downside of this is approach is that I had to sprinkle `const bool can_grind_r = !wallet->IsWalletFlagSet(WALLET_FLAG_EXTERNAL_SIGNER);` in several different places. This is fine right now, but at some point we might have some external signers that do
...

💬 brunoerg commented on pull request "rpc: Add test-only RPC getaddrmaninfo for new/tried table address count":
(https://github.com/bitcoin/bitcoin/pull/26988#issuecomment-1440011972)
```sh
"network" : "str", (string) The network (ipv4, ipv6, onion, i2p, cjdns)
```

Instead of being a string, wouldn't make sense it to be an array? E.g. I want to get new/tried table address count for ipv5 and ipv6 together.

👍 theStack approved a pull request: "test: Raise PRNG seed log to INFO"
(https://github.com/bitcoin/bitcoin/pull/27137)
ACK 4d84eaec82e7b5a450d47cd30e5936a717035f77

📝 roconnor-blockstream opened a pull request: "test: Replace 0xC0 constant"
(https://github.com/bitcoin/bitcoin/pull/27143)
Instead it should be the named constant `LEAF_VERSION_TAPSCRIPT`.

💬 instagibbs commented on pull request "test: Replace 0xC0 constant":
(https://github.com/bitcoin/bitcoin/pull/27143#issuecomment-1440091525)
Since we're already here, we could replace the rest of the instances of this variable too?

💬 roconnor-blockstream commented on pull request "test: Replace 0xC0 constant":
(https://github.com/bitcoin/bitcoin/pull/27143#issuecomment-1440101100)
I am not aware of other instances.