💬 achow101 commented on pull request "contrib: Improve verify-commits.py to work with maintainers leaving":
(https://github.com/bitcoin/bitcoin/pull/27058#discussion_r1113610957)
I think it is reasonable to require that. I'm sure the people who would run this script can figure that out. I'll add a note to the docs.

💬 msgilligan commented on issue "Bech32 address generation in regtest does not have the prefix `tb`":
(https://github.com/bitcoin/bitcoin/issues/12314#issuecomment-1439145203)
Add **bitcoinj** (https://github.com/bitcoinj/bitcoinj) to the list of implementations that use `bcrt`. Please don't change this.

💬 achow101 commented on pull request "Remove MarcoFalke fingerprint, update trusted-git-root":
(https://github.com/bitcoin/bitcoin/pull/27135#issuecomment-1439154380)
ACK fab17f08e24f0db687dc25c5e10eb62293070048

The key removed matches the fingerprint of the key that I have for Marco Falke and is the same that has been used to sign commits.

With the key removed and the new trusted git root, all commits still verify.

⚠️ orenyomtov opened an issue: "Add support for sighash flags in PSBT (like SINGLE|ANYONECANPAY)"
(https://github.com/bitcoin/bitcoin/issues/27141)
**Is your feature request related to a problem? Please describe.**
When using Bitcoin Core's GUI to sign a PSBT that has a UTXO with `sighash=SINGLE|ANYONECANPAY`, it throws following error:
```
Specified sighash value does not match value stored in PSBT
```

**Describe the solution you'd like**
I'd like it to successfully sign PSBTs containing `sighash=SINGLE|ANYONECANPAY`

**Describe alternatives you've considered**
The current non-idea workaround is to use the console window as desc
...

👍 stickies-v approved a pull request: "wallet: SecureString to allow null characters"
(https://github.com/bitcoin/bitcoin/pull/27068)
re-ACK [4bbf5dd](https://github.com/bitcoin/bitcoin/commit/4bbf5ddd44bde15b328be131922123eaa3212a7e)

I verified that the only changes are as per review comments: updated commit title and slight phrasing tweaks to error messages.

💬 1440000bytes commented on issue "Add support for sighash flags in PSBT (like SINGLE|ANYONECANPAY)":
(https://github.com/bitcoin/bitcoin/issues/27141#issuecomment-1439230218)
Concept ACK

However GUI issues and PRs are maintained in https://github.com/bitcoin-core/gui

💬 achow101 commented on pull request "wallet: SecureString to allow null characters":
(https://github.com/bitcoin/bitcoin/pull/27068#issuecomment-1439313694)
re-ACK 4bbf5ddd44bde15b328be131922123eaa3212a7e

💬 S3RK commented on pull request "wallet: group outputs only once, decouple it from Coin Selection":
(https://github.com/bitcoin/bitcoin/pull/25806#discussion_r1113985558)
I believe the separation between positive and mixed group is an implementation detail of particular coin selection algorithms. We can contrast it with `CoinEligibilityFilter` and `OutputType` grouping which are algorithm independent. Therefore I propose to not separate positive outputs at the grouping stage.

Rather filter negative/positive groups as close to the particular coin selection algo as possible, e.g. in `ChooseSelectionResult`. This will significantly simplify the code by removing
...

🚀 fanquake merged a pull request: "lint: enable E722 do not use bare except"
(https://github.com/bitcoin/bitcoin/pull/25867)

🚀 fanquake merged a pull request: "fuzz: avoid redundant dup key checks when creating Miniscript nodes"
(https://github.com/bitcoin/bitcoin/pull/27117)

💬 fanquake commented on pull request "test: Raise PRNG seed log to INFO":
(https://github.com/bitcoin/bitcoin/pull/27137#issuecomment-1439724461)
cc @prusnak @jonasnick @erikarvstedt

👍 prusnak approved a pull request: "test: Raise PRNG seed log to INFO"
(https://github.com/bitcoin/bitcoin/pull/27137)
Concept ACK

💬 MarcoFalke commented on pull request "test: Raise PRNG seed log to INFO":
(https://github.com/bitcoin/bitcoin/pull/27137#issuecomment-1439728952)
lgtm ACK 4d84eaec82e7b5a450d47cd30e5936a717035f77

👍 erikarvstedt approved a pull request: "test: Raise PRNG seed log to INFO"
(https://github.com/bitcoin/bitcoin/pull/27137)
Concept ACK

💬 stratospher commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#issuecomment-1439737580)
> For me, the critical question is still if this opt-in feature will find enough users to justify the added complexity in net - I honestly don't know that, and I wouldn't have a problem closing this for now if people think there isn't enough demand for this use case currently.

if it helps, i found some related issues: (but i don’t know this either)

- there’s an [issue in raspiblitz](https://github.com/rootzoll/raspiblitz/issues/3329) where they talk about wanting to connect their tor node
...

💬 stratospher commented on pull request "rpc: Add test-only RPC addrmaninfo for new/tried table address count":
(https://github.com/bitcoin/bitcoin/pull/26988#discussion_r1114100137)
true, i've updated the PR to call it `getaddrmaninfo`.

💬 mruddy commented on pull request "prune, import: allow pruning to work during loadblock import":
(https://github.com/bitcoin/bitcoin/pull/24957#issuecomment-1439781853)
@achow101 Thanks! I rebased and then resolved the silent merge conflict by changing `fPruneMode` to `m_blockman.IsPruneMode()`.

⚠️ vincenzopalazzo opened an issue: "core stops to run with `Failed to read block` error"
(https://github.com/bitcoin/bitcoin/issues/27142)
**Expected behavior**

While my node was running it get an internal failure that force it to stop the running

```
2023-02-21T23:29:22Z Syncing basic block filter index with block chain from height 624447
2023-02-21T23:29:34Z ERROR: SerializeFileDB: Rename-into-place failed
2023-02-21T23:29:52Z Syncing basic block filter index with block chain from height 624889
2023-02-21T23:30:22Z ERROR: ReadBlockFromDisk: Deserialize or I/O error - ReadCompactSize(): size too large: iostream error at
...

💬 Sjors commented on pull request "contrib: Improve verify-commits.py to work with maintainers leaving":
(https://github.com/bitcoin/bitcoin/pull/27058#issuecomment-1439845151)
ACK 14fac808bd6c12bce121011bbf50501960c7326f

💬 willcl-ark commented on issue "core stops to run with `Failed to read block` error":
(https://github.com/bitcoin/bitcoin/issues/27142#issuecomment-1439872146)
We do not currently propagate the exact error code raised by `fs::rename` so it might be difficult to diagnose precisely... The most usual cases are the filesystem being full or corrupt. Are you sure your filesystem has enough free space?

Seeing as it later hit the ReadCompactSize deserialize error afterwards, it does feel more likely to be a fs corruption issue...