💬 petertodd commented on pull request "Remove arbitrary restrictions on OP_RETURN by default":
(https://github.com/bitcoin/bitcoin/pull/28130#issuecomment-1666512036)
@HenrikJannsen
> Ideas like https://twitter.com/hashtag/ordislow with delaying blocks containing ordinals might be worth considering in more detail. I don't understand why Bitcoin devs are not more engaged in those discussions.
Bitcoin devs haven't engaged with those discussions because #ordislow is a dumb idea that is very unlikely to work; to the extent it does work, it will simply act to further centralize mining. #ordislow is fundamentally an attempt at censorship of blocks (informati
...
(https://github.com/bitcoin/bitcoin/pull/28130#issuecomment-1666512036)
@HenrikJannsen
> Ideas like https://twitter.com/hashtag/ordislow with delaying blocks containing ordinals might be worth considering in more detail. I don't understand why Bitcoin devs are not more engaged in those discussions.
Bitcoin devs haven't engaged with those discussions because #ordislow is a dumb idea that is very unlikely to work; to the extent it does work, it will simply act to further centralize mining. #ordislow is fundamentally an attempt at censorship of blocks (informati
...
💬 petertodd commented on pull request "policy: Enable full-rbf by default":
(https://github.com/bitcoin/bitcoin/pull/28132#issuecomment-1666513527)
> why not focus efforts on reducing the need for Replace by Fee to begin with?
As I and others have explained above in the linked resources, eg https://petertodd.org/2023/fullrbf-multiparty-protocols and https://petertodd.org/2023/why-you-should-run-mempoolfullrbf, it is impossible to eliminate the need for transaction replacement.
(https://github.com/bitcoin/bitcoin/pull/28132#issuecomment-1666513527)
> why not focus efforts on reducing the need for Replace by Fee to begin with?
As I and others have explained above in the linked resources, eg https://petertodd.org/2023/fullrbf-multiparty-protocols and https://petertodd.org/2023/why-you-should-run-mempoolfullrbf, it is impossible to eliminate the need for transaction replacement.
💬 willcl-ark commented on pull request "Use shared_ptr for CNode inside CConnman":
(https://github.com/bitcoin/bitcoin/pull/28222#issuecomment-1666517688)
> Also see #10738
Thanks, I hadn't seen this one before. Will take a look tonight
(https://github.com/bitcoin/bitcoin/pull/28222#issuecomment-1666517688)
> Also see #10738
Thanks, I hadn't seen this one before. Will take a look tonight
💬 luke-jr commented on pull request "Remove arbitrary restrictions on OP_RETURN by default":
(https://github.com/bitcoin/bitcoin/pull/28130#issuecomment-1666522472)
>Allows for including signature by a third party other than that signing the keys controlling the inputs. E.g., service provider.
🚩🚩🚩 Sounds like maybe this is tied to some kind of KYC nonsense?
There shouldn't be a "service provider" to begin with. (And if you really need such a signature, you could put it INSIDE the data which is being hashed.)
>People were putting garbage and "spamming" the blockchain in the past, spamming is rampant currently and I have never ever seen a convinci
...
(https://github.com/bitcoin/bitcoin/pull/28130#issuecomment-1666522472)
>Allows for including signature by a third party other than that signing the keys controlling the inputs. E.g., service provider.
🚩🚩🚩 Sounds like maybe this is tied to some kind of KYC nonsense?
There shouldn't be a "service provider" to begin with. (And if you really need such a signature, you could put it INSIDE the data which is being hashed.)
>People were putting garbage and "spamming" the blockchain in the past, spamming is rampant currently and I have never ever seen a convinci
...
💬 luke-jr commented on pull request "Bech32 LocateErrors "Bech32 string too short" case":
(https://github.com/bitcoin/bitcoin/pull/28160#issuecomment-1666526030)
The new error_locations looks worse/broken...
(https://github.com/bitcoin/bitcoin/pull/28160#issuecomment-1666526030)
The new error_locations looks worse/broken...
💬 luke-jr commented on pull request "refactor: Revert additional univalue check in ParseSighashString":
(https://github.com/bitcoin/bitcoin/pull/28162#discussion_r1285070240)
Might also want to catch it NOT throwing an error when it ought to.
(https://github.com/bitcoin/bitcoin/pull/28162#discussion_r1285070240)
Might also want to catch it NOT throwing an error when it ought to.
💬 luke-jr commented on pull request "script: throw disabled err for op_ver and its variants":
(https://github.com/bitcoin/bitcoin/pull/28169#discussion_r1285070870)
How does OP_VER differ from a non-existent opcode?
(https://github.com/bitcoin/bitcoin/pull/28169#discussion_r1285070870)
How does OP_VER differ from a non-existent opcode?
💬 luke-jr commented on pull request "ParseHDKeypath: support h as hardened marker":
(https://github.com/bitcoin/bitcoin/pull/28192#issuecomment-1666530013)
Seems likely someone somewhere will want to combine two derivation paths, which might use different markers.
(https://github.com/bitcoin/bitcoin/pull/28192#issuecomment-1666530013)
Seems likely someone somewhere will want to combine two derivation paths, which might use different markers.
💬 achow101 commented on pull request "script: throw disabled err for op_ver and its variants":
(https://github.com/bitcoin/bitcoin/pull/28169#discussion_r1285078233)
It's actually defined and exists in documentation.
(https://github.com/bitcoin/bitcoin/pull/28169#discussion_r1285078233)
It's actually defined and exists in documentation.
💬 luke-jr commented on pull request "mempool: Persist with XOR":
(https://github.com/bitcoin/bitcoin/pull/28207#issuecomment-1666541683)
Concept ACK, I don't think we need to concern with external programs reading this. If they do exist, they can adapt easily.
(https://github.com/bitcoin/bitcoin/pull/28207#issuecomment-1666541683)
Concept ACK, I don't think we need to concern with external programs reading this. If they do exist, they can adapt easily.
💬 luke-jr commented on pull request "mempool: Persist with XOR":
(https://github.com/bitcoin/bitcoin/pull/28207#issuecomment-1666541746)
(Although downgrading might be something we want to support?)
(https://github.com/bitcoin/bitcoin/pull/28207#issuecomment-1666541746)
(Although downgrading might be something we want to support?)
💬 luke-jr commented on pull request "Bump python minimum version to 3.9":
(https://github.com/bitcoin/bitcoin/pull/28211#issuecomment-1666542228)
>CentOS Stream also ships with 3.9
Isn't Stream a rolling release? What about RHEL?
(https://github.com/bitcoin/bitcoin/pull/28211#issuecomment-1666542228)
>CentOS Stream also ships with 3.9
Isn't Stream a rolling release? What about RHEL?
💬 BBezaire commented on pull request "Remove arbitrary restrictions on OP_RETURN by default":
(https://github.com/bitcoin/bitcoin/pull/28130#issuecomment-1666543561)
Concept NACK
My node isn't your personal hard drive. It's for financial transactions, period.
We're already forced to store ordinals for free, while miners profit greatly off priority fees. Such a change will only make things worse for node operators, and destroy Bitcoin's credibility as a crypto currency.
This is a slap in the face to everything Satoshi worked towards.
(https://github.com/bitcoin/bitcoin/pull/28130#issuecomment-1666543561)
Concept NACK
My node isn't your personal hard drive. It's for financial transactions, period.
We're already forced to store ordinals for free, while miners profit greatly off priority fees. Such a change will only make things worse for node operators, and destroy Bitcoin's credibility as a crypto currency.
This is a slap in the face to everything Satoshi worked towards.
💬 luke-jr commented on pull request "set `DEFAULT_PERMIT_BAREMULTISIG` to false":
(https://github.com/bitcoin/bitcoin/pull/28217#discussion_r1285087710)
??? this change makes no sense to me. `i` is an `int`, but `IsStandardTx` returns a bool...
(https://github.com/bitcoin/bitcoin/pull/28217#discussion_r1285087710)
??? this change makes no sense to me. `i` is an `int`, but `IsStandardTx` returns a bool...
💬 luke-jr commented on pull request "set `DEFAULT_PERMIT_BAREMULTISIG` to false":
(https://github.com/bitcoin/bitcoin/pull/28217#discussion_r1285087863)
See b90ef78f7ab564fb5948583e7a5b5399f9798301 for how I fixed this in Knots
(https://github.com/bitcoin/bitcoin/pull/28217#discussion_r1285087863)
See b90ef78f7ab564fb5948583e7a5b5399f9798301 for how I fixed this in Knots
💬 jonatack commented on pull request "set `DEFAULT_PERMIT_BAREMULTISIG` to false":
(https://github.com/bitcoin/bitcoin/pull/28217#discussion_r1285088166)
@luke-jr an `int` of 0 is falsey, non-zero is truthy.
(https://github.com/bitcoin/bitcoin/pull/28217#discussion_r1285088166)
@luke-jr an `int` of 0 is falsey, non-zero is truthy.
💬 luke-jr commented on pull request "Libstandardness (edition 2023)":
(https://github.com/bitcoin/bitcoin/pull/28220#issuecomment-1666554027)
Concept NACK.
> Bitcoin Core transaction relay policy.
This is not and should never become a thing. Every node has its own policies, and relying on any specific policy is broken by design.
(https://github.com/bitcoin/bitcoin/pull/28220#issuecomment-1666554027)
Concept NACK.
> Bitcoin Core transaction relay policy.
This is not and should never become a thing. Every node has its own policies, and relying on any specific policy is broken by design.
💬 jonatack commented on pull request "set `DEFAULT_PERMIT_BAREMULTISIG` to false":
(https://github.com/bitcoin/bitcoin/pull/28217#discussion_r1285088823)
> PR updated.
You'll need to squash the updates required for the tests to pass into the same commit as the code change.
(https://github.com/bitcoin/bitcoin/pull/28217#discussion_r1285088823)
> PR updated.
You'll need to squash the updates required for the tests to pass into the same commit as the code change.
💬 zkfrio commented on pull request "Remove arbitrary restrictions on OP_RETURN by default":
(https://github.com/bitcoin/bitcoin/pull/28130#issuecomment-1666560846)
> This is a slap in the face to everything Satoshi worked towards.
I agree Satoshi would never use witness or bare multisig or OP_RETURN. They preferred [coinbase](https://mempool.space/block/000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f). Unfortunately only miners can use it.
(https://github.com/bitcoin/bitcoin/pull/28130#issuecomment-1666560846)
> This is a slap in the face to everything Satoshi worked towards.
I agree Satoshi would never use witness or bare multisig or OP_RETURN. They preferred [coinbase](https://mempool.space/block/000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f). Unfortunately only miners can use it.
💬 itme-brain commented on pull request "Remove arbitrary restrictions on OP_RETURN by default":
(https://github.com/bitcoin/bitcoin/pull/28130#issuecomment-1666561974)
Concept ACK
The limit is nothing more than feel-good policy, people have been circumventing it forever.
Maybe if `OP_RETURN` never had an arbitrary 80 byte limit we would've never gotten JPEGs in tapscripts?
(https://github.com/bitcoin/bitcoin/pull/28130#issuecomment-1666561974)
Concept ACK
The limit is nothing more than feel-good policy, people have been circumventing it forever.
Maybe if `OP_RETURN` never had an arbitrary 80 byte limit we would've never gotten JPEGs in tapscripts?