💬 MarcoFalke commented on issue "Bitcoin Core very slow sync":
(https://github.com/bitcoin/bitcoin/issues/27134#issuecomment-1438098095)
You may be hitting a stalling peer timeout.

Please check your debug.log for possible causes; Alternatively you can upload it here.

You can find the debug.log in your [data dir](https://github.com/bitcoin/bitcoin/blob/master/doc/files.md#data-directory-location).

Please be aware that the debug log might contain personally identifying information.

💬 MarcoFalke commented on pull request "ci: Cache more stuff in the ci images: msan, iwyu, pip, sdks":
(https://github.com/bitcoin/bitcoin/pull/27028#discussion_r1112775788)
Yes, they do the same thing, which is the same as `bash -c "..."` does. I think they should be removed eventually, but for now they aid reviewability (diff moved dimmed zebra)

💬 kouloumos commented on pull request "github: Switch to yaml issue templates":
(https://github.com/bitcoin/bitcoin/pull/27025#discussion_r1112770341)
I think that a good addition here could be some of the usual hints posted in bug investigation comments such as https://github.com/bitcoin/bitcoin/issues/27134#issuecomment-1438098095, which are:
> You can find the debug.log in your [data dir](https://github.com/bitcoin/bitcoin/blob/master/doc/files.md#data-directory-location).
Please be aware that the debug log might contain personally identifying information.

💬 kouloumos commented on pull request "github: Switch to yaml issue templates":
(https://github.com/bitcoin/bitcoin/pull/27025#discussion_r1112784698)
This could also help to avoid scenarios where thousands of lines of pasted logs make the issue harder to read.

💬 MarcoFalke commented on pull request "ci: Cache more stuff in the ci images: msan, iwyu, pip, sdks":
(https://github.com/bitcoin/bitcoin/pull/27028#discussion_r1112784966)
Added comment

💬 TheCharlatan commented on issue "`libbitcoinkernel`: Building `mingw-w64` dll's broken":
(https://github.com/bitcoin/bitcoin/issues/25008#issuecomment-1438134641)
> I believe that https://github.com/theuni/bitcoin/commit/9612f5f0f1e3295065dbd8a0e0f472f8f020bbd9 is the clean/proper fix for us for the issue. We don't want pthreads symbols exported, and that fixes the specific issue.

Also tested this. Has this been PR'ed?

💬 Sjors commented on pull request "doc: recommend brew install python@3.7 (minimum version)":
(https://github.com/bitcoin/bitcoin/pull/27130#issuecomment-1438172307)
@RandyMcMillan maybe make a separate issue about M1 not supporting Python 3.8 (I don't have one, so can't confirm). It's just one of many operating systems we support, but a lot of devs use it so it seems worth looking into.

💬 fanquake commented on pull request "doc: recommend brew install python@3.7 (minimum version)":
(https://github.com/bitcoin/bitcoin/pull/27130#issuecomment-1438183845)
Thanks, but there is no need to make an issue. There is nothing here that needs to be solved.

💬 glozow commented on pull request "github: Switch to yaml issue templates":
(https://github.com/bitcoin/bitcoin/pull/27025#discussion_r1112834694)
Agree this could be an optional "additional info about env or machine" as it could be irrelevant to the issue / confusing. (feel free to ignore as this is just me bikeshedding)

💬 glozow commented on pull request "rpc: Add a parameter to sendrawtransaction which sets a maximum value for unspendable outputs.":
(https://github.com/bitcoin/bitcoin/pull/25943#issuecomment-1438205837)
reACK 7013da07fbcddb04abae9759767a9419ab90444c

🤔 Sjors requested changes to a pull request: "rpc: make importaddress compatible with descriptors wallet"
(https://github.com/bitcoin/bitcoin/pull/27034)
> the legacy spkm creation only happens on blank non-descriptors wallets

I don't think this is true, but maybe I'm reading the code wrong.

💬 Sjors commented on pull request "rpc: make importaddress compatible with descriptors wallet":
(https://github.com/bitcoin/bitcoin/pull/27034#discussion_r1112863513)
Suggested alternative wording that avoids "scriptPubKey manager".

```
For descriptor wallets, this command only works if it has private keys disabled.
It will create a new descriptor/s. Otherwise, use \"importdescriptors\" instead.
```

💬 Sjors commented on pull request "rpc: make importaddress compatible with descriptors wallet":
(https://github.com/bitcoin/bitcoin/pull/27034#discussion_r1112863805)
This sentence can be dropped with my suggestion.

💬 Sjors commented on pull request "rpc: make importaddress compatible with descriptors wallet":
(https://github.com/bitcoin/bitcoin/pull/27034#discussion_r1112871259)
I'm confused: `!use_legacy` means we have a descriptor wallet. We should never create a `LegacyScriptPubKeyMan` in that case. I don't understand what this `if` block is trying to achieve, but I think it should `throw JSONRPCError(RPC_WALLET_ERROR, "Use 'importdescriptors' instead"`

💬 glozow commented on pull request "change txid log format specifier from %i to %s":
(https://github.com/bitcoin/bitcoin/pull/27133#issuecomment-1438282156)
https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#pull-request-philosophy

✅ glozow closed a pull request: "change txid log format specifier from %i to %s"
(https://github.com/bitcoin/bitcoin/pull/27133)

💬 willcl-ark commented on issue "Followups from #19525":
(https://github.com/bitcoin/bitcoin/issues/19623#issuecomment-1438304263)
I think I found the spot in the [ELF spec](https://refspecs.linuxfoundation.org/elf/elf.pdf) that describes what @laanwj observed, in _**Book III, Section 2, Base Address**_ (page 73), emphasis mine:

> An executable or shared object file's base address is calculated during execution from three
values: the virtual memory load address, the maximum page size, and the lowest virtual address
of a program's loadable segment. To compute the base address, one determines the memory
address associat
...

💬 Sjors commented on pull request "Add Signet launch shortcut for Windows":
(https://github.com/bitcoin/bitcoin/pull/26334#issuecomment-1438317444)
[running Guix build now, will mark as ready for review when that's done and I've tested it]

I added the word "test" to the application name.

Since [Bitcoin Inquisition](https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2022-September/020921.html) uses the default Signet to deploy several proposed soft forks, I think it's useful to offer easier access (which requires the Inquisition folks to rebase after this is merged).

See #8285 for additional context.

I generated the icon fro
...

💬 willcl-ark commented on pull request "github: Switch to yaml issue templates":
(https://github.com/bitcoin/bitcoin/pull/27025#discussion_r1112930264)
This config option enables the `Bitcoin Core Security Policy` row with the `Open` button which links to our `SECURITY.md`. The `Report a security vulnerability` row, with the big green `Report a vulnerability` button seems to be a GitHub default (which I don't know how to disable).

My preference would be to keep both, as otherwise the link to `SECURITY.md` via the `Report a vulnerability` button is from a small right menu item:


💬 willcl-ark commented on pull request "github: Switch to yaml issue templates":
(https://github.com/bitcoin/bitcoin/pull/27025#discussion_r1112935813)
Added in 3fa1185dd