👍 john-moffett approved a pull request: "wallet: be able to specify a wallet name and passphrase to migratewallet"
(https://github.com/bitcoin/bitcoin/pull/26595)
ACK 3e521b2eb13799e11866562cfda4dc0bd3f7d6b9

💬 jonatack commented on pull request "blockstorage: do not flush block to disk if it is already there":
(https://github.com/bitcoin/bitcoin/pull/27039#discussion_r1112320245)
The new test fails on master as expected, because the block file is read-only and can't be written to.

It may be reassuring to have coverage for the other side of this change, to be sure we're still flushing when expected. If this new line is removed and no flushing is done, all the functional and unit tests still pass (I didn't run the extended functional tests).

```diff
@@ -618,7 +618,6 @@ bool BlockManager::FindBlockPos(FlatFilePos& pos, unsigned int nAddSize, unsigne
if ((int)n
...

💬 jonatack commented on pull request "blockstorage: do not flush block to disk if it is already there":
(https://github.com/bitcoin/bitcoin/pull/27039#discussion_r1112320479)
nit, fix clang-format if you touch this line
```suggestion
const bool position_known{dbp != nullptr};
```

💬 jonatack commented on pull request "blockstorage: do not flush block to disk if it is already there":
(https://github.com/bitcoin/bitcoin/pull/27039#discussion_r1112331348)
Adding some logging shows that this `generate` call is the slowest part of the added test. Questions:

- Why 300 blocks? On my laptop the test passes reliably with 239 blocks and fails reliably with 238. Fewer blocks = faster test runs.

- Can you explain how the number of blocks used was arrived at, and document that calculation along with the other magic numbers?

<details><summary>Ideas, feel free to pick and choose (maybe some of the logging should be debug instead of info)</summary>
...

💬 brunoerg commented on pull request "p2p: return `CSubNet` in `LookupSubNet`":
(https://github.com/bitcoin/bitcoin/pull/26078#discussion_r1112352046)
Makes sense! Gonna address it!

📝 randydu opened a pull request: "Update txmempool.cpp"
(https://github.com/bitcoin/bitcoin/pull/27133)
fix format specifier issue for log message;

The parameter "txid.GetHex()" returns a std::string, but the corresponding format specifier is "%i", should be changed to "%s".

💬 brunoerg commented on pull request "p2p: return `CSubNet` in `LookupSubNet`":
(https://github.com/bitcoin/bitcoin/pull/26078#issuecomment-1437636314)
Force-pushed addressing lastest @vasild's review

💬 furszy commented on pull request "rpc: make importaddress compatible with descriptors wallet":
(https://github.com/bitcoin/bitcoin/pull/27034#issuecomment-1437637813)
> https://cirrus-ci.com/task/5389792813252608?logs=ci#L3465
>
> ```
> self.test_legacy_importaddress()
> File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/wallet_basic.py", line 72, in test_legacy_importaddress
> assert_equal(wallet_watch_only.getbalances()["watchonly"]['untrusted_pending'], 10)
> File "
...

⚠️ popkian opened an issue: "Bitcoin Core very slow sync"
(https://github.com/bitcoin/bitcoin/issues/27134)
I understand that it is not a new issue but I could not find any answer to my problem in previous threads.
I am syncing the bitcoin core for the first time , it has already past 48 hours and the progress is at 80%.

The issue that I am trying to figure out is that why it is not using the full resources of my computer.
My computer is about 6 years old.
I have a 5G internet and I tested my download speed which is about 50 mbps . I have increased the dbcache to 8000, threads to -1 and I hav
...

💬 popkian commented on issue "Sync slow":
(https://github.com/bitcoin/bitcoin/issues/26063#issuecomment-1437647758)
I am having the same exact issue, if anyone has any suggestion on how to solve this would be great.

💬 randydu commented on pull request "Update txmempool.cpp":
(https://github.com/bitcoin/bitcoin/pull/27133#issuecomment-1437671925)
Yes, in practice it won't cause any runtime problem thanks to the implementation of tinyformat library:

https://github.com/c42f/tinyformat#format-strings-and-type-safety

The "%i" format specifier will setup the std::ostream to render an integer, however the tinyformat uses stream operator "ostream << T" for actual output by default, in our case (T == std::string), the txid will be displayed as a string correctly.

However, the format specifier does make difference in some cases:
```c++
...

💬 achow101 commented on pull request "github: Switch to yaml issue templates":
(https://github.com/bitcoin/bitcoin/pull/27025#discussion_r1112394449)
The docs say that users can upload files as long as `render` is not set. I think it would be better to let reporters upload their log files rather than requiring them to use a paste site.

💬 achow101 commented on pull request "github: Switch to yaml issue templates":
(https://github.com/bitcoin/bitcoin/pull/27025#discussion_r1112390760)
There's already a big green button for the security policy, so I don't think we need to add a second one manually.

💬 Hyunhum commented on pull request "script: add description for the functionality of each opcode":
(https://github.com/bitcoin/bitcoin/pull/27109#issuecomment-1437763548)
> NIT
>
> ```shell
> cd src/ && clang-format --lines 68:148 -i script/script.h
> ```
>
> ```c
> diff --git a/src/script/script.h b/src/script/script.h
> index 35211ff376..5143593029 100644
> --- a/src/script/script.h
> +++ b/src/script/script.h
> @@ -66,17 +66,16 @@ std::vector<unsigned char> ToByteVector(const T& in)
> }
>
> /** Script opcodes */
> -enum opcodetype
> -{
> -/**
> - * Opcodes that take a true/false value will evaluate the following as false:
> - * an
...

💬 dhruv commented on pull request "BIP324: Cipher suite":
(https://github.com/bitcoin/bitcoin/pull/25361#issuecomment-1437811955)
Rebased.

💬 dhruv commented on pull request "BIP324: Add encrypted p2p transport {de}serializer":
(https://github.com/bitcoin/bitcoin/pull/23233#issuecomment-1437813348)
Rebased.

💬 dhruv commented on pull request "BIP324: Handshake prerequisites":
(https://github.com/bitcoin/bitcoin/pull/23561#issuecomment-1437814028)
Rebased.

💬 dhruv commented on pull request "BIP324: Enable v2 P2P encrypted transport":
(https://github.com/bitcoin/bitcoin/pull/24545#issuecomment-1437814663)
Rebased.

💬 ishaanam commented on pull request "wallet: be able to specify a wallet name and passphrase to migratewallet":
(https://github.com/bitcoin/bitcoin/pull/26595#issuecomment-1437958492)
reACK 3e521b2eb13799e11866562cfda4dc0bd3f7d6b9

💬 TheCharlatan commented on pull request "depends: harden libevent":
(https://github.com/bitcoin/bitcoin/pull/27118#issuecomment-1437992443)
ACK ff4a73aea2b8346f48f75e1130a36749f70e9049