📝 brunoerg opened a pull request: "test: fix intermittent issue in `p2p_disconnect_ban`"
(https://github.com/bitcoin/bitcoin/pull/27128)
Fixes #26808

When `node0` calls `disconnectnode` to disconnect `node1`, we should check in `node1` if it worked, because for `node0` the informations in `getpeerinfo` may be updated before really completing the disconnection.

💬 furszy commented on pull request "wallet, gui: bugfix, getAvailableBalance skips selected coins":
(https://github.com/bitcoin/bitcoin/pull/26699#issuecomment-1437077463)
rebased, conflicts solved.

💬 vasild commented on pull request "p2p: return `CSubNet` in `LookupSubNet`":
(https://github.com/bitcoin/bitcoin/pull/26078#discussion_r1112010947)
The new code could call `unban()` with an invalid subnet whereas the previous one would not. `unban()` would call `m_banned.erase()` which would use `operator==(const CSubNet& a, const CSubNet& b)` which could match another invalid entry, I guess. Maybe that is ok, but to keep this change "non-functional", the new code should be:

```cpp
if (possibleSubnet.IsValid() && m_node.unban(possibleSubnet)) {
```

💬 Sjors commented on pull request "docs: add ramdisk guide for running tests on OSX":
(https://github.com/bitcoin/bitcoin/pull/27124#issuecomment-1437111734)
utACK 62ac3b4

That looks pretty much like what I use on macOS.

💬 vasild commented on pull request "Handle CJDNS from LookupSubNet()":
(https://github.com/bitcoin/bitcoin/pull/27071#issuecomment-1437113256)
> `CConnman::DisconnectNode` also handles addresses as subnets. Is this a problem?

Well, it works, but since it does something nonsensical (e.g. subnetting tor) it could be a source of confusion or ultimately, bugs. IMO it shouldn't be doing that. I think the existence and implementation of `CConnman::DisconnectNode(const CSubNet& subnet)` is ok - it will/should disconnect any IPv[46] address that matches the given IPv[46] subnet. But this one:

```cpp
bool CConnman::DisconnectNode(const C
...

💬 willcl-ark commented on pull request "docs: add ramdisk guide for running tests on OSX":
(https://github.com/bitcoin/bitcoin/pull/27124#discussion_r1112027162)
I think this could "feel safer" for people to run if it were split into two commands (even though it's using a subshell)?

💬 Sjors commented on pull request "docs: add ramdisk guide for running tests on OSX":
(https://github.com/bitcoin/bitcoin/pull/27124#discussion_r1112032998)
You need to do this again at every reboot, so it's nice to have a single incantation in your bash history.

💬 willcl-ark commented on pull request "docs: add ramdisk guide for running tests on OSX":
(https://github.com/bitcoin/bitcoin/pull/27124#discussion_r1112033932)
OK, that makes sense too :)

💬 MarcoFalke commented on pull request "test: fix intermittent issue in `p2p_disconnect_ban`":
(https://github.com/bitcoin/bitcoin/pull/27128#issuecomment-1437144777)
lgtm ACK 1819564c2130d4d8537ca433c6688b56c769fb79

💬 MarcoFalke commented on pull request "refactor: replace all implicit C-style const/const+reinterpret with explicit casts":
(https://github.com/bitcoin/bitcoin/pull/27126#discussion_r1112064142)
Instead of changing one cast to another, it might be better to just use a span? But not sure if such refactoring is still worth it, then

💬 MarcoFalke commented on pull request "test: fix test abort for high timeout values (and `--timeout-factor 0`)":
(https://github.com/bitcoin/bitcoin/pull/25950#issuecomment-1437172950)
lgtm ACK 14302a4802e2dbb41f5189de88f99ddd5dda7736

💬 PastaPastaPasta commented on pull request "refactor: replace all implicit C-style const/const+reinterpret with explicit casts":
(https://github.com/bitcoin/bitcoin/pull/27126#discussion_r1112075041)
That might make sense. If I get more time sometime soon, I'll see if I can easily span-ify it. Overall, I prefer no cast over any cast; but if I cannot figure it out for some reason then I think it makes sense to still include it in this PR

💬 MarcoFalke commented on pull request "rpc: make importaddress compatible with descriptors wallet":
(https://github.com/bitcoin/bitcoin/pull/27034#issuecomment-1437177090)
https://cirrus-ci.com/task/5389792813252608?logs=ci#L3465

```
self.test_legacy_importaddress()
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/wallet_basic.py", line 72, in test_legacy_importaddress
assert_equal(wallet_watch_only.getbalances()["watchonly"]['untrusted_pending'], 10)
File "/tmp/cirrus-ci
...

💬 MarcoFalke commented on pull request "doc: Bump copyright years to present (headers only)":
(https://github.com/bitcoin/bitcoin/pull/26817#issuecomment-1437186687)
Closing as up for grabs. Should be easy to rebase, if someone wants to, given that most is a scripted diff

✅ MarcoFalke closed a pull request: "doc: Bump copyright years to present (headers only)"
(https://github.com/bitcoin/bitcoin/pull/26817)

✅ MarcoFalke closed a pull request: "ci: Add copyright header check"
(https://github.com/bitcoin/bitcoin/pull/27100)

✅ MarcoFalke closed a pull request: "refactor: Make m_mempool optional in PeerManager"
(https://github.com/bitcoin/bitcoin/pull/26247)

💬 MarcoFalke commented on issue "error: timeout on transient error: Could not connect to the server 127.0.0.1:8333 (error code 1 - "EOF reached")":
(https://github.com/bitcoin/bitcoin/issues/27121#issuecomment-1437212818)
How reliably can you reproduce the issue, what are the steps to do so?

💬 RandyMcMillan commented on pull request "docs: add ramdisk guide for running tests on OSX":
(https://github.com/bitcoin/bitcoin/pull/27124#issuecomment-1437222729)
Concept ACK

💬 RandyMcMillan commented on pull request "script: add description for the functionality of each opcode":
(https://github.com/bitcoin/bitcoin/pull/27109#issuecomment-1437246550)
NIT

```bash
cd src/ && clang-format --lines 68:148 -i script/script.h
```

```c
diff --git a/src/script/script.h b/src/script/script.h
index 35211ff376..5143593029 100644
--- a/src/script/script.h
+++ b/src/script/script.h
@@ -66,17 +66,16 @@ std::vector<unsigned char> ToByteVector(const T& in)
}

/** Script opcodes */
-enum opcodetype
-{
-/**
- * Opcodes that take a true/false value will evaluate the following as false:
- * an empty vector
- * a vector (of any le
...