💬 furszy commented on pull request "fuzz: improve `coinselection`":
(https://github.com/bitcoin/bitcoin/pull/27585#discussion_r1272371310)
In d72c0926:

Should check the `Merge` outcome. e.g. the result target and weight need to be the sum of the two merged targets and weights. Moreover, if one result uses the effective value and the other one not, the `use_effective` field must be updated.

💬 furszy commented on pull request "fuzz: improve `coinselection`":
(https://github.com/bitcoin/bitcoin/pull/27585#discussion_r1272364737)
Couldn't we assert that BnB `GetChange()` is always 0?

💬 sipa commented on pull request "BIP324 ciphersuite":
(https://github.com/bitcoin/bitcoin/pull/28008#discussion_r1272387005)
No idea where this came from. Fixed.

💬 sipa commented on pull request "BIP324 ciphersuite":
(https://github.com/bitcoin/bitcoin/pull/28008#discussion_r1272387694)
Fixed.

I've chosen not to introduce an enum, because it's not a very good with with the multiple bit error cases.

🤔 pinheadmz reviewed a pull request: "wallet: clarify replace fields in help output"
(https://github.com/bitcoin/bitcoin/pull/27782#pullrequestreview-1543745814)
concept ACK

Included a nit for better consistency with the messages. I'll also point out, regarding the original issue, that `gettransaction` also returns a `walletconflicts` field which is present for both senders and receivers.

💬 pinheadmz commented on pull request "wallet: clarify replace fields in help output":
(https://github.com/bitcoin/bitcoin/pull/27782#discussion_r1272425544)
```suggestion
{RPCResult::Type::STR_HEX, "replaces_txid", /*optional=*/true, "Only if 'category' is 'send'. The txid if this tx replaces another."},
```

💬 petertodd commented on pull request "policy: Enable full-rbf by default":
(https://github.com/bitcoin/bitcoin/pull/28132#issuecomment-1648152222)


On July 24, 2023 12:41:10 PM GMT+03:00, Pavel Vasin ***@***.***> wrote:
>I queried the explorer like this
>```
>~ $ curl -s https://mempool.space/api/v1/block/0000000000000000000153159d7b95debfb0dadcd1040aaf9dbeb0025a1ddeac/audit-summary | jq .fullrbfTxs
>[
> "53cec64b52989c531550ac4606bedf1ff83d5bfd90efdc4006f122ac6b1b7643",
> "5bc64344c56f847e2d992fab241567075473eec9423776afadc187299352bce1",
> "64ec51dedd1404a775d590f530a01bbdc4239c8eb6d33ce4b9217ec2f0b8ddae"
>]
>```
>Only 4 of 6 mention
...

💬 fanquake commented on pull request "test: create wallet specific for test_locked_wallet case":
(https://github.com/bitcoin/bitcoin/pull/28139#issuecomment-1648154754)
cc @ishaanam

💬 MarcoFalke commented on pull request "refactor: Remove C-style const-violating cast, Use reinterpret_cast":
(https://github.com/bitcoin/bitcoin/pull/28127#issuecomment-1648205184)
Thanks, addressed both comments by reviewers.

💬 achow101 commented on pull request "Rework validation logic for assumeutxo":
(https://github.com/bitcoin/bitcoin/pull/27746#discussion_r1272483470)
The blocks being marked `ASSUMED_VALID` have their `nStatus` completely reset to the expected values for assumed valid, which includes the omission of `HAVE_DATA`.

💬 achow101 commented on pull request "Rework validation logic for assumeutxo":
(https://github.com/bitcoin/bitcoin/pull/27746#issuecomment-1648224098)
ACK 137762f34a845e491b80f9cea07efc4427cb38bf

👍 hebasto approved a pull request: "refactor: Remove C-style const-violating cast, Use reinterpret_cast"
(https://github.com/bitcoin/bitcoin/pull/28127#pullrequestreview-1543851558)
re-ACK fa9108f85afdc926fd6a8b96cc2acff7ca25d7a8.

💬 darosior commented on pull request "refactor: Remove C-style const-violating cast, Use reinterpret_cast":
(https://github.com/bitcoin/bitcoin/pull/28127#issuecomment-1648234604)
re-utACK fa9108f85afdc926fd6a8b96cc2acff7ca25d7a8

💬 hebasto commented on issue "ci: Future of macOS and Windows MSVC CI tasks":
(https://github.com/bitcoin/bitcoin/issues/28098#issuecomment-1648237622)
> If the goal is to stay on a free plan, I think the only option is GitHub Actions CI.

GitHub Actions: [2000](https://github.com/pricing) minutes/month

CircleCI: [6000](https://circleci.com/pricing/) minutes/month

💬 pinheadmz commented on pull request "Support JSON-RPC 2.0 when requested by client":
(https://github.com/bitcoin/bitcoin/pull/27101#issuecomment-1648237927)
Rebased on master to re-apply scripted diff

💬 dergoegge commented on pull request "net processing, refactor: Decouple PeerManager from gArgs":
(https://github.com/bitcoin/bitcoin/pull/27499#discussion_r1272503501)
Done

💬 dergoegge commented on pull request "net processing, refactor: Decouple PeerManager from gArgs":
(https://github.com/bitcoin/bitcoin/pull/27499#discussion_r1272503610)
done

💬 dergoegge commented on pull request "net processing, refactor: Decouple PeerManager from gArgs":
(https://github.com/bitcoin/bitcoin/pull/27499#discussion_r1272503697)
done

💬 dergoegge commented on pull request "net processing, refactor: Decouple PeerManager from gArgs":
(https://github.com/bitcoin/bitcoin/pull/27499#issuecomment-1648248277)
Touched up all the nits, also rebased

💬 pinheadmz commented on pull request "rpc: show P2(W)SH redeemScript in getrawtransaction #27637":
(https://github.com/bitcoin/bitcoin/pull/27638#issuecomment-1648263090)
@Riahiamirreza are you still working on this?