💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#issuecomment-1435335044)
Sorry for the delay - I addressed the outstanding comments and pushed an update.

Major changes are two scripted-diff commits renaming the function.
`IsOutboundOrBlockRelayConn` to `IsAutomaticOutboundOrBlockRelayConn`
and the connection type
`BLOCK_RELAY` to `AUTOMATIC_BLOCK_RELAY`


> If you touch again (to kick the CI.) you might consider also amending [this comment](https://github.com/bitcoin/bitcoin/blob/3eb8c42368a6e059b1842cbcec478815d947a341/src/net_processing.cpp#L2725-L2726) to
...

💬 achow101 commented on pull request "test: create random and coins utils, add amount helper, dedupe add_coin":
(https://github.com/bitcoin/bitcoin/pull/26940#issuecomment-1435340191)
ACK 4275195606e6f42466d9a8ef766b3035833df4d5

💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#issuecomment-1435346271)
Sorry for the delay
[b5b6300 ](https://github.com/bitcoin/bitcoin/commit/b5b630099b24f5a87d316c9e5af258543fb329eb)to [bd56522](https://github.com/bitcoin/bitcoin/commit/bd56522466df3a899bea4ff86bfa2afc8af5049c)
I addressed the outstanding comments and pushed an update. Also had to rebase.

Major changes are two additional scripted-diff commits renaming the function.
`IsOutboundOrBlockRelayConn` to `IsAutomaticOutboundOrBlockRelayConn`
and the connection type
`BLOCK_RELAY` to `AUTOMATIC_BL
...

🚀 achow101 merged a pull request: "test: create random and coins utils, add amount helper, dedupe add_coin"
(https://github.com/bitcoin/bitcoin/pull/26940)

💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#issuecomment-1435367900)
> As mentioned in the issue #23763, perhaps I'm missing something but this seems somewhat redundant with
>
> * using a VPN, and/or
> * running bitcoind over multiple encrypted networks (Tor, I2P, CJDNS), and/or
> * BIP324 v2 encrypted p2p in the future

I'm not only thinking about a third party monitoring your connections, but also about about the information you'd give the clearnet outbound peers you connect to.
I think there are good reasons to have a connection to clearnet (getting bl
...

💬 theStack commented on pull request "test: fix test abort for high timeout values (and `--timeout-factor 0`)":
(https://github.com/bitcoin/bitcoin/pull/25950#issuecomment-1435370510)
Force-pushed with an updated comment as per feedback from @Zero-1729, I hope the intent is more clear now to the reader.

> What if you just change --timeout-factor to use None and pass that down properly?

@luke-jr: The value specified via --timeout-factor is multiplied at several places in the test framework with a concrete number to calculate the actually used timeout (see e.g. `git grep "* .*timeout_factor" ./test/functional/test_framework/`), I don't see how using None here leads to any
...

💬 sipa commented on pull request "BIP341 txdata cannot be precomputed without spent outputs":
(https://github.com/bitcoin/bitcoin/pull/27122#issuecomment-1435434066)
cc @roconnor-blockstream

⚠️ sostenuto0606 opened an issue: " About transaction size"
(https://github.com/bitcoin/bitcoin/issues/27123)
Hello

Please provide technical support.

Is there a way to calculate the transaction size before sending money?

💬 martinus commented on pull request "Add pool based memory resource":
(https://github.com/bitcoin/bitcoin/pull/25325#issuecomment-1435501826)
Rebased adds `include <test/util/random.h>`

💬 Hyunhum commented on issue " About transaction size":
(https://github.com/bitcoin/bitcoin/issues/27123#issuecomment-1435510206)
https://bitcoinops.org/en/tools/calc-size/

Use this

👍 Riahiamirreza approved a pull request: "rpc, p2p: add `addpermissionflags` RPC and allow whitelisting outbound"
(https://github.com/bitcoin/bitcoin/pull/26441)

💬 Riahiamirreza commented on pull request "rpc, p2p: add `addpermissionflags` RPC and allow whitelisting outbound":
(https://github.com/bitcoin/bitcoin/pull/26441#discussion_r1110975484)
nit: while the other parameter is `output_connection_direction`, isn't it good idea to change `output` to `output_permission_flags` or `output_permissions`?

💬 Riahiamirreza commented on pull request "rpc, p2p: add `addpermissionflags` RPC and allow whitelisting outbound":
(https://github.com/bitcoin/bitcoin/pull/26441#discussion_r1110976026)
nit: Why not using `ConnectionDirection::None` rather than `nullptr` to make it more clear?

✅ fanquake closed an issue: " About transaction size"
(https://github.com/bitcoin/bitcoin/issues/27123)

💬 BowTiedDeployer commented on pull request "wallet: rpc to add automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/25907#issuecomment-1435664883)
Is there a way to create a wallet from seed using bitcoin core?

When using `sethdseed` and the seed, it says `Only legacy wallets are supported by this command`.
I was interested in creating a wallet using a specific seed to also use it to get the keypair in rust and sign transactions. Please tell me if there is a method at the moment or if the `createwalletdescriptor` will be the first solution.

Thank you in advance.

💬 zzzi2p commented on issue "I2P: Limit transient addresses":
(https://github.com/bitcoin/bitcoin/issues/26754#issuecomment-1435700510)
Update mid-February:

We are now confident that Dec. 19 marked the start of a DDoS attack that continues to this day. It was not caused by Bitcoin, other applications, or congestion management issues in I2P routers. Our investigations and mitigations continue.

I apologize for the OP theory that Bitcoin could be the cause, and the urgency stated there. My initial research was incorrect.

The PR to reduce resource usage is still important, and we hope it gets merged in for your next release
...

💬 jonatack commented on pull request "Add pool based memory resource":
(https://github.com/bitcoin/bitcoin/pull/25325#issuecomment-1435700864)
re-ACK d87cb99bb37637e26a9e00b9f7de4bc6f44cb79d

📝 pinheadmz opened a pull request: "docs: add ramdisk guide for running tests on OSX"
(https://github.com/bitcoin/bitcoin/pull/27124)
Using a ramdisk on OSX sped up the test suite by about 5x (using default `jobs=4`) on my M1 macbook pro running macOS Monterey 12.3.1. This PR adds the relevant OSX commands following the Linux directions.

Default:
```
8204 s (accumulated)
Runtime: 2104 s
```

following commands from the PR:
```
1606 s (accumulated)
Runtime: 421 s
```

ramdisk + `jobs=32`:
```
2090 s (accumulated)
Runtime: 85 s
```

👍 ryanofsky approved a pull request: "Convert ArgsManager::GetDataDir to a read-only function"
(https://github.com/bitcoin/bitcoin/pull/27073)
Light code review ACK 64b812e9a6df8fb4ec96b978a08dc9bde2ada2f0. I want to look a little more closely at this and test a little more to be sure it works as expecte, but this seems like a very nice change. Avoids confusing side effect of functions like GetDataDirNet, AbsPathForConfigVal, and GetConfigFile creating directories in the background.

💬 ryanofsky commented on pull request "Convert ArgsManager::GetDataDir to a read-only function":
(https://github.com/bitcoin/bitcoin/pull/27073#discussion_r1111053194)
re: https://github.com/bitcoin/bitcoin/pull/27073#discussion_r1107231839

Agree new behavior is better than old behavior:

- Having absolute path of the file that could not be loaded provides more information to users
- Internally, new code avoids confusing side effect of `GetConfigFile` actually creating the datadir directory instead of just returning a path string