💬 TheCharlatan commented on pull request "refactor: make some BlockManager members const":
(https://github.com/bitcoin/bitcoin/pull/26664#issuecomment-1435327146)
Concept ACK

It won't make a difference to any callers of the `BlockManager`, but I think you could mark `FlushUndoFile` as `const` as well.

💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#discussion_r1110407979)
Yes, I think it makes sense as a follow-up! Though, if I'm not missing something we don't even support regular MANUAL connections there, so adding support for these would make sense as well?

💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#discussion_r1110408410)
I think I prefer the more concise version here, especially when most of the args are just defaults that are set to their actual values in the following lines.

💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#discussion_r1110408474)
done

💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#discussion_r1110408583)
done

💬 mistercx commented on issue "Hidden fee (about 15% of sum) while send":
(https://github.com/bitcoin/bitcoin/issues/27120#issuecomment-1435331129)
Thanks to all! The main meaning is here:

`Because the client manages coins in a particular way, it doesn't make sense to try to view coins it is managing with any kind of explorer. It's specifically trying to obscure the fact that all the coins are related. Those kinds of services are intended to monitor recieved funds, not managed funds.`

💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#issuecomment-1435335044)
Sorry for the delay - I addressed the outstanding comments and pushed an update.

Major changes are two scripted-diff commits renaming the function.
`IsOutboundOrBlockRelayConn` to `IsAutomaticOutboundOrBlockRelayConn`
and the connection type
`BLOCK_RELAY` to `AUTOMATIC_BLOCK_RELAY`


> If you touch again (to kick the CI.) you might consider also amending [this comment](https://github.com/bitcoin/bitcoin/blob/3eb8c42368a6e059b1842cbcec478815d947a341/src/net_processing.cpp#L2725-L2726) to
...

💬 achow101 commented on pull request "test: create random and coins utils, add amount helper, dedupe add_coin":
(https://github.com/bitcoin/bitcoin/pull/26940#issuecomment-1435340191)
ACK 4275195606e6f42466d9a8ef766b3035833df4d5

💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#issuecomment-1435346271)
Sorry for the delay
[b5b6300 ](https://github.com/bitcoin/bitcoin/commit/b5b630099b24f5a87d316c9e5af258543fb329eb)to [bd56522](https://github.com/bitcoin/bitcoin/commit/bd56522466df3a899bea4ff86bfa2afc8af5049c)
I addressed the outstanding comments and pushed an update. Also had to rebase.

Major changes are two additional scripted-diff commits renaming the function.
`IsOutboundOrBlockRelayConn` to `IsAutomaticOutboundOrBlockRelayConn`
and the connection type
`BLOCK_RELAY` to `AUTOMATIC_BL
...

🚀 achow101 merged a pull request: "test: create random and coins utils, add amount helper, dedupe add_coin"
(https://github.com/bitcoin/bitcoin/pull/26940)

💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#issuecomment-1435367900)
> As mentioned in the issue #23763, perhaps I'm missing something but this seems somewhat redundant with
>
> * using a VPN, and/or
> * running bitcoind over multiple encrypted networks (Tor, I2P, CJDNS), and/or
> * BIP324 v2 encrypted p2p in the future

I'm not only thinking about a third party monitoring your connections, but also about about the information you'd give the clearnet outbound peers you connect to.
I think there are good reasons to have a connection to clearnet (getting bl
...

💬 theStack commented on pull request "test: fix test abort for high timeout values (and `--timeout-factor 0`)":
(https://github.com/bitcoin/bitcoin/pull/25950#issuecomment-1435370510)
Force-pushed with an updated comment as per feedback from @Zero-1729, I hope the intent is more clear now to the reader.

> What if you just change --timeout-factor to use None and pass that down properly?

@luke-jr: The value specified via --timeout-factor is multiplied at several places in the test framework with a concrete number to calculate the actually used timeout (see e.g. `git grep "* .*timeout_factor" ./test/functional/test_framework/`), I don't see how using None here leads to any
...

💬 sipa commented on pull request "BIP341 txdata cannot be precomputed without spent outputs":
(https://github.com/bitcoin/bitcoin/pull/27122#issuecomment-1435434066)
cc @roconnor-blockstream

⚠️ sostenuto0606 opened an issue: " About transaction size"
(https://github.com/bitcoin/bitcoin/issues/27123)
Hello

Please provide technical support.

Is there a way to calculate the transaction size before sending money?

💬 martinus commented on pull request "Add pool based memory resource":
(https://github.com/bitcoin/bitcoin/pull/25325#issuecomment-1435501826)
Rebased adds `include <test/util/random.h>`

💬 Hyunhum commented on issue " About transaction size":
(https://github.com/bitcoin/bitcoin/issues/27123#issuecomment-1435510206)
https://bitcoinops.org/en/tools/calc-size/

Use this

👍 Riahiamirreza approved a pull request: "rpc, p2p: add `addpermissionflags` RPC and allow whitelisting outbound"
(https://github.com/bitcoin/bitcoin/pull/26441)

💬 Riahiamirreza commented on pull request "rpc, p2p: add `addpermissionflags` RPC and allow whitelisting outbound":
(https://github.com/bitcoin/bitcoin/pull/26441#discussion_r1110975484)
nit: while the other parameter is `output_connection_direction`, isn't it good idea to change `output` to `output_permission_flags` or `output_permissions`?

💬 Riahiamirreza commented on pull request "rpc, p2p: add `addpermissionflags` RPC and allow whitelisting outbound":
(https://github.com/bitcoin/bitcoin/pull/26441#discussion_r1110976026)
nit: Why not using `ConnectionDirection::None` rather than `nullptr` to make it more clear?

✅ fanquake closed an issue: " About transaction size"
(https://github.com/bitcoin/bitcoin/issues/27123)