💬 sipa commented on pull request "BIP341 txdata cannot be precomputed without spent outputs":
(https://github.com/bitcoin/bitcoin/pull/27122#issuecomment-1435298751)
Note that this shouldn't affect any consensus logic, as `spent` is always provided in that setting.

💬 mistercx commented on issue "Hidden fee (about 15% of sum) while send":
(https://github.com/bitcoin/bitcoin/issues/27120#issuecomment-1435299225)
Thanks for your help. I read about UTXO-model, so wallets with sum 0.0199924 and 0.00997949 is my addresses too, but for changes? I will be very grateful if you explain to me: how did these changes formed? From what amount? On my specific example, if possible. I do not understand the algorithm of this process for now.

💬 sipa commented on issue "Hidden fee (about 15% of sum) while send":
(https://github.com/bitcoin/bitcoin/issues/27120#issuecomment-1435307940)
Questions about how Bitcoin works are off-topic here, but you can find resource in other places. For example see https://bitcoin.stackexchange.com/a/738/208 about how change works.

✅ sipa closed an issue: "Hidden fee (about 15% of sum) while send"
(https://github.com/bitcoin/bitcoin/issues/27120)

💬 achow101 commented on pull request "refactor, kernel: Remove gArgs accesses from dbwrapper and txdb":
(https://github.com/bitcoin/bitcoin/pull/25862#issuecomment-1435311822)
ACK aadd7c5b9b43a38beaa954b4cb8c2fff55f2200f

🚀 achow101 merged a pull request: "refactor, kernel: Remove gArgs accesses from dbwrapper and txdb"
(https://github.com/bitcoin/bitcoin/pull/25862)

💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#discussion_r1110405441)
Not sure about this: Currently, the help for "addnode" states that only `=manual-block-relay` is possible (manual is the default). Adding this to the help might only complicate things for the user, because there would be no difference between `=manual` and no argument at all?

💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#discussion_r1110406081)
I agree that it would be more consistent and added a commit to do this - I'll check how many additional conflicts this introduces...

💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#discussion_r1110406730)
It's used in `net_processing` in places suchas `ConsiderEviction()` where we wouldn't want to consider manual connections.
I think the name "IsOutboundOrBlockRelayConn" isn't ideal (even before this PR, because manual connections are also outbound connections), maybe the name "IsAutomaticOutboundOrBlockRelayConn" would be better. I added a commit to do that.

💬 TheCharlatan commented on pull request "refactor: make some BlockManager members const":
(https://github.com/bitcoin/bitcoin/pull/26664#issuecomment-1435327146)
Concept ACK

It won't make a difference to any callers of the `BlockManager`, but I think you could mark `FlushUndoFile` as `const` as well.

💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#discussion_r1110407979)
Yes, I think it makes sense as a follow-up! Though, if I'm not missing something we don't even support regular MANUAL connections there, so adding support for these would make sense as well?

💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#discussion_r1110408410)
I think I prefer the more concise version here, especially when most of the args are just defaults that are set to their actual values in the following lines.

💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#discussion_r1110408474)
done

💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#discussion_r1110408583)
done

💬 mistercx commented on issue "Hidden fee (about 15% of sum) while send":
(https://github.com/bitcoin/bitcoin/issues/27120#issuecomment-1435331129)
Thanks to all! The main meaning is here:

`Because the client manages coins in a particular way, it doesn't make sense to try to view coins it is managing with any kind of explorer. It's specifically trying to obscure the fact that all the coins are related. Those kinds of services are intended to monitor recieved funds, not managed funds.`

💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#issuecomment-1435335044)
Sorry for the delay - I addressed the outstanding comments and pushed an update.

Major changes are two scripted-diff commits renaming the function.
`IsOutboundOrBlockRelayConn` to `IsAutomaticOutboundOrBlockRelayConn`
and the connection type
`BLOCK_RELAY` to `AUTOMATIC_BLOCK_RELAY`


> If you touch again (to kick the CI.) you might consider also amending [this comment](https://github.com/bitcoin/bitcoin/blob/3eb8c42368a6e059b1842cbcec478815d947a341/src/net_processing.cpp#L2725-L2726) to
...

💬 achow101 commented on pull request "test: create random and coins utils, add amount helper, dedupe add_coin":
(https://github.com/bitcoin/bitcoin/pull/26940#issuecomment-1435340191)
ACK 4275195606e6f42466d9a8ef766b3035833df4d5

💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#issuecomment-1435346271)
Sorry for the delay
[b5b6300 ](https://github.com/bitcoin/bitcoin/commit/b5b630099b24f5a87d316c9e5af258543fb329eb)to [bd56522](https://github.com/bitcoin/bitcoin/commit/bd56522466df3a899bea4ff86bfa2afc8af5049c)
I addressed the outstanding comments and pushed an update. Also had to rebase.

Major changes are two additional scripted-diff commits renaming the function.
`IsOutboundOrBlockRelayConn` to `IsAutomaticOutboundOrBlockRelayConn`
and the connection type
`BLOCK_RELAY` to `AUTOMATIC_BL
...

🚀 achow101 merged a pull request: "test: create random and coins utils, add amount helper, dedupe add_coin"
(https://github.com/bitcoin/bitcoin/pull/26940)

💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#issuecomment-1435367900)
> As mentioned in the issue #23763, perhaps I'm missing something but this seems somewhat redundant with
>
> * using a VPN, and/or
> * running bitcoind over multiple encrypted networks (Tor, I2P, CJDNS), and/or
> * BIP324 v2 encrypted p2p in the future

I'm not only thinking about a third party monitoring your connections, but also about about the information you'd give the clearnet outbound peers you connect to.
I think there are good reasons to have a connection to clearnet (getting bl
...