📝 MarcoFalke opened a pull request: "ci: Print full lscpu output"
(https://github.com/bitcoin/bitcoin/pull/28034)
Seems odd to withhold the other output, given that it may be useful to debug issues?

👍 vasild approved a pull request: "p2p: Diversify automatic outbound connections with respect to networks"
(https://github.com/bitcoin/bitcoin/pull/27213#pullrequestreview-1516160146)
ACK 1e65aae8068ecf313a7c3b176dfc1326b3b67fbe

💬 vasild commented on pull request "p2p: Diversify automatic outbound connections with respect to networks":
(https://github.com/bitcoin/bitcoin/pull/27213#issuecomment-1623362830)
What is (was?) the reason for https://github.com/bitcoin/bitcoin/pull/27213#issuecomment-1611194968?

🚀 glozow merged a pull request: "wallet: Give deprecation warning when loading a legacy wallet"
(https://github.com/bitcoin/bitcoin/pull/27869)

💬 fanquake commented on issue "Proposed Timeline for Legacy Wallet and BDB removal":
(https://github.com/bitcoin/bitcoin/issues/20160#issuecomment-1623377574)
Now that #27869 has been merged. It might be time to no-longer mark the `migratewallet` RCP as "EXPERIMENTAL".

💬 MarcoFalke commented on issue "Proposed Timeline for Legacy Wallet and BDB removal":
(https://github.com/bitcoin/bitcoin/issues/20160#issuecomment-1623395575)
@fanquake Does it not need the performance fix for bdb wallets with a lot of keys first?

💬 fanquake commented on issue "Proposed Timeline for Legacy Wallet and BDB removal":
(https://github.com/bitcoin/bitcoin/issues/20160#issuecomment-1623400014)
> @fanquake Does it not need the performance fix for bdb wallets with a lot of keys first?

I'm not sure. However if we are going to ship this warning that instructs users to use `migratewallet`, I don't think we can leave it marked as experimental.

📝 MarcoFalke opened a pull request: "test: Ignore UTF-8 errors in assert_debug_log"
(https://github.com/bitcoin/bitcoin/pull/28035)
Fix two bugs:

* `debug_log_bytes` returned "an opaque number when in text mode" (https://docs.python.org/3/tutorial/inputoutput.html#methods-of-file-objects), not the number of bytes.
* `read()` fails in text mode when the unicode hasn't been fully written yet. Fixes https://github.com/bitcoin/bitcoin/issues/28030

Fix both bugs by using `"rb"` instead of `"utf-8"`, and by using a non-throwing decode helper.

💬 fanquake commented on pull request "guix: use GCC 12.2.0 to build releases":
(https://github.com/bitcoin/bitcoin/pull/27897#issuecomment-1623409890)
Sent some additional patches upstream, to update packages we use: https://lists.gnu.org/archive/html/guix-patches/2023-07/msg00159.html, https://lists.gnu.org/archive/html/guix-patches/2023-07/msg00138.html, https://lists.gnu.org/archive/html/guix-patches/2023-07/msg00104.html, https://lists.gnu.org/archive/html/guix-patches/2023-07/msg00171.html, https://lists.gnu.org/archive/html/guix-patches/2023-07/msg00169.html.

💬 MarcoFalke commented on issue "wallet_importdescriptors.py: can't decode bytes in position 228861-228863: unexpected end of data":
(https://github.com/bitcoin/bitcoin/issues/28030#issuecomment-1623410610)
https://cirrus-ci.com/task/4872686879375360?logs=ci#L1867

```
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe2 in position 440222: unexpected end of data

💬 MarcoFalke commented on issue "Intermittent CI failure "fee too high" in wallet_send.py --descriptors ":
(https://github.com/bitcoin/bitcoin/issues/25164#issuecomment-1623414316)
https://cirrus-ci.com/task/4746240760479744?logs=ci#L2770

```
node0 2023-06-30T14:46:07.294496Z [httpworker.1] [rpc/request.cpp:181] [parse] [rpc] ThreadRPCServer method=testmempoolaccept user=__cookie__
test 2023-06-30T14:46:07.295000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/tes
...

⚠️ MarcoFalke reopened an issue: "Intermittent CI failure "fee too high" in wallet_send.py --descriptors "
(https://github.com/bitcoin/bitcoin/issues/25164)
https://cirrus-ci.com/task/6295015969259520

```
test 2022-04-22T21:26:09.984000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 133, in main
self.run_test()
File "/tmp/cirrus-ci-build/ci/
...

💬 pinheadmz commented on pull request "test: cover addrv2 anchors by adding TorV3 to CAddress in messages.py":
(https://github.com/bitcoin/bitcoin/pull/27452#discussion_r1254282411)
Indeed :-( see https://github.com/bitcoin/bitcoin/pull/27452#discussion_r1253478816 unless @vasild disagrees I'll revert part of my last update and put `keep_alive` back in socks5.py

💬 MarcoFalke commented on pull request "net: Use serialization parameters for CAddress serialization":
(https://github.com/bitcoin/bitcoin/pull/25284#issuecomment-1623488101)
rebased

💬 vasild commented on pull request "Relay own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/27509#discussion_r1254309734)
Oh, yes, this is in the "nonce match" branch of the logic that handles PONG. So, the answer to "Could that ever happen before we send our tx messages out?" is just "No".

💬 pinheadmz commented on pull request "exclude ipc scheme from port check":
(https://github.com/bitcoin/bitcoin/pull/28020#issuecomment-1623553674)
See also https://github.com/bitcoin/bitcoin/pull/27679 which closes the same issue and has tests

📝 MarcoFalke opened a pull request: "test: Restore unlimited timeout in IndexWaitSynced"
(https://github.com/bitcoin/bitcoin/pull/28036)
The timeout was unlimited before, so just restore that value for now: https://github.com/bitcoin/bitcoin/pull/27988#issuecomment-1619218007

👍 fanquake approved a pull request: "ci: Print full lscpu output"
(https://github.com/bitcoin/bitcoin/pull/28034#pullrequestreview-1516419650)
ACK fa956d20480b21b0f348b83dd451667620010d8e

https://cirrus-ci.com/task/6617265752244224?logs=ci#L180
```bash
+ lscpu
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 48 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 32
On-line CPU(s) list: 0-31
Vendor ID: AuthenticAMD
Model name: AMD EPYC 7B13
...

🚀 fanquake merged a pull request: "ci: Print full lscpu output"
(https://github.com/bitcoin/bitcoin/pull/28034)

💬 MarcoFalke commented on pull request "test: bugfix, synchronize indexes synchronously":
(https://github.com/bitcoin/bitcoin/pull/28026#issuecomment-1623588603)
Went ahead and created the alternative: https://github.com/bitcoin/bitcoin/pull/28036, if reviewers want it. Happy to close it, if this is merged in the meantime.