💬 MarcoFalke commented on pull request "docs: fixup honggfuzz fuzz patch":
(https://github.com/bitcoin/bitcoin/pull/28021#discussion_r1250601396)
Any reason to make the comment wrong?

💬 fanquake commented on pull request "docs: fixup honggfuzz fuzz patch":
(https://github.com/bitcoin/bitcoin/pull/28021#discussion_r1250606783)
Just a miss-copy and paste

👍 MarcoFalke approved a pull request: "docs: fixup honggfuzz fuzz patch"
(https://github.com/bitcoin/bitcoin/pull/28021#pullrequestreview-1510847799)
lgtm

💬 stickies-v commented on issue "rpc: doc: RPCHelpMan missing request parameters for getblocktemplate":
(https://github.com/bitcoin/bitcoin/issues/27998#issuecomment-1617805106)
Absolutely, just open the PR whenever you feel ready, or ask away here if you have any problems you can't figure out.

👍 brunoerg approved a pull request: "docs: fixup honggfuzz fuzz patch"
(https://github.com/bitcoin/bitcoin/pull/28021#pullrequestreview-1510913912)
ACK c1247c3746d4b9ea88a0f9cfb7e71904267b3cd3

✅ fanquake closed an issue: "docs: "Fuzzing the Bitcoin Core P2P layer using Honggfuzz NetDriver" is outdated"
(https://github.com/bitcoin/bitcoin/issues/28019)

🚀 fanquake merged a pull request: "docs: fixup honggfuzz fuzz patch"
(https://github.com/bitcoin/bitcoin/pull/28021)

💬 fanquake commented on pull request "ci: build Valgrind (3.21) from source":
(https://github.com/bitcoin/bitcoin/pull/27992#issuecomment-1618004102)
> Does it mean we drop support for distro-shipped valgrind?

I think they should remain supported similar to what we do now, where we roughly support recent Valgrind versions on recent distro releases, when combined with recent compilers etc, and we still see occasional issues i.e #27741.

> I checked the debian/rules file and did not see anything that we might be missing there in terms of build configuration.

I posted a little more about this here: https://github.com/bitcoin-core/qa-ass
...

🤔 t-bast reviewed a pull request: "Bump unconfirmed ancestor transactions to target feerate"
(https://github.com/bitcoin/bitcoin/pull/26152#pullrequestreview-1511014531)
I tried to run my own set of external e2e tests against https://github.com/bitcoin/bitcoin/pull/26152/commits/43b86e49351b3160c2e39807997a9373cd88e173 and they all hit the following assertion error:

```
bitcoind: wallet/coinselection.cpp:495: void wallet::SelectionResult::SetBumpFeeDiscount(CAmount): Assertion `discount >= 0' failed
```

Reading through recent comments, it seems somewhat expected that this version isn't yet fully working, let me know when you want me to run my tests again
...

💬 hebasto commented on pull request "Drop macOS ForceActivation workaround":
(https://github.com/bitcoin-core/gui/pull/744#issuecomment-1618090522)
Concept ACK.

> We now require 5.11.x+.

When building on macOS, Homebrew provides Qt [5.15.10](https://formulae.brew.sh/formula/qt@5). Our depends does 5.15.5.

cc @Sjors

📝 criadoperez opened a pull request: "typos on src files"
(https://github.com/bitcoin/bitcoin/pull/28022)
Fixes multiple typos

💬 fanquake commented on pull request "typos on src files":
(https://github.com/bitcoin/bitcoin/pull/28022#issuecomment-1618131355)
These are in a subtree. Which you can't modify. You'll need to send your changes upstream.

✅ fanquake closed a pull request: "typos on src files"
(https://github.com/bitcoin/bitcoin/pull/28022)

💬 hebasto commented on pull request "Drop macOS ForceActivation workaround":
(https://github.com/bitcoin-core/gui/pull/744#issuecomment-1618182696)
I think we can drop `-DOBJC_OLD_DISPATCH_PROTOTYPES=0` now. At least, the code compiles for me natively on macOS Ventura (arm64) and when cross-building on Ubuntu 23.04.

💬 criadoperez commented on pull request "typos on src files":
(https://github.com/bitcoin/bitcoin/pull/28022#issuecomment-1618230646)
Thanks @fanquake.
Can you please specify where I need to send the changes instead?

📝 chandrasekarachan opened a pull request: "Create bitcoinv"
(https://github.com/bitcoin/bitcoin/pull/28023)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 chandrasekarachan commented on pull request "Create bitcoinv":
(https://github.com/bitcoin/bitcoin/pull/28023#issuecomment-1618231058)
bitcoin

✅ fanquake closed a pull request: "Create bitcoinv"
(https://github.com/bitcoin/bitcoin/pull/28023)

📝 fanquake locked a pull request: "Create bitcoinv"
(https://github.com/bitcoin/bitcoin/pull/28023)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 fanquake commented on pull request "typos on src files":
(https://github.com/bitcoin/bitcoin/pull/28022#issuecomment-1618232083)
> Can you please specify where I need to send the changes instead?

https://github.com/bitcoin-core/secp256k1