💬 sdaftuar commented on pull request "Rework validation logic for assumeutxo":
(https://github.com/bitcoin/bitcoin/pull/27746#discussion_r1244022042)
Done.

💬 sdaftuar commented on pull request "Rework validation logic for assumeutxo":
(https://github.com/bitcoin/bitcoin/pull/27746#discussion_r1244023980)
Done (combined with taking @ryanofsky's approach for caching this value).

💬 sdaftuar commented on pull request "Rework validation logic for assumeutxo":
(https://github.com/bitcoin/bitcoin/pull/27746#discussion_r1244024243)
Agreed, gone now.

💬 sdaftuar commented on pull request "Rework validation logic for assumeutxo":
(https://github.com/bitcoin/bitcoin/pull/27746#discussion_r1244025126)
Can you explain a bit more what you have in mind for rewriting this function? Not sure I follow but happy to try to make this more readable/less error-prone.

💬 sdaftuar commented on pull request "Rework validation logic for assumeutxo":
(https://github.com/bitcoin/bitcoin/pull/27746#discussion_r1244025319)
Fixed, thanks.

💬 sdaftuar commented on pull request "Rework validation logic for assumeutxo":
(https://github.com/bitcoin/bitcoin/pull/27746#discussion_r1244026109)
Fixed.

💬 sdaftuar commented on pull request "Rework validation logic for assumeutxo":
(https://github.com/bitcoin/bitcoin/pull/27746#issuecomment-1609852620)
Thanks all for the additional review. I've updated based on feedback and cleaned up the commit history.

> would make sense but if we are gonna pass ChainstateManager to static functions, then I think we should avoid reaching into its internals and use the available interfaces or define new ones. I left a couple comments about this inline.

> It might also be better to do this in a separate PR and stick to the assumeutxo related improvements in this one. There are likely a lot more interfac
...

💬 sdaftuar commented on pull request "Rework validation logic for assumeutxo":
(https://github.com/bitcoin/bitcoin/pull/27746#discussion_r1244027946)
No longer relevant now that AcceptBlock is staying in CSM.

💬 sdaftuar commented on pull request "Rework validation logic for assumeutxo":
(https://github.com/bitcoin/bitcoin/pull/27746#discussion_r1244028312)
No longer relevant now that AcceptBlock/AcceptBlockHeader are staying in CSM.

💬 jonatack commented on pull request "doc: i2p documentation updates":
(https://github.com/bitcoin/bitcoin/pull/27937#discussion_r1244030626)
Done.

💬 jonatack commented on issue "I2P: Creating SAM session with 127.0.0.1:7656":
(https://github.com/bitcoin/bitcoin/issues/22759#issuecomment-1609907115)
> > The "cannot decode" message above repeats every 0.002 seconds, so ends up flooding the log file.
>
> > "Cannot decode Base64: "STREAM STATUS RESULT=I2P_ERROR MESSAGE="Session was closed""
> > and repeat same message hundreds time per second!
>
> Indeed, I have a few instances in my mainnet debug log when this occurred, and like these reports, in high-frequency bursts (unsure, but they seem to have only happened when using the Java I2P router, not i2pd). Will look more into it.

I've
...

💬 carnhofdaki commented on issue "Add maxrelaytxfee":
(https://github.com/bitcoin/bitcoin/issues/27983#issuecomment-1609907306)
![Uploading mutinynet.com_tx_68be05aec97b7d114e978185f0df76e494196e2b160330c97870b284f444e1c4.png…]()

Adding the screenshot in case that explorer will need to switch to pruned mode.

This is the raw hex transaction:

```
0200000000010238662df9105edbfc3bc1afb921e3bd382098624f9b2f5b3efa3144fb6c0c95340000000000fdffffffbb5667fde0eb1f0e169b85377ec7b79c07adfd680f84b0bc5e36180912abdf000000000000fdffffff0100000000000000000f6a0d746561636820426974636f696e0247304402202a9db30eae0197c835093b2837aec99
...

💬 ryanofsky commented on pull request "refactor: Drop unsafe AsBytePtr function":
(https://github.com/bitcoin/bitcoin/pull/27978#issuecomment-1609910681)
Rebased 2109a147406247bb654ee5fb8421a8594919fbd5 -> 650ca0d937c2c90adeeac60adae090902618d771 ([`pr/noptr.2`](https://github.com/ryanofsky/bitcoin/commits/pr/noptr.2) -> [`pr/noptr.3`](https://github.com/ryanofsky/bitcoin/commits/pr/noptr.3), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/noptr.2-rebase..pr/noptr.3)) due to conflict with #27479

💬 soheilwikey12 commented on pull request "bumpfee: ignore WALLET_INCREMENTAL_RELAY_FEE when user specifies fee_rate":
(https://github.com/bitcoin/bitcoin/pull/27969#issuecomment-1609942086)
14tDQpPnHqoOFvjBQzKoNM6bgwHL1oklVNLPRQr4Kvauq8oHICNDFvHv

💬 theStack commented on pull request "test: add python implementation of Elligator swift":
(https://github.com/bitcoin/bitcoin/pull/24005#discussion_r1244157426)
Thanks for clarifying, that makes sense.

💬 hebasto commented on pull request "build: produce a .zip for macOS distribution":
(https://github.com/bitcoin/bitcoin/pull/27099#discussion_r1244194688)
Unfortunately, using the `-r` option still introduces non-reproducibilty. Diffoscope points at some metadata related to directories. Not sure, but it looks like they are about creation timestamps.

Suggesting to use the same approach as we are using for Windows builds:
```suggestion
find $(APP_DIST_DIR) | sort | zip -X@ $@
```

Two subsequent runs on my Ubuntu 22.04 returned the same hashes.

💬 hebasto commented on pull request "build: produce a .zip for macOS distribution":
(https://github.com/bitcoin/bitcoin/pull/27099#issuecomment-1610057916)
> As evidence, Visual Studio Code has recently started distributing their macOS builds as ZIP files instead of DMGs, as you can see on their download page: [code.visualstudio.com/Download](https://code.visualstudio.com/Download).

In comparison to UX of downloading `VSCode-darwin.zip`, in the current PR branch, there is a top directory named `dist`, which seems redundant:


💬 0xB10C commented on pull request "test: various USDT functional test cleanups (27831 follow-ups)":
(https://github.com/bitcoin/bitcoin/pull/27944#issuecomment-1610093695)
Thanks for picking this up! Concept ACK. I'll have a closer look.

💬 achow101 commented on pull request "util: implement `noexcept` move assignment & move ctor for `prevector`":
(https://github.com/bitcoin/bitcoin/pull/27334#issuecomment-1610102318)
ACK bfb9291a8661fe5b26c14ed755cfa89d27c37110

🚀 achow101 merged a pull request: "util: implement `noexcept` move assignment & move ctor for `prevector`"
(https://github.com/bitcoin/bitcoin/pull/27334)