💬 MarcoFalke commented on issue "Enable consistency checks by default with `--enable-debug`":
(https://github.com/bitcoin/bitcoin/issues/24709#issuecomment-1609028182)
Closing per https://github.com/bitcoin/bitcoin/issues/24709#issuecomment-1556705320

✅ MarcoFalke closed an issue: "Enable consistency checks by default with `--enable-debug`"
(https://github.com/bitcoin/bitcoin/issues/24709)

💬 MarcoFalke commented on pull request "build: debug enable addrman consistency checks":
(https://github.com/bitcoin/bitcoin/pull/27300#issuecomment-1609028863)
Is this still relevant, given that the issue was closed?

💬 MarcoFalke commented on issue "Wallet not loaded":
(https://github.com/bitcoin/bitcoin/issues/27982#issuecomment-1609034988)
> "Wallet disabled!" from bitcoind running messages

You shouldn't be passing `-disablewallet` if you want to keep the wallet enabled.

Related code:

```cpp
if (args.GetBoolArg("-disablewallet", DEFAULT_DISABLE_WALLET)) {
LogPrintf("Wallet disabled!\n");
return;
}

⚠️ carnhofdaki opened an issue: "Add maxrelaytxfee"
(https://github.com/bitcoin/bitcoin/issues/27983)
### Please describe the feature you'd like to see added.

Just an example (this feature request is not related to mutinynet in any way) - https://mutinynet.com/tx/68be05aec97b7d114e978185f0df76e494196e2b160330c97870b284f444e1c4

Let's suppose the miner wants to recycle coins (and shrink the total number of UTXOs) by making an all-fee transaction and eventually mining it. Any other miner would be happy to mine such a transaction if it is relayed to the network.

### Is your feature related to a
...

💬 n1kcha commented on issue "Wallet not loaded":
(https://github.com/bitcoin/bitcoin/issues/27982#issuecomment-1609040837)
i did nothing different, nothing changed in configuration file. Just open a termianl an run bitcoin-qt as i am doing for years... How this -disablewallet parameter is passed?

💬 kristapsk commented on pull request "Fix potential network stalling bug":
(https://github.com/bitcoin/bitcoin/pull/27981#issuecomment-1609049607)
Wouldn't it be possible to trigger and test this with some functional test?

💬 MarcoFalke commented on issue "Wallet not loaded":
(https://github.com/bitcoin/bitcoin/issues/27982#issuecomment-1609050356)
Options can be passed on the command line, or in the conf file.

You can unusually find the conf file in the datadir. Or with the gui, via "Settings", "Options", "Open Conf File".

You can pass `-nodisablewallet` to overwrite a previous setting.

💬 n1kcha commented on issue "Wallet not loaded":
(https://github.com/bitcoin/bitcoin/issues/27982#issuecomment-1609055173)
ok thanks, i will check conf file

💬 vasild commented on pull request "Relay own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/27509#issuecomment-1609055465)
`5fd41b9fbf...bde055d28f`:
* rebase due to conflicts
* adjust the added test to expect that some non-sensitive relay connection may be opened before sensitive tx relay is complete; this is because the code was changed to be less aggressive and may open other connections even if sensitive relay ones are needed
* extract a move-only change in `ThreadOpenConnections()` to a separate commit to make it easier to review (new commit: ec6f4ac210 `net: move peers counting before grant acquisition in T
...

🚀 fanquake merged a pull request: "macOS: Bump minimum required runtime version and prepare for building with upstream LLVM"
(https://github.com/bitcoin/bitcoin/pull/27676)

💬 FelixWeis commented on issue "Assertion failed: (data.size() > node.nSendOffset), function SocketSendData, file net.cpp, line 837":
(https://github.com/bitcoin/bitcoin/issues/27963#issuecomment-1609101336)
no inboud peers, node ran smoothly overnight. crashed 2 times yesterday within a few hours.

💬 ismaelsadeeq commented on pull request "bumpfee: ignore WALLET_INCREMENTAL_RELAY_FEE when user specifies fee_rate":
(https://github.com/bitcoin/bitcoin/pull/27969#discussion_r1243410171)
Added the tests, Thanks

💬 MarcoFalke commented on pull request "util: Allow std::byte and char Span serialization":
(https://github.com/bitcoin/bitcoin/pull/27927#issuecomment-1609131921)
Did a rebase on clean master to drop the unneeded dependency.

💬 ismaelsadeeq commented on pull request "bumpfee: Allow the user to choose which output is change":
(https://github.com/bitcoin/bitcoin/pull/26467#issuecomment-1609133068)
re ACK e8c31f135c6e9a5f57325dbf4feceafd384f7762

💬 hebasto commented on pull request "guix: use GCC 12.2.0 to build releases":
(https://github.com/bitcoin/bitcoin/pull/27897#issuecomment-1609149881)
> Switch to using GCC 12 to build release binaries.

Concept ACK on this.

💬 fanquake commented on pull request "guix: Update `python-lief` package to 0.13.2":
(https://github.com/bitcoin/bitcoin/pull/27813#issuecomment-1609150774)
Guix Build:
```bash
018716ffdc0c60b1dfa27f95d1fb4e03d0e37f50cfc325ee35d200039b3f419e guix-build-529c92e837b2/output/aarch64-linux-gnu/SHA256SUMS.part
bb6e74d4806879560e7b6e50bce4b47b383ed5d763e6d25feac64b0c944cc036 guix-build-529c92e837b2/output/aarch64-linux-gnu/bitcoin-529c92e837b2-aarch64-linux-gnu-debug.tar.gz
2e6fc404211c94bc9a0265a783fabcd3c0bfddb9a87322b612185489ef6264d9 guix-build-529c92e837b2/output/aarch64-linux-gnu/bitcoin-529c92e837b2-aarch64-linux-gnu.tar.gz
b0f0d9e2e4466cc3
...

💬 glozow commented on pull request "[NO MERGE] BIP331 Ancestor Package Relay":
(https://github.com/bitcoin/bitcoin/pull/27742#discussion_r1243535255)
I think mentioning specific policy here would make things more confusing tbh. I can add a mention to BIP331?

💬 fanquake commented on pull request "build: produce a .zip for macOS distribution":
(https://github.com/bitcoin/bitcoin/pull/27099#issuecomment-1609267853)
```bash
cbe2109a1e88b431f462f6b8a62e785fe1f5f6249da55f984129c2a2ef454503 guix-build-23d89518e907/output/arm64-apple-darwin/SHA256SUMS.part
47c72d2c1c4ec35cd72db66cd602a213b18d43274dc3ab3fa8065f05e8844f83 guix-build-23d89518e907/output/arm64-apple-darwin/bitcoin-23d89518e907-arm64-apple-darwin-unsigned.tar.gz
eeeccfef61a67f39741e153b392cadc3e44ac317fd0608b30fcd8aab206cd2d2 guix-build-23d89518e907/output/arm64-apple-darwin/bitcoin-23d89518e907-arm64-apple-darwin-unsigned.zip
a662ab05fd44ef5
...

💬 psgreco commented on pull request "Fix potential network stalling bug":
(https://github.com/bitcoin/bitcoin/pull/27981#issuecomment-1609279748)
In theory, it should be, but in our tests (mostly @lolhill 's) it's a good component of this situation is latency. I've never been able to replicate this between 2 local hosts, always with a host that's ~100ms away.