💬 S3RK commented on pull request "Bump unconfirmed ancestor transactions to target feerate":
(https://github.com/bitcoin/bitcoin/pull/26152#discussion_r1243220924)
in "Amend bumpfee for inputs with overlapping ancestry" 56139fd808250fcb693b5f185e7e510804a33470

nit: you can use `SelectionResult::GetTotalBumpFee()` if you decide to introduce it

💬 S3RK commented on pull request "Bump unconfirmed ancestor transactions to target feerate":
(https://github.com/bitcoin/bitcoin/pull/26152#discussion_r1243238714)
in "Bump unconfirmed parent txs to target feerate" 8e3d924f02ee28043e8844a301389915823e5893

nit: we can encapsulate bump fee calculation within `CoinSelectionResult::GetTotalBumpFee()`. It will come handy in the next commit as well

💬 S3RK commented on pull request "Bump unconfirmed ancestor transactions to target feerate":
(https://github.com/bitcoin/bitcoin/pull/26152#discussion_r1243210309)
in "Amend bumpfee for inputs with overlapping ancestry" 56139fd808250fcb693b5f185e7e510804a33470

nit: we don't really need the whole wallet there, better to pass just chain interface

💬 gruve-p commented on pull request "macOS: Bump minimum required runtime version and prepare for building with upstream LLVM":
(https://github.com/bitcoin/bitcoin/pull/27676#issuecomment-1608956862)
ACK https://github.com/bitcoin/bitcoin/pull/27676/commits/3df60704661cdb5e61ea2b999f468f3a1d16105f

💬 MarcoFalke commented on pull request "util: Safer MakeByteSpan with ByteSpanCast":
(https://github.com/bitcoin/bitcoin/pull/27973#issuecomment-1608957974)
Maybe MakeByteSpan should just be removed?

* Currently it (as well as `Span`) accepts a range that is not borrowed (see https://en.cppreference.com/w/cpp/ranges/borrowed_range), leading to potential lifetime issues. Someone should check if making the `Span` deduction guidelines safer will automatically make the `MakeByteSpan` function safer.
* Given that `std::as_bytes` is in the standard library and we can't prevent devs from using it (or `AsBytes`) at compile time, it seems pointless tryin
...

💬 Sjors commented on issue "Assertion failed: (data.size() > node.nSendOffset), function SocketSendData, file net.cpp, line 837":
(https://github.com/bitcoin/bitcoin/issues/27963#issuecomment-1608964595)
@FelixWeis do you have inbound peers? After you've tried with the extra logging, maybe also try with `-listen=0`.

I'm running master @ 679f825ba3aae45af4476f357a67f8e6ec9483e2 now with this patch on an Intel macOS 13.4.1. Will update here if something happens. I haven't noticed such crashes with v25.0 which I've run for multiple days.

📝 MarcoFalke converted_to_draft a pull request: "util: Safer MakeByteSpan with ByteSpanCast"
(https://github.com/bitcoin/bitcoin/pull/27973)
The `AsBytes` helpers (or `std::as_bytes` helpers) are architecture
dependent. For example, the below test case diff [0], applied before
this commit will pass on x86_64, but fail on s390x [1].

Fix this by replacing `AsBytes` with a new `ByteSpanCast` in the `MakeByteSpan` helper.
This will turn the test case diff into a compile failure instead of a runtime error.

[0] test case diff:

```diff
diff --git a/src/test/serialize_tests.cpp b/src/test/serialize_tests.cpp
index 09f77d2b61..4
...

💬 Sjors commented on pull request "test: skip all backward compatibility tests under valgrind":
(https://github.com/bitcoin/bitcoin/pull/27228#issuecomment-1608981254)
Running the old binaries without valgrind makes sense. I'll see if I can figure out how.

💬 carnhofdaki commented on issue "Wallet not loaded":
(https://github.com/bitcoin/bitcoin/issues/27982#issuecomment-1609010564)
I think this behavior is expected. Have a look at f0758d8a66 and maybe some older related changes when the default wallet creation and loading is disabled.

It makes sense for nodes that run the released binary but do not operate their own wallet (or do it differently than using the Bitcoin Core's wallet - straight via RPC calls, for example `scantxoutset` to get the list of UTXOs).

👋 MarcoFalke's pull request is ready for review: "util: Allow std::byte and char Span serialization"
(https://github.com/bitcoin/bitcoin/pull/27927)

💬 n1kcha commented on issue "Wallet not loaded":
(https://github.com/bitcoin/bitcoin/issues/27982#issuecomment-1609025219)
I have another full node v25 (similarly recently updated from v24) to a different computer. No problems there. But how to see my wallet again, downgrade to v24?

💬 MarcoFalke commented on issue "Enable consistency checks by default with `--enable-debug`":
(https://github.com/bitcoin/bitcoin/issues/24709#issuecomment-1609028182)
Closing per https://github.com/bitcoin/bitcoin/issues/24709#issuecomment-1556705320

✅ MarcoFalke closed an issue: "Enable consistency checks by default with `--enable-debug`"
(https://github.com/bitcoin/bitcoin/issues/24709)

💬 MarcoFalke commented on pull request "build: debug enable addrman consistency checks":
(https://github.com/bitcoin/bitcoin/pull/27300#issuecomment-1609028863)
Is this still relevant, given that the issue was closed?

💬 MarcoFalke commented on issue "Wallet not loaded":
(https://github.com/bitcoin/bitcoin/issues/27982#issuecomment-1609034988)
> "Wallet disabled!" from bitcoind running messages

You shouldn't be passing `-disablewallet` if you want to keep the wallet enabled.

Related code:

```cpp
if (args.GetBoolArg("-disablewallet", DEFAULT_DISABLE_WALLET)) {
LogPrintf("Wallet disabled!\n");
return;
}

⚠️ carnhofdaki opened an issue: "Add maxrelaytxfee"
(https://github.com/bitcoin/bitcoin/issues/27983)
### Please describe the feature you'd like to see added.

Just an example (this feature request is not related to mutinynet in any way) - https://mutinynet.com/tx/68be05aec97b7d114e978185f0df76e494196e2b160330c97870b284f444e1c4

Let's suppose the miner wants to recycle coins (and shrink the total number of UTXOs) by making an all-fee transaction and eventually mining it. Any other miner would be happy to mine such a transaction if it is relayed to the network.

### Is your feature related to a
...

💬 n1kcha commented on issue "Wallet not loaded":
(https://github.com/bitcoin/bitcoin/issues/27982#issuecomment-1609040837)
i did nothing different, nothing changed in configuration file. Just open a termianl an run bitcoin-qt as i am doing for years... How this -disablewallet parameter is passed?

💬 kristapsk commented on pull request "Fix potential network stalling bug":
(https://github.com/bitcoin/bitcoin/pull/27981#issuecomment-1609049607)
Wouldn't it be possible to trigger and test this with some functional test?

💬 MarcoFalke commented on issue "Wallet not loaded":
(https://github.com/bitcoin/bitcoin/issues/27982#issuecomment-1609050356)
Options can be passed on the command line, or in the conf file.

You can unusually find the conf file in the datadir. Or with the gui, via "Settings", "Options", "Open Conf File".

You can pass `-nodisablewallet` to overwrite a previous setting.

💬 n1kcha commented on issue "Wallet not loaded":
(https://github.com/bitcoin/bitcoin/issues/27982#issuecomment-1609055173)
ok thanks, i will check conf file