✅ MarcoFalke closed an issue: "deadlock shutting down v25.0"
(https://github.com/bitcoin/bitcoin/issues/27965)

💬 MarcoFalke commented on issue "Indefinite "Bitcoin Core is shutting down..."":
(https://github.com/bitcoin/bitcoin/issues/27848#issuecomment-1607214840)
Closing as dupe of https://github.com/bitcoin/bitcoin/issues/27965 for now.

✅ MarcoFalke closed an issue: "Indefinite "Bitcoin Core is shutting down...""
(https://github.com/bitcoin/bitcoin/issues/27848)

💬 Crypt-iQ commented on issue "bitcoind hangs waiting for `g_requests.empty()`":
(https://github.com/bitcoin/bitcoin/issues/27722#issuecomment-1607224982)
> As @willcl-ark, tried @theStack's method with no sucess, my libevent version is 2.1.7, I'll try to update it and retry again. Thanks.
>
> @Crypt-iQ I did: Ctrl-C the waitforblockheight command before trying to stop bitcoind.

Good to know, I'll have to test out that version

💬 hebasto commented on pull request "build: produce a .zip for macOS distribution":
(https://github.com/bitcoin/bitcoin/pull/27099#issuecomment-1607239133)
Guix build on `arm64`:
```
3bdff2fec75d06d588b91ae89c94cbeea474d11e4c03d0b2bbf89de8565b8f92 guix-build-18df951ef677/output/arm64-apple-darwin/SHA256SUMS.part
c0c0e06b70e703eb47f2e9b6ae90b036af8585acba665a2ebd3aa9bbeb0159f0 guix-build-18df951ef677/output/arm64-apple-darwin/bitcoin-18df951ef677-arm64-apple-darwin-unsigned.tar.gz
3f0772f177a655e5d8b41bdd9355dec47100de9490d12335d13661197d571b7d guix-build-18df951ef677/output/arm64-apple-darwin/bitcoin-18df951ef677-arm64-apple-darwin-unsigned.
...

💬 tansanDOTeth commented on issue "Keep getting errors after a while of syncing":
(https://github.com/bitcoin/bitcoin/issues/27972#issuecomment-1607240792)
> Edit: Alternatively, leveldb may not support your filesystem?

Actually, my friend was telling me his external was formatted as APFS. Mine is currently formatted as ExFAT. Will try that and report back tomorrow.

💬 hebasto commented on pull request "build: produce a .zip for macOS distribution":
(https://github.com/bitcoin/bitcoin/pull/27099#issuecomment-1607325832)
Guix build on `x86_64`:
```
a375630be0529b0316ddf8378ea890693e2c2968935cdc857f07331ce9ae6ee4 guix-build-18df951ef677/output/arm64-apple-darwin/SHA256SUMS.part
c0c0e06b70e703eb47f2e9b6ae90b036af8585acba665a2ebd3aa9bbeb0159f0 guix-build-18df951ef677/output/arm64-apple-darwin/bitcoin-18df951ef677-arm64-apple-darwin-unsigned.tar.gz
532e0c561f0ada4298c753128d09fb5d72ceee241260e1aca82541a2ad1fbeb5 guix-build-18df951ef677/output/arm64-apple-darwin/bitcoin-18df951ef677-arm64-apple-darwin-unsigned
...

💬 pablomartin4btc commented on issue "Unable to open descriptor wallets that are not in a wallet directory":
(https://github.com/bitcoin/bitcoin/issues/26739#issuecomment-1607376761)
I think it could be [this](https://github.com/bitcoin/bitcoin/pull/19077#pullrequestreview-504980287) one? Commented by @ryanofsky, "Future flexibility" bullet point, and your response to him [here](https://github.com/bitcoin/bitcoin/pull/19077#issuecomment-705777007). I could work on it if you both are happy with it since I do also agree with that feature. Cheers!

💬 hebasto commented on pull request "guix: Update `python-lief` package to 0.13.2":
(https://github.com/bitcoin/bitcoin/pull/27813#issuecomment-1607382638)
Guix builds:
```
018716ffdc0c60b1dfa27f95d1fb4e03d0e37f50cfc325ee35d200039b3f419e guix-build-529c92e837b2/output/aarch64-linux-gnu/SHA256SUMS.part
bb6e74d4806879560e7b6e50bce4b47b383ed5d763e6d25feac64b0c944cc036 guix-build-529c92e837b2/output/aarch64-linux-gnu/bitcoin-529c92e837b2-aarch64-linux-gnu-debug.tar.gz
2e6fc404211c94bc9a0265a783fabcd3c0bfddb9a87322b612185489ef6264d9 guix-build-529c92e837b2/output/aarch64-linux-gnu/bitcoin-529c92e837b2-aarch64-linux-gnu.tar.gz
b0f0d9e2e4466cc301c
...

💬 hebasto commented on pull request "macOS: Bump minimum required runtime version and prepare for building with upstream LLVM":
(https://github.com/bitcoin/bitcoin/pull/27676#issuecomment-1607389698)
> the runtime functionality required for `-Wl,-fixup_chains` [requires macOS >=11.0](https://github.com/llvm/llvm-project/blob/release/16.x/lld/MachO/Driver.cpp?rgh-link-date=2023-05-16T15%3A52%3A00Z#L1021).

However, [Xcode 13 Release Notes](https://developer.apple.com/documentation/xcode-release-notes/xcode-13-release-notes) state:
> All programs and dylibs built with a deployment target of macOS 12 or iOS 15 or later now use the chained fixups format. This uses different load commands and
...

💬 hebasto commented on pull request "build: produce a .zip for macOS distribution":
(https://github.com/bitcoin/bitcoin/pull/27099#discussion_r1242138308)
The `-X` option is still needed as it was suggested [earlier](https://github.com/bitcoin/bitcoin/pull/27099#discussion_r1240844088):
```suggestion
zip -X -r $@ $(APP_DIST_DIR)
```

💬 hebasto commented on pull request "macOS: Bump minimum required runtime version and prepare for building with upstream LLVM":
(https://github.com/bitcoin/bitcoin/pull/27676#issuecomment-1607427931)
It would be nice if someone confirms that Guix binaries run on macOS 11 BigSur.

💬 furszy commented on pull request "wallet: Load database records in a particular order":
(https://github.com/bitcoin/bitcoin/pull/24914#discussion_r1242157733)
In f9db8fce:

Missed to set the error here.
```suggestion
if (err.empty()) err = e.what();
```

💬 vasild commented on pull request "p2p: Diversify automatic outbound connections with respect to networks":
(https://github.com/bitcoin/bitcoin/pull/27213#discussion_r1242173358)
Hmm, just realized that this is marked as resolved but is not resolved in the code. I am not sure, did you intentionally leave it as it is in the code now or did you forget to drop the optional like I suggested above?

💬 TheCharlatan commented on pull request "macOS: Bump minimum required runtime version and prepare for building with upstream LLVM":
(https://github.com/bitcoin/bitcoin/pull/27676#issuecomment-1607505539)
Guix build
```
find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
109ed45706b8cbdc897b6c51efa0247f8e8f1e6bb35c57e69f30093b62189a51 guix-build-3df60704661c/output/aarch64-linux-gnu/SHA256SUMS.part
4e28463f1c074c7c121abd5fbad89aa2269c5978829ccd4898d33a21eedfeb4f guix-build-3df60704661c/output/aarch64-linux-gnu/bitcoin-3df60704661c-aarch64-linux-gnu-debug.tar.gz
f20d074f0529202274a40f0530f79f601f5c575f1cd0addc099418719982485e
...

🤔 vasild reviewed a pull request: "p2p: Diversify automatic outbound connections with respect to networks"
(https://github.com/bitcoin/bitcoin/pull/27213#pullrequestreview-1498508181)
Approach ACK 564bf851cccd34e859f23b6e6b00debebba9a3c2

💬 vasild commented on pull request "p2p: Diversify automatic outbound connections with respect to networks":
(https://github.com/bitcoin/bitcoin/pull/27213#discussion_r1242180428)
style: use clang-format, this should be:

```cpp
bool IsManualOrFullOutboundConn() const
{
switch (m_conn_type) {
case ConnectionType::INBOUND:
...
```

💬 vasild commented on pull request "p2p: Diversify automatic outbound connections with respect to networks":
(https://github.com/bitcoin/bitcoin/pull/27213#discussion_r1242190047)
unrelated whitespace change

💬 vasild commented on pull request "p2p: Diversify automatic outbound connections with respect to networks":
(https://github.com/bitcoin/bitcoin/pull/27213#discussion_r1242196931)
I suggested `std::array` in another comment as a way to workaround the lack of mutex protection. Now that this is protected by a mutex and no need to tweak or workaround concurrency issues, I think the neatest option is:

```suggestion
std::unordered_map<Network, size_t> m_network_conn_counts GUARDED_BY(m_nodes_mutex) = {};
```

The `std::array` usage adds the requirement for sequential values of `NET_*` that are without gaps and start from `0` and have `NET_MAX`. That makes the code m
...

💬 hebasto commented on pull request "macOS: Bump minimum required runtime version and prepare for building with upstream LLVM":
(https://github.com/bitcoin/bitcoin/pull/27676#issuecomment-1607542766)
Guix (self-signed) `bitcoin-qt` tested on macOS Ventura 13.4.1 (Apple M1).