💬 joostjager commented on pull request "policy: make unstructured annex standard":
(https://github.com/bitcoin/bitcoin/pull/27926#discussion_r1241938735)
Which DoS concerns are you referring to? Since #24007 hasn't landed yet, the tx can only be accepted once?

💬 joostjager commented on pull request "policy: make unstructured annex standard":
(https://github.com/bitcoin/bitcoin/pull/27926#discussion_r1241941706)
My answer here would be the same as in https://github.com/bitcoin/bitcoin/pull/27926#discussion_r1241936380. I think you can argue that opt-in is enough protection and multi-party flows with annexes may not be a good idea. Especially if there are no concrete plans for multi-party protocols that require the unique properties of the annex.

💬 joostjager commented on pull request "policy: make unstructured annex standard":
(https://github.com/bitcoin/bitcoin/pull/27926#discussion_r1241944433)
Happy to do it if others agree that the current annex check isn't too minimal for its own file.

💬 MarcoFalke commented on issue "Indefinite "Bitcoin Core is shutting down..."":
(https://github.com/bitcoin/bitcoin/issues/27848#issuecomment-1607185201)
Makes sense, but then it seems a duplicate of #27965, which also still has the scheduler thread running (and more debug info)?

💬 MarcoFalke commented on issue "deadlock shutting down v25.0":
(https://github.com/bitcoin/bitcoin/issues/27965#issuecomment-1607197525)
Looks like the deadlock in the shutoff thread is here?

https://github.com/bitcoin/bitcoin/blob/642b5dd1b4fc5788ec7ab162a7c6ce0b96e7a6e4/src/httpserver.cpp#L481-L486

So maybe this is related to https://github.com/bitcoin/bitcoin/issues/27722 ?

💬 MarcoFalke commented on issue "deadlock shutting down v25.0":
(https://github.com/bitcoin/bitcoin/issues/27965#issuecomment-1607204268)
However, I don't see how the debug log and the gdb output are matching. The debug log claims that the net and msghand thread have been stopped, but that only happens in connman->Stop, in a line after `StopHTTPServer()`, which is the current point in gdb:

```
Thread 22 (Thread 0x7fffa16fe700 (LWP 584804) "b-shutoff"):
#0 futex_wait_cancelable (private=0, expected=0, futex_word=0x5555570e4be8 <g_requests_cv+40>) at ../sysdeps/nptl/futex-internal.h:186
#1 __pthread_cond_wait_common (abstime
...

💬 Crypt-iQ commented on issue "deadlock shutting down v25.0":
(https://github.com/bitcoin/bitcoin/issues/27965#issuecomment-1607205825)
Yeah I think the thread exits confused me since torcontrol, connman are stopped after the httpserver. I think those log lines mean the threads were interrupted and exited their loop (hence the exit log line) and are now joinable. So I think it's a dupe. If you look at #27722 you'll see that the tor control thread, msghand thread have exited as well

💬 MarcoFalke commented on issue "deadlock shutting down v25.0":
(https://github.com/bitcoin/bitcoin/issues/27965#issuecomment-1607212631)
Oh I see. `StopThreads` doesn't stop any threads. It just joins them, so maybe the method should be renamed?

Closing as dupe for now.

✅ MarcoFalke closed an issue: "deadlock shutting down v25.0"
(https://github.com/bitcoin/bitcoin/issues/27965)

💬 MarcoFalke commented on issue "Indefinite "Bitcoin Core is shutting down..."":
(https://github.com/bitcoin/bitcoin/issues/27848#issuecomment-1607214840)
Closing as dupe of https://github.com/bitcoin/bitcoin/issues/27965 for now.

✅ MarcoFalke closed an issue: "Indefinite "Bitcoin Core is shutting down...""
(https://github.com/bitcoin/bitcoin/issues/27848)

💬 Crypt-iQ commented on issue "bitcoind hangs waiting for `g_requests.empty()`":
(https://github.com/bitcoin/bitcoin/issues/27722#issuecomment-1607224982)
> As @willcl-ark, tried @theStack's method with no sucess, my libevent version is 2.1.7, I'll try to update it and retry again. Thanks.
>
> @Crypt-iQ I did: Ctrl-C the waitforblockheight command before trying to stop bitcoind.

Good to know, I'll have to test out that version

💬 hebasto commented on pull request "build: produce a .zip for macOS distribution":
(https://github.com/bitcoin/bitcoin/pull/27099#issuecomment-1607239133)
Guix build on `arm64`:
```
3bdff2fec75d06d588b91ae89c94cbeea474d11e4c03d0b2bbf89de8565b8f92 guix-build-18df951ef677/output/arm64-apple-darwin/SHA256SUMS.part
c0c0e06b70e703eb47f2e9b6ae90b036af8585acba665a2ebd3aa9bbeb0159f0 guix-build-18df951ef677/output/arm64-apple-darwin/bitcoin-18df951ef677-arm64-apple-darwin-unsigned.tar.gz
3f0772f177a655e5d8b41bdd9355dec47100de9490d12335d13661197d571b7d guix-build-18df951ef677/output/arm64-apple-darwin/bitcoin-18df951ef677-arm64-apple-darwin-unsigned.
...

💬 tansanDOTeth commented on issue "Keep getting errors after a while of syncing":
(https://github.com/bitcoin/bitcoin/issues/27972#issuecomment-1607240792)
> Edit: Alternatively, leveldb may not support your filesystem?

Actually, my friend was telling me his external was formatted as APFS. Mine is currently formatted as ExFAT. Will try that and report back tomorrow.

💬 hebasto commented on pull request "build: produce a .zip for macOS distribution":
(https://github.com/bitcoin/bitcoin/pull/27099#issuecomment-1607325832)
Guix build on `x86_64`:
```
a375630be0529b0316ddf8378ea890693e2c2968935cdc857f07331ce9ae6ee4 guix-build-18df951ef677/output/arm64-apple-darwin/SHA256SUMS.part
c0c0e06b70e703eb47f2e9b6ae90b036af8585acba665a2ebd3aa9bbeb0159f0 guix-build-18df951ef677/output/arm64-apple-darwin/bitcoin-18df951ef677-arm64-apple-darwin-unsigned.tar.gz
532e0c561f0ada4298c753128d09fb5d72ceee241260e1aca82541a2ad1fbeb5 guix-build-18df951ef677/output/arm64-apple-darwin/bitcoin-18df951ef677-arm64-apple-darwin-unsigned
...

💬 pablomartin4btc commented on issue "Unable to open descriptor wallets that are not in a wallet directory":
(https://github.com/bitcoin/bitcoin/issues/26739#issuecomment-1607376761)
I think it could be [this](https://github.com/bitcoin/bitcoin/pull/19077#pullrequestreview-504980287) one? Commented by @ryanofsky, "Future flexibility" bullet point, and your response to him [here](https://github.com/bitcoin/bitcoin/pull/19077#issuecomment-705777007). I could work on it if you both are happy with it since I do also agree with that feature. Cheers!

💬 hebasto commented on pull request "guix: Update `python-lief` package to 0.13.2":
(https://github.com/bitcoin/bitcoin/pull/27813#issuecomment-1607382638)
Guix builds:
```
018716ffdc0c60b1dfa27f95d1fb4e03d0e37f50cfc325ee35d200039b3f419e guix-build-529c92e837b2/output/aarch64-linux-gnu/SHA256SUMS.part
bb6e74d4806879560e7b6e50bce4b47b383ed5d763e6d25feac64b0c944cc036 guix-build-529c92e837b2/output/aarch64-linux-gnu/bitcoin-529c92e837b2-aarch64-linux-gnu-debug.tar.gz
2e6fc404211c94bc9a0265a783fabcd3c0bfddb9a87322b612185489ef6264d9 guix-build-529c92e837b2/output/aarch64-linux-gnu/bitcoin-529c92e837b2-aarch64-linux-gnu.tar.gz
b0f0d9e2e4466cc301c
...

💬 hebasto commented on pull request "macOS: Bump minimum required runtime version and prepare for building with upstream LLVM":
(https://github.com/bitcoin/bitcoin/pull/27676#issuecomment-1607389698)
> the runtime functionality required for `-Wl,-fixup_chains` [requires macOS >=11.0](https://github.com/llvm/llvm-project/blob/release/16.x/lld/MachO/Driver.cpp?rgh-link-date=2023-05-16T15%3A52%3A00Z#L1021).

However, [Xcode 13 Release Notes](https://developer.apple.com/documentation/xcode-release-notes/xcode-13-release-notes) state:
> All programs and dylibs built with a deployment target of macOS 12 or iOS 15 or later now use the chained fixups format. This uses different load commands and
...

💬 hebasto commented on pull request "build: produce a .zip for macOS distribution":
(https://github.com/bitcoin/bitcoin/pull/27099#discussion_r1242138308)
The `-X` option is still needed as it was suggested [earlier](https://github.com/bitcoin/bitcoin/pull/27099#discussion_r1240844088):
```suggestion
zip -X -r $@ $(APP_DIST_DIR)
```

💬 hebasto commented on pull request "macOS: Bump minimum required runtime version and prepare for building with upstream LLVM":
(https://github.com/bitcoin/bitcoin/pull/27676#issuecomment-1607427931)
It would be nice if someone confirms that Guix binaries run on macOS 11 BigSur.