π furszy approved a pull request: "feerate: For GetFeePerK() return nSatoshisPerK instead of round trip through GetFee"
(https://github.com/bitcoin/bitcoin/pull/27914#pullrequestreview-1497104793)
Code ACK 11d65006
(https://github.com/bitcoin/bitcoin/pull/27914#pullrequestreview-1497104793)
Code ACK 11d65006
π maryinaurvina opened a pull request: "Create bitcoin56"
(https://github.com/bitcoin/bitcoin/pull/27966)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
(https://github.com/bitcoin/bitcoin/pull/27966)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
π¬ maryinaurvina commented on pull request "Create bitcoin56":
(https://github.com/bitcoin/bitcoin/pull/27966#issuecomment-1606138070)
[bitcoin](https://github.com/bitcoin/bitcoin/tree/master)
(https://github.com/bitcoin/bitcoin/pull/27966#issuecomment-1606138070)
[bitcoin](https://github.com/bitcoin/bitcoin/tree/master)
β
hebasto closed a pull request: "Create bitcoin56"
(https://github.com/bitcoin/bitcoin/pull/27966)
(https://github.com/bitcoin/bitcoin/pull/27966)
π fanquake locked a pull request: "Create bitcoin56"
(https://github.com/bitcoin/bitcoin/pull/27966)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
(https://github.com/bitcoin/bitcoin/pull/27966)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
π mohammadimtayaj052 opened a pull request: "Create bitcoinBTC"
(https://github.com/bitcoin/bitcoin/pull/27967)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
(https://github.com/bitcoin/bitcoin/pull/27967)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
π¬ mohammadimtayaj052 commented on pull request "Create bitcoinBTC":
(https://github.com/bitcoin/bitcoin/pull/27967#issuecomment-1606145315)
btcaa
(https://github.com/bitcoin/bitcoin/pull/27967#issuecomment-1606145315)
btcaa
β
hebasto closed a pull request: "Create bitcoinBTC"
(https://github.com/bitcoin/bitcoin/pull/27967)
(https://github.com/bitcoin/bitcoin/pull/27967)
π hebasto locked a pull request: "."
(https://github.com/bitcoin/bitcoin/pull/27967)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
(https://github.com/bitcoin/bitcoin/pull/27967)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
π¬ Macoophonic commented on pull request "feerate: For GetFeePerK() return nSatoshisPerK instead of round trip through GetFee":
(https://github.com/bitcoin/bitcoin/pull/27914#issuecomment-1606183319)
Guys, it's late, I'll send more tomorrow π€£π€£π€£π
Hey gold night
VΓ o 21:56, CN, 25 thg 6, 2023 Matias Furszyfer ***@***.***>
ΔΓ£ viαΊΏt:
> ***@***.**** approved this pull request.
>
> Code ACK 11d6500
> <https://github.com/bitcoin/bitcoin/commit/11d650060aed25273d860baa4e03168a778832bb>
>
> β
> Reply to this email directly, view it on GitHub
> <https://github.com/bitcoin/bitcoin/pull/27914#pullrequestreview-1497104793>,
> or unsubscribe
> <https://github.com/notifications/unsub
...
(https://github.com/bitcoin/bitcoin/pull/27914#issuecomment-1606183319)
Guys, it's late, I'll send more tomorrow π€£π€£π€£π
Hey gold night
VΓ o 21:56, CN, 25 thg 6, 2023 Matias Furszyfer ***@***.***>
ΔΓ£ viαΊΏt:
> ***@***.**** approved this pull request.
>
> Code ACK 11d6500
> <https://github.com/bitcoin/bitcoin/commit/11d650060aed25273d860baa4e03168a778832bb>
>
> β
> Reply to this email directly, view it on GitHub
> <https://github.com/bitcoin/bitcoin/pull/27914#pullrequestreview-1497104793>,
> or unsubscribe
> <https://github.com/notifications/unsub
...
π¬ Macoophonic commented on issue "bitcoind hangs waiting for `g_requests.empty()`":
(https://github.com/bitcoin/bitcoin/issues/27722#issuecomment-1606197612)
Guys, it's late, I'll send more tomorrow π€£π€£π€£π
Hey gold night
VΓ o 21:15, CN, 25 thg 6, 2023 pablomartin4btc ***@***.***> ΔΓ£
viαΊΏt:
> As @willcl-ark <https://github.com/willcl-ark>, tried @theStack
> <https://github.com/theStack>'s method with no sucess, my libevent
> version is 2.1.7, I'll try to update it and retry again. Thanks.
>
> @Crypt-iQ <https://github.com/Crypt-iQ> I did: Ctrl-C the
> waitforblockheight command before trying to stop bitcoind.
>
> β
> Reply to this em
...
(https://github.com/bitcoin/bitcoin/issues/27722#issuecomment-1606197612)
Guys, it's late, I'll send more tomorrow π€£π€£π€£π
Hey gold night
VΓ o 21:15, CN, 25 thg 6, 2023 pablomartin4btc ***@***.***> ΔΓ£
viαΊΏt:
> As @willcl-ark <https://github.com/willcl-ark>, tried @theStack
> <https://github.com/theStack>'s method with no sucess, my libevent
> version is 2.1.7, I'll try to update it and retry again. Thanks.
>
> @Crypt-iQ <https://github.com/Crypt-iQ> I did: Ctrl-C the
> waitforblockheight command before trying to stop bitcoind.
>
> β
> Reply to this em
...
π¬ Macoophonic commented on issue "deadlock shutting down v25.0":
(https://github.com/bitcoin/bitcoin/issues/27965#issuecomment-1606198010)
Guys, it's late, I'll send more tomorrow π€£π€£π€£π
Hey gold night
VΓ o 20:35, CN, 25 thg 6, 2023 Chris Moore ***@***.***> ΔΓ£
viαΊΏt:
> Netstat tells me there's nothing listening on port 8332:
>
> $ sudo netstat -plnt | grep 833
> tcp 0 0 127.0.0.1:8333 0.0.0.0:* LISTEN 584775/bitcoin-qt-v
> tcp 27 0 127.0.0.1:8334 0.0.0.0:* LISTEN 584775/bitcoin-qt-v
>
> Detaching gdb and running strace -f on the process s
...
(https://github.com/bitcoin/bitcoin/issues/27965#issuecomment-1606198010)
Guys, it's late, I'll send more tomorrow π€£π€£π€£π
Hey gold night
VΓ o 20:35, CN, 25 thg 6, 2023 Chris Moore ***@***.***> ΔΓ£
viαΊΏt:
> Netstat tells me there's nothing listening on port 8332:
>
> $ sudo netstat -plnt | grep 833
> tcp 0 0 127.0.0.1:8333 0.0.0.0:* LISTEN 584775/bitcoin-qt-v
> tcp 27 0 127.0.0.1:8334 0.0.0.0:* LISTEN 584775/bitcoin-qt-v
>
> Detaching gdb and running strace -f on the process s
...
π¬ amitiuttarwar commented on pull request "p2p: Diversify automatic outbound connections with respect to networks":
(https://github.com/bitcoin/bitcoin/pull/27213#discussion_r1241259654)
updated
(https://github.com/bitcoin/bitcoin/pull/27213#discussion_r1241259654)
updated
π¬ amitiuttarwar commented on pull request "p2p: Diversify automatic outbound connections with respect to networks":
(https://github.com/bitcoin/bitcoin/pull/27213#discussion_r1241259892)
done
(https://github.com/bitcoin/bitcoin/pull/27213#discussion_r1241259892)
done
π¬ amitiuttarwar commented on pull request "p2p: Diversify automatic outbound connections with respect to networks":
(https://github.com/bitcoin/bitcoin/pull/27213#discussion_r1241259991)
changed to array, so this is no longer relevant
(https://github.com/bitcoin/bitcoin/pull/27213#discussion_r1241259991)
changed to array, so this is no longer relevant
π¬ amitiuttarwar commented on pull request "p2p: Diversify automatic outbound connections with respect to networks":
(https://github.com/bitcoin/bitcoin/pull/27213#issuecomment-1606212309)
updates with latest push: changed the data structure to an array, indexed by the net message types & protected by the `m_nodes_mutex`. thanks for the thoughtful reviews! curious to hear thoughts on this new approach
(https://github.com/bitcoin/bitcoin/pull/27213#issuecomment-1606212309)
updates with latest push: changed the data structure to an array, indexed by the net message types & protected by the `m_nodes_mutex`. thanks for the thoughtful reviews! curious to hear thoughts on this new approach
π¬ joostjager commented on pull request "policy: make unstructured annex standard":
(https://github.com/bitcoin/bitcoin/pull/27926#issuecomment-1606255813)
@luke-jr annex covenants, see link in PR description
(https://github.com/bitcoin/bitcoin/pull/27926#issuecomment-1606255813)
@luke-jr annex covenants, see link in PR description
π ismaelsadeeq opened a pull request: "bumpfee: ignore WALLET_INCREMENTAL_RELAY_FEE when user specifies fee_rate "
(https://github.com/bitcoin/bitcoin/pull/27969)
Fixes #26973
When using the `bumpfee` RPC and manually specifying `fee_rate`, there should be no requirement that the new fee must be at least the sum of the original fee and `incrementalFee` (maximum of `relayIncrementalFee` and `WALLET_INCREMENTAL_RELAY_FEE`).
This restriction should only apply when user did not specify `fee_rate`.
> because the GUI doesn't let the user specify the new fee rate yet (https://github.com/bitcoin-core/gui/issues/647), it would be very annoying to have to bu
...
(https://github.com/bitcoin/bitcoin/pull/27969)
Fixes #26973
When using the `bumpfee` RPC and manually specifying `fee_rate`, there should be no requirement that the new fee must be at least the sum of the original fee and `incrementalFee` (maximum of `relayIncrementalFee` and `WALLET_INCREMENTAL_RELAY_FEE`).
This restriction should only apply when user did not specify `fee_rate`.
> because the GUI doesn't let the user specify the new fee rate yet (https://github.com/bitcoin-core/gui/issues/647), it would be very annoying to have to bu
...
π€ ariard reviewed a pull request: "policy: make unstructured annex standard"
(https://github.com/bitcoin/bitcoin/pull/27926#pullrequestreview-1497263042)
IIRC from #19645 and beyond, witnesses could be concatenate on the flight by transaction-relaying node, therefore ensuring the best feerate transaction propagates. As itβs opening itβs own wormhole of DoS issues, better to pursue the conversation on the mailing list.
(https://github.com/bitcoin/bitcoin/pull/27926#pullrequestreview-1497263042)
IIRC from #19645 and beyond, witnesses could be concatenate on the flight by transaction-relaying node, therefore ensuring the best feerate transaction propagates. As itβs opening itβs own wormhole of DoS issues, better to pursue the conversation on the mailing list.
π¬ ariard commented on pull request "policy: make unstructured annex standard":
(https://github.com/bitcoin/bitcoin/pull/27926#discussion_r1241353751)
I think it makes sense to have a `annexrelay` option in `src/init.cpp` with `DEFAULT_ANNEXRELAY_ENABLE=false`, therefore to have node operators running nodes on performance-constrained hosts to opt-out from DoS concerns arising from the processing of the annex itself.
(https://github.com/bitcoin/bitcoin/pull/27926#discussion_r1241353751)
I think it makes sense to have a `annexrelay` option in `src/init.cpp` with `DEFAULT_ANNEXRELAY_ENABLE=false`, therefore to have node operators running nodes on performance-constrained hosts to opt-out from DoS concerns arising from the processing of the annex itself.