💬 besoeasy commented on pull request "Sanitizing ports of -rpcconnect and -rpcport.":
(https://github.com/bitcoin/bitcoin/pull/27820#issuecomment-1605833739)
@Brotcrunsher

Instead of checking if desiredRpcPort is less than or equal to zero and greater than 0xFFFF, you can use a single condition to check if it's outside the valid port range.

📝 Swallow094 opened a pull request: "Create FEWFEWF"
(https://github.com/bitcoin/bitcoin/pull/27960)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 Swallow094 commented on pull request "Create FEWFEWF":
(https://github.com/bitcoin/bitcoin/pull/27960#issuecomment-1605860760)
GẺGRE

💬 Swallow094 commented on pull request "Create FEWFEWF":
(https://github.com/bitcoin/bitcoin/pull/27960#issuecomment-1605860773)
GFRGFG

✅ achow101 closed a pull request: "Create FEWFEWF"
(https://github.com/bitcoin/bitcoin/pull/27960)

📝 achow101 locked a pull request: "Create FEWFEWF"
(https://github.com/bitcoin/bitcoin/pull/27960)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

⚠️ FelixWeis opened an issue: "Assertion failed: (data.size() > node.nSendOffset), function SocketSendData, file net.cpp, line 837"
(https://github.com/bitcoin/bitcoin/issues/27963)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

crashed

### Expected behaviour

not crash

### Steps to reproduce

compiled master at d1ae96755a0f9d7e12c3f6741c030d8ea6d0416f, did mainnet IBD,
around 40 hours after IBD crashed with the asseration fail.

### Relevant log output

unclear if relevant but these are the final lines
```
2023-06-24T06:15:52Z Saw new header hash=00000000000000000000f72e1a37859593a848a2f9b88eb9e5c3f0d8c971d
...

💬 FelixWeis commented on issue "Assertion failed: (data.size() > node.nSendOffset), function SocketSendData, file net.cpp, line 837":
(https://github.com/bitcoin/bitcoin/issues/27963#issuecomment-1605906878)
```Build Options:
with external callbacks = no
with benchmarks = no
with tests = yes
with ctime tests = no
with coverage = no
with examples = no
module ecdh = no
module recovery = yes
module extrakeys = yes
module schnorrsig = yes

asm = no
ecmult window size = 15
ecmult gen prec. bits = 4

valgrind = no
CC
...

💬 MarcoFalke commented on issue "Assertion failed: (data.size() > node.nSendOffset), function SocketSendData, file net.cpp, line 837":
(https://github.com/bitcoin/bitcoin/issues/27963#issuecomment-1605939843)
> around 40 hours after IBD crashed with the asseration fail.

I guess this makes it hard to reproduce with gdb attached or with more logging enabled?

Glancing at the code, I don't see how this could happen unless macOS `send` returned a value larger than the `len` passed in?

https://github.com/bitcoin/bitcoin/blame/d1ae96755a0f9d7e12c3f6741c030d8ea6d0416f/src/net.cpp#L837

The last change in the function was https://github.com/bitcoin/bitcoin/commit/691eaf8873fe2f189153ca637506a02915
...

⚠️ Zencsy opened an issue: "Bitcoin Core not responding"
(https://github.com/bitcoin/bitcoin/issues/27964)
### Issues, reports or feature requests related to the GUI should be opened directly on the GUI repo

- [X] I still think this issue should be opened here

### Report

I've just started bitcoin mining a few months ago and I've chosen bitcoin core as the app to store my bitcoins, after 2 days of synchronizing with the network i've 18 weeks left and suddenly my bitcoin core application keeps freezing and not responding. I tried to look for solutions to fix the problem online but most of them said
...

💬 hebasto commented on issue "Bitcoin Core not responding":
(https://github.com/bitcoin/bitcoin/issues/27964#issuecomment-1606018490)
> Issues, reports or feature requests related to the GUI should be opened directly on the GUI repo

Mind moving this issue into the [GUI repo](https://github.com/bitcoin-core/gui) (closing this one and opening a new issue there)?

> my bitcoin core application keeps freezing and not responding.

If it keeps freezing after restarting, more details are welcome, for instance `debug.log` content (NOTE: make sure no private details will leaked).

✅ Zencsy closed an issue: "Bitcoin Core not responding"
(https://github.com/bitcoin/bitcoin/issues/27964)

💬 MarcoFalke commented on issue "Bitcoin Core not responding":
(https://github.com/bitcoin/bitcoin/issues/27964#issuecomment-1606024240)
Pretty sure it is just waiting for cs_main, which is needed in IBD. So this is expected, unless the GUI is made lock-free, for which there should already be an issue open?

⚠️ dooglus opened an issue: "deadlock shutting down v25.0"
(https://github.com/bitcoin/bitcoin/issues/27965)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

I ran "bitcoin-cli stop" and it didn't stop.

### Expected behaviour

I expect it to stop.

### Steps to reproduce

It usually works. Sometimes it doesn't. I don't know how to reproduce.

### Relevant log output

Here's the end of `debug.log`:

2023-06-25T12:55:49Z Saw new header hash=0000000000000000000375a71ccc0569c279dbb751bdbb70d86d983cd38eea68 height=795857
2023-06-25T12:55
...

🤔 pablomartin4btc reviewed a pull request: "fuzz: addrman, add coverage for `network` field in `Select()`, `Size()` and `GetAddr()`"
(https://github.com/bitcoin/bitcoin/pull/27549#pullrequestreview-1497037871)
Tested ACK: `FUZZ=addrman ./src/test/fuzz/fuzz`

Tried also with a few seeds added last month by @Xekyo:
e.g.: `FUZZ=addrman ./src/test/fuzz/fuzz ../qa-assets/fuzz_seed_corpus/addrman/1b02be22a08f8e28c192cb1c86f074158d18a691`

💬 pablomartin4btc commented on pull request "fuzz: addrman, add coverage for `network` field in `Select()`, `Size()` and `GetAddr()`":
(https://github.com/bitcoin/bitcoin/pull/27549#discussion_r1241153134)
Do we really need this?
```suggestion
```
Next line calling `AddrMan::GetAddr()` function passes `std::nullopt` as the network argument (meaning ALL_NETWORKS), so as `AddrMan::Size()` also interprets the same for the network argument and since even `ConsumesBool()` when returns false it would be `std::nullopt` (meaning ALL_NETWORKS), why to bother with this, just pass std::nullopt below when you call `AddrMan::Size()`, unless I'm missing something here.

💬 pablomartin4btc commented on pull request "fuzz: addrman, add coverage for `network` field in `Select()`, `Size()` and `GetAddr()`":
(https://github.com/bitcoin/bitcoin/pull/27549#discussion_r1241153526)
As I explained my reasoning of this above in my first comment on the initialisation of the network variable:
```suggestion
(void)const_addr_man.Size(/*network=*/std::nullopt, in_new);
```

💬 pablomartin4btc commented on pull request "fuzz: addrman, add coverage for `network` field in `Select()`, `Size()` and `GetAddr()`":
(https://github.com/bitcoin/bitcoin/pull/27549#discussion_r1241150445)
I was going to propose:
```suggestion
bool in_new{fuzzed_data_provider.ConsumeBool()};
```
``` ```
But then I checked also the definition of the`AddrMan::Size()`function consuming `in_new` as and argument and I see in the comments that it would interpret the 3 states:
```
/**
* Return size information about addrman.
*
* @param[in] net Select addresses only from specified network (nullopt = all)
* @param[in] in_new Select addresses only f
...

💬 dooglus commented on issue "deadlock shutting down v25.0":
(https://github.com/bitcoin/bitcoin/issues/27965#issuecomment-1606094420)
Netstat tells me there's nothing listening on port 8332:

$ sudo netstat -plnt | grep 833
tcp 0 0 127.0.0.1:8333 0.0.0.0:* LISTEN 584775/bitcoin-qt-v
tcp 27 0 127.0.0.1:8334 0.0.0.0:* LISTEN 584775/bitcoin-qt-v

Detaching gdb and running `strace -f` on the process shows lots of activity:

[pid 584775] recvmsg(6, {msg_namelen=0}, 0) = -1 EAGAIN (Resource temporarily unavailable)
[pid 5847
...

💬 pablomartin4btc commented on issue "bitcoind hangs waiting for `g_requests.empty()`":
(https://github.com/bitcoin/bitcoin/issues/27722#issuecomment-1606107875)
As @willcl-ark, tried @theStack's method with no sucess, my libevent version is 2.1.7, I'll try to update it and retry again. Thanks.

@Crypt-iQ I did: Ctrl-C the waitforblockheight command before trying to stop bitcoind.