💬 prusnak commented on pull request "build: produce a .zip for macOS distribution":
(https://github.com/bitcoin/bitcoin/pull/27099#issuecomment-1430092015)
Concept ACK

Here's a revised version of the passage with improved grammar and natural-sounding language:

At present, the user experience with DMG is terrible (as noted in this issue: https://github.com/bitcoin/bitcoin/issues/26176). If there's no straightforward solution on the horizon, it would be best to switch to using ZIP instead. Using DMG without a Finder window provides no advantages and only leads to a lot of confusion. As evidence, Visual Studio Code has recently started distribut
...

👍 fanquake approved a pull request: "verify-commits: Bump trusted git root to after most recent laanwj merge"
(https://github.com/bitcoin/bitcoin/pull/27076)

💬 adam2k commented on pull request "build: Add CMake-based build system (1 of N)":
(https://github.com/bitcoin/bitcoin/pull/27060#issuecomment-1430135758)
This is great! ACK: https://github.com/bitcoin/bitcoin/commit/12758d3f69c4900f0d23df06e1ad746417428f3a

I see from the `NACK` comments that the reviewers seem to mostly be pushing back on this portion:

> ## Roadmap
> There are two goals:
>
> * merge all CMake code by v25.0 and test it
> * switch to the CMake-based build system by v26.0

In the spirit of having a complete git working history in the `master` branch, I understand the viewpoint.

Are there any other pieces (without ov
...

📝 hebasto opened a pull request: "refactor: Disable unused special members functions in `UnlockContext`"
(https://github.com/bitcoin-core/gui/pull/711)
Also `UnlockContext::valid` and `UnlockContext::relock` are `const` now.

💬 pinheadmz commented on issue "Manual-pruning cursor rewind":
(https://github.com/bitcoin/bitcoin/issues/19807#issuecomment-1430157210)
Downloading arbitrary blocks is certainly possible (this is how neutrino clients work) however, downloading old blocks would not include their UNDO data. This means you might be able to download old blocks to (for example) rescan a wallet but you would not be able to handle a deeper chain reorg than the original prune depth.

What might be possible is to increase the prune depth by 1 with every new incoming block, until a new desired prune depth is reached. The mechanism there would be to simp
...

💬 hebasto commented on pull request "clang-tidy: Add more `performance-*` checks and related fixes":
(https://github.com/bitcoin/bitcoin/pull/26642#issuecomment-1430157441)
Drafted. Please review https://github.com/bitcoin-core/gui/pull/711 first.

📝 hebasto converted_to_draft a pull request: "clang-tidy: Add more `performance-*` checks and related fixes"
(https://github.com/bitcoin/bitcoin/pull/26642)
null

👍 hebasto approved a pull request: "verify-commits: Bump trusted git root to after most recent laanwj merge"
(https://github.com/bitcoin/bitcoin/pull/27076)

👍 w0xlt approved a pull request: "script: remove unused bitwise `CScriptNum` operators"
(https://github.com/bitcoin/bitcoin/pull/27096)

📝 pinheadmz opened a pull request: "Support JSON-RPC 2.0 when requested by client"
(https://github.com/bitcoin/bitcoin/pull/27101)
Closes https://github.com/bitcoin/bitcoin/issues/2960

Bitcoin Core's JSONRPC server behaves with a special blend of 1.0, 1.1 and 2.0 behaviors. This introduces compliance issues with more strict clients. There are the major misbehaviors that I found:
- returning non-200 HTTP codes for RPC errors like "Method not found" (this is not a server error or an HTTP error)
- returning both `"error"` and `"result"` fields together in a response object.
- different behavior for single and batched RPC
...

💬 pinheadmz commented on issue "Support JSON-RPC 2.0":
(https://github.com/bitcoin/bitcoin/issues/2960#issuecomment-1430256959)
Possible solution: https://github.com/bitcoin/bitcoin/pull/27101 Looking for concept ACKs on that before finishing

💬 hebasto commented on pull request "refactor: Disable unused special members functions in `UnlockContext`":
(https://github.com/bitcoin-core/gui/pull/711#issuecomment-1430281898)
Friendly ping @achow101 @furszy @john-moffett @Sjors :)

💬 willcl-ark commented on issue "Expose PSBT AddInput/AddOutput via RPC":
(https://github.com/bitcoin/bitcoin/issues/19608#issuecomment-1430317687)
Oh good to know. (Also, wow that's like, the main point of PSBTv2 -- I really need to read the BIP!)

💬 achow101 commented on pull request "wallet: reuse change dest when re-creating TX with avoidpartialspends":
(https://github.com/bitcoin/bitcoin/pull/27053#discussion_r1106343872)
In 80ad44d10ca0831869a5e50c36e07e7ff10902ec "wallet: do not shadow change_pos in CreateTransaction()"

Use `sendall` instead of `sendtoaddress` with `subtractfeefromamount`.

Or just make a new wallet for this test.

💬 AdmiralNeo commented on issue "Stop the GPG verification madness":
(https://github.com/bitcoin/bitcoin/issues/25395#issuecomment-1430345737)
As an average user - not a dev - I am completely lost just finding a valid key to sign my Bitcoin Core. All I want is to run a Full Bitcoin Node, but my iMac won't let my even open the downloaded program as it is not signed. Any help out there?

💬 codo1 commented on pull request "Modernize rpcauth.py":
(https://github.com/bitcoin/bitcoin/pull/27081#issuecomment-1430354052)
> @codo1 If this comment can be helpful

It is. Thank you. Part of the docs you link to deserve a re-read by me.

💬 willcl-ark commented on issue "Stop the GPG verification madness":
(https://github.com/bitcoin/bitcoin/issues/25395#issuecomment-1430357235)
@AdmiralNeo did you already try following the instructions found on https://bitcoincore.org/en/download/ if so, where abouts did you get stuck?

If your question is specifically about how to find a key to import into GPG (to use for trust), then the answer is a little less clear, but there is still some guidance on the website:

> You can find many developer keys listed in the [bitcoin/bitcoin repository](https://github.com/bitcoin/bitcoin/tree/master/contrib/builder-keys), which you can the
...

💬 RandyMcMillan commented on pull request "build: produce a .zip for macOS distribution":
(https://github.com/bitcoin/bitcoin/pull/27099#issuecomment-1430371140)
Concept ACK

tested on macOS 12.6.1 (21G217)

💬 AdmiralNeo commented on issue "Stop the GPG verification madness":
(https://github.com/bitcoin/bitcoin/issues/25395#issuecomment-1430376573)
THX for your answer. I could load that key and somehow I guess he signed my downloaded Bitcoin Core program. But I am not able to start the program with the name "bitcoin-24.0.1-x86_64-apple-darwin.dmg". Must be a basic error of me as I am not a dev and using a terminal is already a big achievement for me, lol <img width="908" alt="Bildschirmfoto 2023-02-14 um 22 01 41" src="https://user-images.githubusercontent.com/125405780/218862325-81145c83-21f9-4d67-a712-1a18ce5f3537.png">

💬 willcl-ark commented on issue "Stop the GPG verification madness":
(https://github.com/bitcoin/bitcoin/issues/25395#issuecomment-1430379485)
Hmm, I wonder if this is the same issue as https://github.com/bitcoin/bitcoin/issues/26176 where the .dmg is being silently mounted?

After you double click the dmg file, is it mounted to the left pane of your Finder window for you to click on to open?