💬 maflcko commented on pull request "ci: Add Windows + UCRT jobs for cross-compiling and native testing":
(https://github.com/bitcoin/bitcoin/pull/33764#issuecomment-3562292543)
> > Not sure I understand the dependence on #33775?
> > CI is using it's own build, not the guix build right? Also MinGW brings it's own GCC doesn't it?
>
> The CI jobs are more useful when using toolchains with versions similar to those in the Guix script.

I think this is just a doc question. I think the `trixie/g++-mingw-w64-ucrt64` task can be left as-is, without adding a dependency here. In the future, https://github.com/bitcoin/bitcoin/pull/33593 could simply update the comment to cl
...

💬 maflcko commented on pull request "depends, doc: Learn `x86_64-w64-mingw32ucrt` host and document it":
(https://github.com/bitcoin/bitcoin/pull/33857#discussion_r2549232668)
> > It could make sense to ask Ubuntu to import g++-mingw-w64-ucrt64 from Debian, at least for the 26.04 release.
>
> It appears to be a WIP: https://packages.ubuntu.com/search?keywords=ucrt

Ah ok, so maybe someone could open a question/request at https://launchpad.net/ubuntu/+source/gcc-mingw-w64/+bugs, so that the progress can be tracked.

✅ waketraindev closed a pull request: "Add console commands for clearing output and history"
(https://github.com/bitcoin-core/gui/pull/882)

✅ waketraindev closed a pull request: "Prevent re-execution of sensitive commands from console history"
(https://github.com/bitcoin-core/gui/pull/909)

✅ waketraindev closed an issue: "No way to clear command history in RPC console or reset the console without restarting the node"
(https://github.com/bitcoin-core/gui/issues/897)

💬 maflcko commented on pull request "test: add unit test coverage for the empty leaves path in MerkleComputation":
(https://github.com/bitcoin/bitcoin/pull/33858#issuecomment-3562382383)
lgtm ACK ffcae82a68104c1992964b26c592b62cbca391bf

💬 waketraindev commented on pull request "Add console commands for clearing output and history":
(https://github.com/bitcoin-core/gui/pull/882#issuecomment-3562385876)
Closed

💬 waketraindev commented on pull request "Prevent re-execution of sensitive commands from console history":
(https://github.com/bitcoin-core/gui/pull/909#issuecomment-3562387089)
Closed

💬 fanquake commented on pull request "test: assumeutxo: add missing tests in wallet_assumeutxo.py":
(https://github.com/bitcoin/bitcoin/pull/30455#issuecomment-3562449962)
`wallet_assumeutxo.py` is failing when I run it locally:
```bash
./build/test/functional/test_runner.py wallet_assumeutxo.py
Temporary test directory at /var/folders/83/bylt1m2s7xnf5ytr1g6dn7lh0000gn/T/test_runner_₿_🏃_20251121_103928
Remaining jobs: [wallet_assumeutxo.py]
1/1 - wallet_assumeutxo.py failed, Duration: 4 s

stdout:
2025-11-21T10:39:28.628294Z TestFramework (INFO): PRNG seed is: 3913925397541703779
2025-11-21T10:39:28.628710Z TestFramework (INFO): Initializing test directo
...

💬 hebasto commented on pull request "depends, doc: Learn `x86_64-w64-mingw32ucrt` host and document it":
(https://github.com/bitcoin/bitcoin/pull/33857#discussion_r2549347896)
> Ah ok, so maybe someone could open a question/request at https://launchpad.net/ubuntu/+source/gcc-mingw-w64/+bugs, so that the progress can be tracked.

https://bugs.launchpad.net/ubuntu/+source/gcc-mingw-w64/+bug/2132114

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2549354887)
This is a continuation of https://github.com/bitcoin/bitcoin/pull/27509#discussion_r1214671917. I think it is better to continue the discussion there to have it in one place. I asked at IRC for it to be unlocked, I guess it was locked due to inactivity.

✅ maflcko closed a pull request: "test: assumeutxo: add missing tests in wallet_assumeutxo.py"
(https://github.com/bitcoin/bitcoin/pull/30455)

📝 maflcko reopened a pull request: "test: assumeutxo: add missing tests in wallet_assumeutxo.py"
(https://github.com/bitcoin/bitcoin/pull/30455)
Adding tests in `./test/functional/wallet_assumeutxo.py` to cover the following scenario:
- test loading a wallet (backup) on a pruned node

💬 hebasto commented on pull request "doc: Add `INSTALL.md` to Linux release tarballs":
(https://github.com/bitcoin/bitcoin/pull/33451#issuecomment-3562633993)
The recent feedback from @fanquake has been addressed.

💬 hebasto commented on pull request "doc: Add `INSTALL.md` to Linux release tarballs":
(https://github.com/bitcoin/bitcoin/pull/33451#discussion_r2549474353)
Thanks! [Dropped](https://github.com/bitcoin/bitcoin/pull/33451#issuecomment-3562633993).

💬 hebasto commented on pull request "doc: Add `INSTALL.md` to Linux release tarballs":
(https://github.com/bitcoin/bitcoin/pull/33451#discussion_r2549475436)
Thanks! [Reworked](https://github.com/bitcoin/bitcoin/pull/33451#issuecomment-3562633993).

💬 hebasto commented on pull request "doc: Add `INSTALL.md` to Linux release tarballs":
(https://github.com/bitcoin/bitcoin/pull/33451#issuecomment-3562645421)
> Should #29977 be closed, if we add these docs?

No need to wait for these docs. Static linking of `xcb` and friends should be sufficient.

> Is 20.04 considered unsupported?

I think so.

💬 hebasto commented on issue "depends: Freetype and xcbproto version in depends are too new":
(https://github.com/bitcoin/bitcoin/issues/29977#issuecomment-3562659799)
> At least if we're considering Ubuntu 20.04LTS as the reference.

Let’s update the baseline to Ubuntu 22.04 LTS instead.

In that case, this issue can be closed in light of [the static linking of XCB](https://github.com/bitcoin/bitcoin/pull/33537).

💬 hodlinator commented on pull request "refactor, docs: Embedded ASMap [2/3]: Refactor asmap internals and add documentation":
(https://github.com/bitcoin/bitcoin/pull/33878#discussion_r2549545939)
Couldn't stop thinking about this. It felt weird to implement reverse byte order in `GetBitBE` but then also start `bits` from the end of `ip` data and count backwards. Found a way that I think simplifies things further, making the order we consume bytes between LE&BE implementations the same, but having different bit-order. Diff against b41f5a29f7d56da8fd157770ad29b5776c3684c6:
```diff
--- a/src/util/asmap.cpp
+++ b/src/util/asmap.cpp
@@ -48,21 +48,25 @@ namespace {
constexpr uint32_t INV
...

💬 l0rinc commented on pull request "precalculate SipHash constant salt XORs":
(https://github.com/bitcoin/bitcoin/pull/30442#issuecomment-3562729119)
Fixed the remaining linter warnings after the rebase.,

<details>
<summary>Details</summary>

```patch
diff --git a/src/crypto/siphash.h b/src/crypto/siphash.h
index 0027a6850e..10d2713257 100644
--- a/src/crypto/siphash.h
+++ b/src/crypto/siphash.h
@@ -19,15 +19,15 @@ class SipSalt
public:
explicit SipSalt(uint64_t k0, uint64_t k1) noexcept : v{C0 ^ k0, C1 ^ k1, C2 ^ k0, C3 ^ k1} {}

- std::array<uint64_t, 4> v{};
+ std::array<uint64_t, 4> v;
};

// General Sip
...