⚠️ maflcko opened an issue: "Intermittent CI network issue downloading assets.json from GitHub"
(https://github.com/bitcoin/bitcoin/issues/33599)
CI frequently fails lately intermittently due to a network issue: https://github.com/bitcoin/bitcoin/actions/runs/18389269290/job/52395485037?pr=33592#step:9:518

As the infra was changed to run on someone else's sever, I don't know how to debug this or how to fix it.

💬 maflcko commented on pull request "[WIP] doc: update Guix install instructions":
(https://github.com/bitcoin/bitcoin/pull/33574#issuecomment-3388445684)
> that this might be a bad indicator for the guix project overall?

The LWN article concludes that "Regular releases" are planned, so it is likely that the situation will improve and possibly make backporting bugfixes easier in the future. So in theory, the guix package could make its way back into Debian/Ubuntu.

💬 Dorex45 commented on pull request "[30.x] Finalise v30.0":
(https://github.com/bitcoin/bitcoin/pull/33559#issuecomment-3388453300)
ACK Reviewed the release notes.

> Finalise `v30.0`. Imports the release notes from https://github.com/bitcoin-core/bitcoin-devwiki/wiki/v30.0-Release-Notes-Draft.

💬 maflcko commented on issue "Intermittent CI network issue downloading assets.json from GitHub":
(https://github.com/bitcoin/bitcoin/issues/33599#issuecomment-3388471886)
https://github.com/bitcoin/bitcoin/actions/runs/18383987889/job/52377590888?pr=33585#step:9:524, etc ...

💬 Dorex45 commented on pull request "refactor: throw `std::string_view` instead of `const char*` in constexpr/consteval functions":
(https://github.com/bitcoin/bitcoin/pull/33569#issuecomment-3388474342)
> Related to [#33550 (comment)](https://github.com/bitcoin/bitcoin/pull/33550#issuecomment-3378978210)
>
> Works around Clang code generation bug when targeting Windows where where catching `const char*` exceptions by reference is broken, see [mstorsjo/llvm-mingw#522](https://github.com/mstorsjo/llvm-mingw/issues/522)
>
> Following [C++ Core Guidelines E.15](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#e15-throw-by-value-catch-exceptions-from-a-hierarchy-by-reference) "Thro
...

💬 fanquake commented on issue "Intermittent CI network issue downloading assets.json from GitHub":
(https://github.com/bitcoin/bitcoin/issues/33599#issuecomment-3388532884)
Possibly related to Github API incidents yesterday: https://www.githubstatus.com/history ?

✅ fanquake closed an issue: "30.0 RC Testing Guide Feedback"
(https://github.com/bitcoin/bitcoin/issues/33369)

💬 fanquake commented on issue "30.0 RC Testing Guide Feedback":
(https://github.com/bitcoin/bitcoin/issues/33369#issuecomment-3388537850)
v30.0 has been tagged.

⚠️ fanquake unpinned an issue: "30.0 RC Testing Guide Feedback"
(https://github.com/bitcoin/bitcoin/issues/33369)
This issue is to discuss the [30.0 Release Candidate Testing Guide](https://github.com/bitcoin-core/bitcoin-devwiki/wiki/30.0-Release-Candidate-Testing-Guide). If you have any feedback on the document, please leave a comment here.

Note: This is for feedback on the document, not on Bitcoin Core or on the 30.0 changes. Create a new issue or give feedback in the [v30.0 Testing issue](https://github.com/bitcoin/bitcoin/issues/33368)

Thank you for taking a look at the guide and leaving your feedbac
...

⚠️ fanquake unpinned an issue: "v30.0 Testing"
(https://github.com/bitcoin/bitcoin/issues/33368)
Umbrella issue for 30.0 testing. Please help testing on a wide variety of supported platforms, as well as interaction with different software.

Let us know which version you tested on which operating system.

If you find an issue, please search Github for known issues first and then open a new Github issue.

This meta issue should not be used to report bugs, as a single thread makes it impossible to track more than one topic.

See [30.0 Release Notes Draft](https://github.com/bitcoin-core/bitcoi
...

✅ fanquake closed an issue: "v30.0 Testing"
(https://github.com/bitcoin/bitcoin/issues/33368)

💬 fanquake commented on issue "v30.0 Testing":
(https://github.com/bitcoin/bitcoin/issues/33368#issuecomment-3388538932)
v30.0 has been tagged.

🚀 fanquake merged a pull request: "Update libmultiprocess subtree to support reduced logging"
(https://github.com/bitcoin/bitcoin/pull/33518)

💬 hebasto commented on pull request "guix: Use UCRT runtime for Windows release binaries":
(https://github.com/bitcoin/bitcoin/pull/33593#discussion_r2418735989)
1. https://codeberg.org/guix/guix/src/commit/8daae75de3670594dfcb63b6ae6f1603ca6f7971/gnu/packages/mingw.scm#L88-L90:
```scheme
;; XXX: A new target to use UCRT can be introduced as
;; the MSYS2 project does, e.g: x86_64-w64-ucrt-mingw32.
"--with-default-msvcrt=msvcrt")
```
2. https://issues.guix.gnu.org/71630:
> I've added a new configure flag to set the default MSVCRT to MSVCRT as
the default now is UCRT. This default is a
...

💬 hebasto commented on pull request "Contrib: Updated macdeployqtplus to remove deprecated --deep signing":
(https://github.com/bitcoin/bitcoin/pull/33592#issuecomment-3388630562)
Concept ACK.

🤔 hebasto reviewed a pull request: "cmake: Use builtin support for .manifest files"
(https://github.com/bitcoin/bitcoin/pull/33585#pullrequestreview-3321807006)
I agree on the refactoring first and last commits.

The mentioned upstream [issue](https://gitlab.kitware.com/cmake/cmake/-/issues/23244) was exactly the reason why I implemented manifest handling this way in https://github.com/bitcoin/bitcoin/pull/32396.

Is there any CMake's docs regarding handling `.manifest` files?

💬 purpleKarrot commented on pull request "cmake: Use builtin support for .manifest files":
(https://github.com/bitcoin/bitcoin/pull/33585#issuecomment-3388772024)
> The mentioned upstream [issue](https://gitlab.kitware.com/cmake/cmake/-/issues/23244) was exactly the reason why I implemented manifest handling this way in #32396.

Got it. I think the advantage of using the workaround conditionally with a comment to the upstream issue is that it is self-documenting and simplifies future refactoring once the issue is solved upstream.
If the workaround is used unconditionally for all platforms, it is not obvious to future contributors that this is in fact a
...

💬 Sjors commented on pull request "build: Drop support for EOL macOS 13":
(https://github.com/bitcoin/bitcoin/pull/33489#issuecomment-3388872966)
I just retired my 27" iMac from 2017, which happens to only support macOS 13. I was only using it for its great 5K monitor though, connecting my IDE to a faster computer for compilation.

That means it would be more work for me to test things on that machine, since even booting it takes several minutes. If I was still using that machine I would have preferred to maintain support for it a bit longer, until something actually breaks or blocks progress.

💬 maflcko commented on pull request "build: Drop support for EOL macOS 13":
(https://github.com/bitcoin/bitcoin/pull/33489#issuecomment-3388922270)
> I just retired my 27" iMac from 2017, which happens to only support macOS 13. I was only using it for its great 5K monitor though, connecting my IDE to a faster computer for compilation.
>
> That means it will be more work for me to test things on that machine, since even booting it takes several minutes. If I was still using that machine I would have preferred to maintain support for it a bit longer, until something actually breaks or blocks progress.

I don't think this pull request cha
...

💬 delta1 commented on issue "Decouple datacarrier size and count limits (Draft PR)":
(https://github.com/bitcoin/bitcoin/issues/33595#issuecomment-3388963633)
Concept NACK, issue looks like LLM slop