💬 glozow commented on pull request "Avoiding unnecessary std::string copy in ArgsManager::GetPathArg argument list":
(https://github.com/bitcoin/bitcoin/pull/27812#issuecomment-1575663213)
Thank you for your contribution. We have a large amount of PRs requiring review attention, so closing this. Please see our contributing guidelines on [refactoring](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#refactoring) and [getting started](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#getting-started).

✅ glozow closed a pull request: "Avoiding unnecessary std::string copy in ArgsManager::GetPathArg argument list"
(https://github.com/bitcoin/bitcoin/pull/27812)

💬 kevkevinpal commented on pull request "wallet: Add tracing for sqlite statements":
(https://github.com/bitcoin/bitcoin/pull/27801#issuecomment-1575665937)
ACK https://github.com/bitcoin/bitcoin/commit/ff9d961bf38b24f8f931dcf66799cbc468e473df

💬 theStack commented on pull request "test: avoid sporadic MINIMALDATA failure in feature_taproot.py (fixes #27595)":
(https://github.com/bitcoin/bitcoin/pull/27631#issuecomment-1575671961)
Added a comment, as suggested by @instagibbs. Let me know what you think, suggestions very welcome.

@Sjors: thought about that approach too, but it seems that the devil is in the details; in your example, passing a single zero-byte would now wrongly translate to a OP_0 operation, which pushes a zero-length array instead. Concept ACK on fixing the test framework's CScript class to always correctly emit minimal-encoded scripts, but that seems to be a bigger operation that ideally also includes
...

📝 mzumsande opened a pull request: "init: return error when block index is non-contiguous, fix feature_init.py file perturbation"
(https://github.com/bitcoin/bitcoin/pull/27823)
When the block index database is non-contiguous due to file corruption (i.e. it contains indexes of height `x-1` and `x+1`, but not `x`), bitcoind can currently crash with an assert in `BuildSkip()` / `GetAncestor()` during `BlockManager::LoadBlockIndex()`:
```
bitcoind: chain.cpp:112: const CBlockIndex* CBlockIndex::GetAncestor(int) const: Assertion `pindexWalk->pprev' failed.
```
This PR changes it such that we instead return an `InitError` to the user.

I stumbled upon this because I no
...

💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#issuecomment-1575678278)
Seems like other proposals such as #27213 and #27509 that rely on improving automatic behavior have more support compared to this one (which needs manual setup by the node operator). Closing for now.

✅ mzumsande closed a pull request: "p2p, rpc: Manual block-relay-only connections with addnode"
(https://github.com/bitcoin/bitcoin/pull/24170)

💬 Brotcrunsher commented on pull request "init: return error when block index is non-contiguous, fix feature_init.py file perturbation":
(https://github.com/bitcoin/bitcoin/pull/27823#discussion_r1217034392)
Wouldn't it be better to check for `!=` instead for `>`?

💬 mzumsande commented on pull request "init: return error when block index is non-contiguous, fix feature_init.py file perturbation":
(https://github.com/bitcoin/bitcoin/pull/27823#discussion_r1217039090)
I think that would be incorrect, because there will be multiple indexes for a given height in case of stale blocks / forks.

💬 Brotcrunsher commented on pull request "init: return error when block index is non-contiguous, fix feature_init.py file perturbation":
(https://github.com/bitcoin/bitcoin/pull/27823#discussion_r1217039358)
Actually it can't - it's sorted. But still the indices coudl be the same.

💬 Brotcrunsher commented on pull request "init: return error when block index is non-contiguous, fix feature_init.py file perturbation":
(https://github.com/bitcoin/bitcoin/pull/27823#issuecomment-1575685598)
Little disclaimer: It's my first Review for Bitcoin Core. So treat my input with care, I might have no clue what I am talking about.

What I don't like about this change is that previously the user at least had a chance of finding out what's wrong, without debugging the code. Now he won't have any info of what went wrong other than "Error loading block database", which can have multiple other reasons. Is there a way for us to communicate this better? Maybe a log? Or can we throw here? The sad
...

👍 theStack approved a pull request: "wallet: Add tracing for sqlite statements"
(https://github.com/bitcoin/bitcoin/pull/27801#pullrequestreview-1461441581)
ACK ff9d961bf38b24f8f931dcf66799cbc468e473df

💬 ariard commented on pull request "Remove -mempoolfullrbf option":
(https://github.com/bitcoin/bitcoin/pull/26525#issuecomment-1575919359)
> To be clear, 0conf users have to "upgrade" every single time mempool policies/conditions change for any non-trivial amount of hashing power. Pretty much any mempool policy change can be exploited to double-spend unconfirmed transactions. That's why the only entities with any hope of relying on them are large, centralized, transaction processors with significant engineering resources. The nVersion=3 proposal is not special in this regard.

Not all the mempool policies/condition changes are eq
...

💬 MikeBH9944 commented on pull request "Multiprocess bitcoin":
(https://github.com/bitcoin/bitcoin/pull/10102#issuecomment-1575959653)
jmy blocks

💬 MikeBH9944 commented on pull request "Multiprocess bitcoin":
(https://github.com/bitcoin/bitcoin/pull/10102#issuecomment-1575959693)
m

💬 vasild commented on pull request "Relay own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/27509#issuecomment-1576033040)
`92fb45b5ef...c9acf32606`: make the python linter happy and avoid a race in the test - `wait_for_connect()` could time out as if a connection never arrived even if it did. This happens if the peer is connects and disconnects before `wait_for_connect()` is called.

👍 TheCharlatan approved a pull request: "Add public Boost headers explicitly"
(https://github.com/bitcoin/bitcoin/pull/27783#pullrequestreview-1461879008)
ACK 2484cacb7a6367b24e924dba0825c843b1dfc1c3

💬 MarcoFalke commented on pull request "Renamed UniValue::__pushKV to UniValue::pushKVEnd.":
(https://github.com/bitcoin/bitcoin/pull/27822#issuecomment-1576362686)
lgtm ACK acad989e67a57709dbb882c97852c2067f9dc65e

💬 fanquake commented on pull request "Provide `-fcf-protection=none` in `test-security-check.py` explicitly":
(https://github.com/bitcoin/bitcoin/pull/27819#issuecomment-1576398291)
> But I don't see the point of the same restrictions for test-security-check.py.

If the only reason `test-security-check.py` exists is to sanity-check a script that only runs in Guix, why would it need to work in any other environment.

💬 pablomartin4btc commented on pull request "httpserver, rest: improving URI validation":
(https://github.com/bitcoin/bitcoin/pull/27253#issuecomment-1576401038)
Updates:
- I've found the issue with the`fuzz`test I'll push a fix with the commits in reverse order.