💬 hebasto commented on pull request "Network Watch tool":
(https://github.com/bitcoin-core/gui/pull/444#issuecomment-1575558141)
Closing this due to lack of activity. Feel free to reopen.

✅ hebasto closed a pull request: "Network Watch tool"
(https://github.com/bitcoin-core/gui/pull/444)

📝 Brotcrunsher opened a pull request: "Sanitizing ports of -rpcconnect and -rpcport."
(https://github.com/bitcoin/bitcoin/pull/27820)
Previously, if they contained malformed ports they were silently interpreted as value%0xffff. Illegal ports now lead to an error. Additionally, if rpcconnect has a port and rpcport is set, a useful warning is now printed.

⚠️ wayudi208012 opened an issue: ""
(https://github.com/bitcoin/bitcoin/issues/27821)
I tend to agree - base58 has so few stand-alone uses outside of bitcoin,
that including bechs32 functionality and making it a combined library makes
sense imo.

On Tue, Jul 3, 2018, 13:00 Luke Dashjr <notifications@github.com> wrote:

> Any thoughts, @CoperNick8 <https://github.com/CoperNick8> @holland01
> <https://github.com/holland01> @randolf <https://github.com/randolf> @sipa
> <https://github.com/sipa> @laanwj <https://github.com/laanwj> @e271828-
> <https://github.co
...

✅ fanquake closed an issue: ""
(https://github.com/bitcoin/bitcoin/issues/27821)

:lock: fanquake locked an issue: ""
(https://github.com/bitcoin/bitcoin/issues/27821)

💬 achow101 commented on pull request "indicate explicit to the user that the wallet balances shown is watch only.":
(https://github.com/bitcoin-core/gui/pull/37#issuecomment-1575628144)
Concept ACK

I don't think this should be limited to just legacy wallets - descriptor wallets can have private keys disabled as well. This should probably apply to all wallets that have private keys disabled, as the the watch-only icon does.

📝 Brotcrunsher opened a pull request: "Renamed UniValue::__pushKV to UniValue::pushKVEnd."
(https://github.com/bitcoin/bitcoin/pull/27822)
Any identifier starting with 2 _ is reserved for the compiler and thus must not be used.

See: https://stackoverflow.com/a/228797/7130273

💬 hebasto commented on pull request "Renamed UniValue::__pushKV to UniValue::pushKVEnd.":
(https://github.com/bitcoin/bitcoin/pull/27822#issuecomment-1575641606)
See https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#scripted-diffs for changes like this.

💬 theStack commented on pull request "test: miner: add coverage for `-blockmintxfee` setting":
(https://github.com/bitcoin/bitcoin/pull/27620#discussion_r1216930591)
Thanks, done.

💬 theStack commented on pull request "test: miner: add coverage for `-blockmintxfee` setting":
(https://github.com/bitcoin/bitcoin/pull/27620#issuecomment-1575651619)
Thanks for reviewing! Addressed the nit.

> Just a thought that came to my mind while reviewing it:
>
> * Seems like these test coverage uses just 1 node, if we'd stop node1 right before line 81, it wouldn't make the test to fail. So, it seems that `-minrelaytxfee=0` is just to make `send_self_transfer` - which calls `sendrawtransaction` - not fail (even if we might not have any connection).

Yes indeed, this sub-test works with a single node (it follows the design of previously introduce
...

💬 joostjager commented on issue "Allow accepting non-standard transactions on mainnet via local rpc":
(https://github.com/bitcoin/bitcoin/issues/27768#issuecomment-1575661768)
For me the relevant part of this issue is enabling the annex, which is already discussed in several other places. Closing issue.

✅ joostjager closed an issue: "Allow accepting non-standard transactions on mainnet via local rpc"
(https://github.com/bitcoin/bitcoin/issues/27768)

💬 glozow commented on pull request "Avoiding unnecessary std::string copy in ArgsManager::GetPathArg argument list":
(https://github.com/bitcoin/bitcoin/pull/27812#issuecomment-1575663213)
Thank you for your contribution. We have a large amount of PRs requiring review attention, so closing this. Please see our contributing guidelines on [refactoring](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#refactoring) and [getting started](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#getting-started).

✅ glozow closed a pull request: "Avoiding unnecessary std::string copy in ArgsManager::GetPathArg argument list"
(https://github.com/bitcoin/bitcoin/pull/27812)

💬 kevkevinpal commented on pull request "wallet: Add tracing for sqlite statements":
(https://github.com/bitcoin/bitcoin/pull/27801#issuecomment-1575665937)
ACK https://github.com/bitcoin/bitcoin/commit/ff9d961bf38b24f8f931dcf66799cbc468e473df

💬 theStack commented on pull request "test: avoid sporadic MINIMALDATA failure in feature_taproot.py (fixes #27595)":
(https://github.com/bitcoin/bitcoin/pull/27631#issuecomment-1575671961)
Added a comment, as suggested by @instagibbs. Let me know what you think, suggestions very welcome.

@Sjors: thought about that approach too, but it seems that the devil is in the details; in your example, passing a single zero-byte would now wrongly translate to a OP_0 operation, which pushes a zero-length array instead. Concept ACK on fixing the test framework's CScript class to always correctly emit minimal-encoded scripts, but that seems to be a bigger operation that ideally also includes
...

📝 mzumsande opened a pull request: "init: return error when block index is non-contiguous, fix feature_init.py file perturbation"
(https://github.com/bitcoin/bitcoin/pull/27823)
When the block index database is non-contiguous due to file corruption (i.e. it contains indexes of height `x-1` and `x+1`, but not `x`), bitcoind can currently crash with an assert in `BuildSkip()` / `GetAncestor()` during `BlockManager::LoadBlockIndex()`:
```
bitcoind: chain.cpp:112: const CBlockIndex* CBlockIndex::GetAncestor(int) const: Assertion `pindexWalk->pprev' failed.
```
This PR changes it such that we instead return an `InitError` to the user.

I stumbled upon this because I no
...

💬 mzumsande commented on pull request "p2p, rpc: Manual block-relay-only connections with addnode":
(https://github.com/bitcoin/bitcoin/pull/24170#issuecomment-1575678278)
Seems like other proposals such as #27213 and #27509 that rely on improving automatic behavior have more support compared to this one (which needs manual setup by the node operator). Closing for now.

✅ mzumsande closed a pull request: "p2p, rpc: Manual block-relay-only connections with addnode"
(https://github.com/bitcoin/bitcoin/pull/24170)